Lioncash
c043a5c930
gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding()
Ensures both operands have the same sign in the comparison.
While we're at it, we can get rid of the redundant casting of ub_size to
an int. This type will always be trivial and alias a built-in type (not
doing so would break backwards compatibility at a standard level).
7 years ago
Lioncash
69bbe31ca8
renderer_base: Make Rasterizer() return the rasterizer by reference
All calling code assumes that the rasterizer will be in a valid state,
which is a totally fine assumption. The only way the rasterizer wouldn't
be is if initialization is done incorrectly or fails, which is checked
against in System::Init().
7 years ago
Lioncash
49dc22f84e
video_core: Eliminate the g_renderer global variable
We move the initialization of the renderer to the core class, while
keeping the creation of it and any other specifics in video_core. This
way we can ensure that the renderer is initialized and doesn't give
unfettered access to the renderer. This also makes dependencies on types
more explicit.
For example, the GPU class doesn't need to depend on the
existence of a renderer, it only needs to care about whether or not it
has a rasterizer, but since it was accessing the global variable, it was
also making the renderer a part of its dependency chain. By adjusting
the interface, we can get rid of this dependency.
7 years ago
bunnei
bf006dd1d4
Merge pull request #911 from lioncash/prototype
video_core: Remove unimplemented Start() function prototype
7 years ago
bunnei
a8755cb738
Merge pull request #913 from lioncash/unused-func
memory: Remove unused GetSpecialHandlers() function
7 years ago
bunnei
017fa55c0a
Merge pull request #914 from lioncash/codeset
kernel/process: Use accessors instead of class members for referencing segment array
7 years ago
bunnei
26a9093726
Merge pull request #917 from lioncash/crash
kernel/thread: Fix potential crashes introduced in 3bcf090d
7 years ago
Lioncash
6f3a3ed8c5
kernel/thread: Fix potential crashes introduced in 3bcf090d37
This amends cases where crashes can occur that were missed due to the
odd way the previous code was set up (using 3DS memory regions that
don't exist).
7 years ago
bunnei
46db65403f
Merge pull request #910 from lioncash/unused
gl_shader_decompiler: Remove unused variable in GenerateDeclarations()
7 years ago
Lioncash
73e1be4350
kernel/process: Use std::array where applicable
7 years ago
Lioncash
73f162a5b0
kernel/process: Use accessors instead of class members for referencing segment array
Using member variables for referencing the segments array increases the
size of the class in memory for little benefit. The same behavior can be
achieved through the use of accessors that just return the relevant
segment.
7 years ago
Lioncash
0e92e67e06
memory: Remove unused GetSpecialHandlers() function
This is just unused code, so we may as well get rid of it.
7 years ago
bunnei
67b4326d93
Merge pull request #908 from lioncash/memory
core/memory: Get rid of 3DS leftovers
7 years ago
bunnei
aab3e6753f
Merge pull request #909 from lioncash/const
gl_shader_manager: Make ProgramManager's GetCurrentProgramStage() a const member function
7 years ago
Lioncash
02cdd82efc
video_core: Remove unimplemented Start() function prototype
Given this has no definition, we can just remove it entirely.
7 years ago
Lioncash
c155adb42a
gl_shader_decompiler: Remove unused variable in GenerateDeclarations()
This variable was being incremented, but we were never actually using
it.
7 years ago
Lioncash
300a4e3d79
gl_shader_manager: Make ProgramManager's GetCurrentProgramStage() a const member function
This function doesn't modify class state, so it can be made const.
7 years ago
Lioncash
3bcf090d37
core/memory: Get rid of 3DS leftovers
Removes leftover code from citra that isn't needed.
8 years ago
David
4a4641a134
Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests ( #851 )
7 years ago
bunnei
1028560b4c
Merge pull request #895 from lioncash/sink
sink_details: std::move std::function instances
7 years ago
bunnei
485a6770e9
Merge pull request #898 from lioncash/mig
service: Add migration services
7 years ago
bunnei
ff296707b1
Merge pull request #900 from lioncash/init
math_util: Always initialize members of Rectangle
7 years ago
bunnei
299975e4a8
Merge pull request #892 from lioncash/global
video_core: Make global EmuWindow instance part of the base renderer …
8 years ago
bunnei
20b6c79859
Merge pull request #894 from lioncash/object
kernel: Move object class to its own source files
8 years ago
bunnei
9f560b2c57
Merge pull request #904 from lioncash/static
kernel/thread: Minor changes
8 years ago
bunnei
b6930f7a1e
Merge pull request #906 from lioncash/override
input_common: minor changes
8 years ago
bunnei
ca12628324
Merge pull request #907 from lioncash/slot
yuzu: Use Qt 5 signal/slots where applicable
8 years ago
bunnei
3ce7cf5e42
Merge pull request #905 from lioncash/vma
kernel/vm_manager: Minor changes
8 years ago
bunnei
f720eee031
Merge pull request #903 from lioncash/copy
vfs_vector: Minor changes
8 years ago
bunnei
309b596a21
Merge pull request #901 from lioncash/ref
gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader()
8 years ago
Lioncash
f90c667a44
yuzu: Use Qt 5 signal/slots where applicable
Makes the signal/slot connections type-safe instead of string-based.
8 years ago
Lioncash
fc2d6869bf
input_common: Use std::move where applicable
Avoids unnecessary atomic reference count increments and decrements
8 years ago
Lioncash
d682d53bb2
input_common: Add missing override specifiers
8 years ago
bunnei
403cb09019
Merge pull request #899 from lioncash/unused
hw: Remove unused files
8 years ago
bunnei
b57d279b57
Merge pull request #902 from lioncash/array
gl_state: Make texture_units a std::array
8 years ago
bunnei
4a087fed32
Merge pull request #891 from lioncash/ns
service/ns: Add missing ns services
8 years ago
greggameplayer
6abb522f98
Implement RGB32F PixelFormat ( #886 ) (used by Go Vacation)
8 years ago
bunnei
fc6356f5c2
Merge pull request #893 from lioncash/psc
service: Add the psc services
8 years ago
Lioncash
bf632d8e1e
kernel/vm_manager: Convert loop into std::any_of()
8 years ago
Lioncash
ec7319a5de
kernel/vm_manager: Use const where applicable
Makes our immutable state explicit.
8 years ago
Lioncash
26e2e7b657
kernel/vm_manager: Use the VAddr type alias in CarveVMA()
These two variables correspond to address ranges.
8 years ago
Lioncash
fa173d1874
kernel/thread: Make GetFreeThreadLocalSlot()'s loop indices size_t
Avoids using a u32 to compare against a range of size_t, which can be a
source of warnings. While we're at it, compress a std::tie into a
structured binding.
8 years ago
Lioncash
12afa56830
kernel/thread: Make GetFreeThreadLocalSlot() reference parameter a const reference
This function only reads the data being referenced, it doesn't modify
it, so we can turn the reference into a const reference.
8 years ago
Lioncash
16c5f5fe1b
kernel/thread: Make GetFreeThreadLocalSlot() internally linked
This function isn't used outside of this translation unit, so we can
make it internally linked.
8 years ago
Lioncash
5b317d1b80
vfs_vector: Remove unused variable in FindAndRemoveVectorElement()
This wasn't being used for anything, so it can be removed.
8 years ago
Lioncash
0bb1b9c168
vfs_vector: Avoid unnecessary copies where applicable
The lambda elements should be taken by const reference here, and we can
move the virtual directory passed to ReplaceFileWithSubdirectory()
8 years ago
Lioncash
68150d3d79
gl_state: Make texture_units a std::array
Gets rid of the use of a raw C array.
8 years ago
Lioncash
807d0cf4f2
gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader()
Avoids performing unnecessary copies of 65560 byte sized ShaderSetup
instances, considering it's only used as part of lookup and not
modified.
Given the parameters were already const, it's likely taking these
parameters by reference was intended but the ampersand was forgotten.
8 years ago
Lioncash
9f5ba9df95
math_util: Always initialize members of Rectangle
Prevents potentially using the members uninitialized.
8 years ago
Lioncash
db3603df94
hw: Remove unused files
None of these files are used in any meaningful way. They're just
leftovers from citra. Also has the benefit of getting rid of an unused
global variable.
8 years ago