Lioncash
997f43bdf8
common/file_util: Remove duplicated documentation comments
These are already present within the header, so they don't need to be
repeated in the cpp file.
7 years ago
Lioncash
44c3616ff7
common/file_util: Make ReadFileToString and WriteStringToFile consistent
Makes the parameter ordering consistent, and also makes the filename
parameter a std::string. A std::string would be constructed anyways with
the previous code, as IOFile's only constructor with a filepath is one
taking a std::string.
We can also make WriteStringToFile's string parameter utilize a
std::string_view for the string, making use of our previous changes to
IOFile.
7 years ago
Lioncash
9daa7baef7
common/file_util: Remove unnecessary c_str() calls
The file stream open functions have supported std::string overloads
since C++11, so we don't need to use c_str() here. Same behavior, less
code.
7 years ago
Lioncash
e71ba6388a
common/file_util: Make IOFile's WriteString take a std::string_view
We don't need to force the usage of a std::string here, and can instead
use a std::string_view, which allows writing out other forms of strings
(e.g. C-style strings) without any unnecessary heap allocations.
7 years ago
Lioncash
d9b4b49538
shader/decode/memory: Remove left in debug pragma
7 years ago
Lioncash
2bcec58614
renderer_opengl/gl_shader_decompiler: Remove redundant name specification in format string
This accidentally slipped through a rebase.
7 years ago
bunnei
2a0c0c04cf
Merge pull request #2455 from lioncash/config
configuration/config: Move config loading and saving to functions based off groups
7 years ago
bunnei
424a4d91b5
Merge pull request #2503 from lioncash/util
yuzu/game_list: Specify string conversions explicitly
7 years ago
bunnei
29628c3292
Merge pull request #2494 from lioncash/shader-text
gl_shader_decompiler: Add AddLine() overloads with single function that forwards to libfmt
7 years ago
Lioncash
b254ac5a1e
yuzu/game_list: Specify string conversions explicitly
Allows the game list code to compile successfully with implicit string
conversions disabled.
7 years ago
Lioncash
16afc41307
yuzu/game_list_worker: Specify string conversions explicitly
Allows the game list worker code to compile successfully with implicit
string conversions disabled.
7 years ago
Lioncash
4b1c7f1522
yuzu/game_list_p: Amend mentions of SMDH in comments
SMDH is a metadata format used in some executable formats for the
Nintendo 3DS. Switch executables don't utilize this metadata format, so
this just a holdover from Citra and can be corrected.
7 years ago
Lioncash
bb365da623
yuzu/game_list_p: Specify string conversions explicitly
Allows the game list item code to build with implicit string conversions
disabled.
7 years ago
Lioncash
4a0cedd6e7
yuzu/loading_screen: Specify string conversions explicitly
Allows the loading screen code to compile with implicit string
conversions disabled.
While we're at it remove unnecessary const usages, and add it to nearby
variables where appropriate.
7 years ago
Lioncash
b0fd32487c
yuzu/bootmanager: Specify string conversions explicitly
Allows the bootmanager code to compile with implicit string conversions
disabled.
7 years ago
Lioncash
409e0499d5
yuzu/util: Specify string conversions explicitly
Allows the util code to build with implicit string conversions disabled.
7 years ago
Lioncash
57c2a59e4c
gl_shader_decompiler: Tidy up minor remaining cases of unnecessary std::string concatenation
7 years ago
Lioncash
76254ee5b2
gl_shader_decompiler: Replace individual overloads with the fmt-based one
Gets rid of the need to special-case brace handling depending on the
overload used, and makes it consistent across the board with how fmt
handles them.
Strings with compile-time deducible strings are directly forwarded to
std::string's constructor, so we don't need to worry about the
performance difference here, as it'll be identical.
7 years ago
Lioncash
c5d1b1ee50
gl_shader_decompiler: Utilize fmt overload of AddLine() where applicable
7 years ago
bunnei
2aedfa5e5a
Merge pull request #2499 from lioncash/translate
yuzu/configuration: Specify string conversions explicitly
7 years ago
Hexagon12
4d209c96e3
Merge pull request #2500 from FernandoS27/revert-2466
Revert #2466
7 years ago
Fernando Sahmkow
891060f8f2
Revert #2466
This reverts a tested behavior on delay slots not exiting if the exit
flag is set. Currently new tests are required in order to ensure this
behavior.
7 years ago
Lioncash
98379b2ae1
gl_shader_decompiler: Add AddLine() overload that forwards to fmt
In a lot of places throughout the decompiler, string concatenation via
operator+ is used quite heavily. This is usually fine, when not heavily
used, but when used extensively, can be a problem. operator+ creates an
entirely new heap allocated temporary string and given we perform
expressions like:
std::string thing = a + b + c + d;
this ends up with a lot of unnecessary temporary strings being created
and discarded, which kind of thrashes the heap more than we need to.
Given we utilize fmt in some AddLine calls, we can make this a part of
the ShaderWriter's API. We can make an overload that simply acts as a
passthrough to fmt.
This way, whenever things need to be appended to a string, the operation
can be done via a single string formatting operation instead of
discarding numerous temporary strings. This also has the benefit of
making the strings themselves look nicer and makes it easier to spot
errors in them.
7 years ago
bunnei
5127e54674
Merge pull request #2441 from ReinUsesLisp/al2p
shader: Implement AL2P and ALD.PHYS
7 years ago
bunnei
a72ef964b4
Merge pull request #2410 from lioncash/affinity
kernel/svc: Reorganize and fix up the initial handling of svcSetThreadCoreMask()
7 years ago
Lioncash
a6309ae255
yuzu/configuration/configure_web: Specify string conversions explicitly
Allows the web config code to compile with implicit string conversions
disabled. We can also deduplicate the calls to create the pixmap.
7 years ago
Lioncash
e587f53654
yuzu/configuration/configure_system: Specify string conversions explicitly
Allows the system config code to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
24f3048353
yuzu/configuration/configure_profile_manager: Mark UI string as translatable
This is a user-facing string, so it should be marked as translatable.
7 years ago
Lioncash
328de6dfe3
yuzu/configuration/configure_per_general: Specify string conversions explicitly
Allows the per-game configuration to be successfully built with implicit
string conversions disabled.
7 years ago
Lioncash
e9de531962
yuzu/configuration/configure_mouse_advanced: Clean up array accesses
Deduplicates array accesses and uses a named variable where appropriate.
7 years ago
Lioncash
43e8e5d385
yuzu/configuration/configure_mouse_advanced: Specify string conversions explicitly
Allows the advanced mouse configuration code to build with implicit
string conversions disabled.
7 years ago
Lioncash
947c81af03
yuzu/configuration/configure_input_player: Clean up array accesses
Rather than repeatedly index arrays that have quite a large array index,
we can just use a named variable instead.
7 years ago
Lioncash
2f4062551d
yuzu/configuration/configure_input_player: Specify string conversions explicitly
Allows the player input configuration code to compile with implicit
string conversions disabled.
7 years ago
Hexagon12
1240fcaccf
Merge pull request #2491 from FernandoS27/dma-fix
Dma_pusher: ASSERT on empty command_list
7 years ago
Lioncash
1bea3a5ca2
yuzu/configuration/configure_input: Mark controller type names as translateable
These are user-facing strings, so they should be localizable.
7 years ago
Lioncash
5c55220ce5
yuzu/configuration/configure_general: Specify string conversions explicitly
Allows the general configuration code to successfully compile with
implicit string conversions disabled.
7 years ago
Lioncash
b9ae150964
yuzu/configuration/configure_gamelist: Specify string conversions explicitly
Allows the gamelist configuration code to compile with implicit string
conversions disabled.
7 years ago
Lioncash
ae29eaec01
yuzu/configuration/configure_audio: Store power on query into a variable
Avoids using the system accessor more than necessary, and ensures that
both dialog boxes see the same power on state.
7 years ago
Lioncash
1cd40afb05
yuzu/configuration/configure_audio: Tidy up function cast
We can just use qOverload here to tidy up the function cast.
7 years ago
Lioncash
10280072c2
yuzu/configuration/configure_audio: Specify string conversions explicitly
Allows the audio configuration code to build with implicit string
conversions disabled.
7 years ago
Hexagon12
9543443e89
Merge pull request #2452 from FernandoS27/raster-cache-fix
Correct possible error on Rasterizer Caches
7 years ago
Hexagon12
ef65b396bb
Merge pull request #2497 from lioncash/shader-ir
shader/shader_ir: Minor changes
7 years ago
Hexagon12
4ba26ae978
Merge pull request #2495 from lioncash/cache
gl_shader_disk_cache: Minor cleanup
7 years ago
Fernando Sahmkow
fc9a1b81cb
Dma_pusher: ASSERT on empty command_list
This is a measure to avoid crashes on command list reading as an empty
command_list is considered a NOP.
7 years ago
Hexagon12
5e517df3c7
Merge pull request #2439 from lioncash/audren
service/audren_u: Get rid of magic values within GetAudioRendererWorkBufferSize
7 years ago
Hexagon12
369534c6fd
Merge pull request #2467 from lioncash/move
video_core/gpu_thread: Remove redundant copy constructor for CommandDataContainer
7 years ago
Hexagon12
824fa78da3
Merge pull request #2463 from lioncash/set
service/set: Correct and simplify behavior related to copying language codes
7 years ago
Hexagon12
0275a6a8a4
Merge pull request #2466 from yuzu-emu/mme-exit-delay-slot
GPU/MMEInterpreter: Ignore the 'exit' flag when it's executed inside a delay slot.
7 years ago
Hexagon12
709885905d
Merge pull request #2468 from lioncash/deduction
yuzu: Remove explicit types from locks where applicable
7 years ago
Hexagon12
3973cb147e
Merge pull request #2472 from FernandoS27/tic
maxwell_3d: reduce severity of different component formats assert.
7 years ago