56cde60393
qt/game_list_p: Remove redundant base class constructor invocations
These occur automatically without the need to call them. While we're at
it, also std::move the QString instance into its member variable.
8 years ago
a648516863
qt: Add missing override specifiers where applicable
8 years ago
5de7c31baa
qt: Default destructors where applicable
Makes code consistent with our style of defaulting special member
functions where applicable.
8 years ago
11eadbccc9
kernel/event: Make data members private
Instead we can simply provide accessors to the required data instead of
giving external read/write access to the variables directly.
8 years ago
d77ba2a4df
Service/Audio: audout_a.cpp: remove pragma once
8 years ago
881573c77a
maxwell_3d: Remove outdated assert.
8 years ago
2bb2f176b1
gl_rasterizer_cache: Avoid superfluous surface copies.
8 years ago
610c7e7685
perf_stats: Correct literal used for MAX_LAG_TIME_US
ms is shorthand for milliseconds, not microseconds, and given there's no
comment indicating that this was intentional, it probably wasn't.
8 years ago
c34ee8cf08
core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds
Enforces the time unit being returned and also allows using the standard
time utilities to manipulate it.
8 years ago
ab21a210b1
memory: Make prototype parameter names match their definitions
Keeps the code consistent.
8 years ago
856edeb95d
memory: Correct prototype of ZeroBlock
Previously, the prototype wasn't matching the definition, which has a
Processor parameter before the destination address.
8 years ago
572bff0143
memory: Remove unnecessary const qualifiers in prototypes
These aren't necessary, as value-wise const only matters in the
definition.
8 years ago
82ab069b22
core_timing: Convert typedef into a type alias
Makes the alias a little more readable from left-to-right.
8 years ago
c03f854546
core_timing: Use transparent functors where applicable
Gets rid of the need to hardcode the type in multiple places. This will
now be deduced automatically, based off the elements in the container
being provided to the algorithm.
8 years ago
8d948e4f17
loader: Make AppLoader_NCA rely on directory loading code
Eliminates duplicate code shared between their Load methods, after all the only difference is how the romfs is handled.
8 years ago
a3e0a2d3b3
gdbstub: Use type alias for breakpoint maps
Rather than having to type out the full std::map type signature, we can
just use a straightforward alias. While we're at it, rename
GetBreakpointList to GetBreakpointMap, which makes the name more
accurate. We can also get rid of unnecessary u64 static_casts, since
VAddr is an alias for a u64.
8 years ago
6602a1b319
gdbstub: Move all file-static variables into the GDBStub namespace
Keeps everything under the same namespace. While we're at it, enclose
them all within an inner anonymous namespace.
8 years ago
65c0fe0d39
address_arbiter: Return by value from GetThreadsWaitingOnAddress()
In all cases the vector being supplied is empty, so we can just return
by value in these instances.
8 years ago
88023a481d
gdbstub: Replace PAddr alias with VAddr
In all cases, a virtual address is being passed in, not a physical one.
8 years ago
4215d08d37
gl_shader_decompiler: Fix TEXS mask and dest.
8 years ago
5904aa20ce
audio_core: Implement audren_u audio playback.
8 years ago
112a0b8d6d
added braces for conditions
8 years ago
45078c8b24
fix the attrib format for ints
8 years ago
600e4bbeac
audio_core: Use s16 where possible for audio samples.
8 years ago
7688b83a1c
audio_core: Port codec code from Citra for ADPCM decoding.
8 years ago
ed0e62fe9e
service: Add arp services
Adds the basic skeleton of the arp services based off the information
provided by Switch Brew.
8 years ago
2ce618c2c8
service: Remove redundant #pragma once directives
These don't do anything within .cpp files (we don't include cpp files,
so...)
8 years ago
c8617a1465
aes_util: Add static assertion to Transcode() and XTSTranscode() to ensure well-defined behavior
These functions should only be given trivially-copyable types.
8 years ago
f0a2d4da2b
aes_util: Make CalculateNintendoTweak() an internally linked function
This function doesn't directly depend on class state, so it can be
hidden entirely from the interface in the cpp file.
8 years ago
1fb5027501
aes_util: Make Transcode() a const member function
This doesn't modify member state, so it can be made const.
8 years ago
8b86a89dd5
core/crypto: Remove unnecessary includes
8 years ago
d74342ad3f
key_manager: Use regular std::string instead of std::string_view
The benefit of std::string_view comes from the idea of avoiding copies
(essentially acting as a non-owning view), however if we're just going
to copy into a local variable immediately, there's not much benefit
gained here.
8 years ago
950de5fd73
cubeb_sink: Support variable sample_rate and num_channels.
8 years ago
3150538b3f
content_archive: Add support for titlekey cryptography
8 years ago
97647e60f2
audio_core: Sinks need unique names as well.
8 years ago
7186882bfe
audio_core: Streams need unique names for CoreTiming.
8 years ago
32901799b5
gl_shader_manager: Invert conditional in SetShaderUniformBlockBinding()
This lets us indent the majority of the code and places the error case
first.
8 years ago
c043a5c930
gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding()
Ensures both operands have the same sign in the comparison.
While we're at it, we can get rid of the redundant casting of ub_size to
an int. This type will always be trivial and alias a built-in type (not
doing so would break backwards compatibility at a standard level).
8 years ago
69bbe31ca8
renderer_base: Make Rasterizer() return the rasterizer by reference
All calling code assumes that the rasterizer will be in a valid state,
which is a totally fine assumption. The only way the rasterizer wouldn't
be is if initialization is done incorrectly or fails, which is checked
against in System::Init().
8 years ago
49dc22f84e
video_core: Eliminate the g_renderer global variable
We move the initialization of the renderer to the core class, while
keeping the creation of it and any other specifics in video_core. This
way we can ensure that the renderer is initialized and doesn't give
unfettered access to the renderer. This also makes dependencies on types
more explicit.
For example, the GPU class doesn't need to depend on the
existence of a renderer, it only needs to care about whether or not it
has a rasterizer, but since it was accessing the global variable, it was
also making the renderer a part of its dependency chain. By adjusting
the interface, we can get rid of this dependency.
8 years ago
6f3a3ed8c5
kernel/thread: Fix potential crashes introduced in 3bcf090d37
This amends cases where crashes can occur that were missed due to the
odd way the previous code was set up (using 3DS memory regions that
don't exist).
8 years ago
73e1be4350
kernel/process: Use std::array where applicable
8 years ago
73f162a5b0
kernel/process: Use accessors instead of class members for referencing segment array
Using member variables for referencing the segments array increases the
size of the class in memory for little benefit. The same behavior can be
achieved through the use of accessors that just return the relevant
segment.
8 years ago
0e92e67e06
memory: Remove unused GetSpecialHandlers() function
This is just unused code, so we may as well get rid of it.
8 years ago
02cdd82efc
video_core: Remove unimplemented Start() function prototype
Given this has no definition, we can just remove it entirely.
8 years ago
c155adb42a
gl_shader_decompiler: Remove unused variable in GenerateDeclarations()
This variable was being incremented, but we were never actually using
it.
8 years ago
300a4e3d79
gl_shader_manager: Make ProgramManager's GetCurrentProgramStage() a const member function
This function doesn't modify class state, so it can be made const.
8 years ago
3bcf090d37
core/memory: Get rid of 3DS leftovers
Removes leftover code from citra that isn't needed.
8 years ago
4a4641a134
Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests ( #851 )
8 years ago
f90c667a44
yuzu: Use Qt 5 signal/slots where applicable
Makes the signal/slot connections type-safe instead of string-based.
8 years ago
Lioncash