bunnei
c0ac666e2f
Merge pull request #5167 from lioncash/doc-memory
memory: Resolve -Wdocumentation warning for Write()
5 years ago
Lioncash
024c10b697
memory: Resolve -Wdocumentation warning for Write()
Write() doesn't return anything, so the @returns tag shouldn't be
present.
5 years ago
bunnei
c9d7c96b27
Merge pull request #5156 from comex/xx-raws
configure_motion_touch: Fix unescaped backslash in regex
5 years ago
Morph
8aa4a6d501
Merge pull request #5165 from lioncash/copy-controller
controller: Avoid unnecessary copies in ConfigurationComplete()
5 years ago
Lioncash
fb0e41b085
controller: Use std::move within ConvertToFrontendParameters()
Avoids unnecessary copies.
5 years ago
Lioncash
b3a31de3b9
controller: Avoid unnecessary copies in ConfigurationComplete()
Avoids unnecessary 1072 byte copies when querying info about
controllers.
5 years ago
Morph
439488a842
Merge pull request #5020 from german77/AnalogfromButtonFix
Disable analog joystick from buttons by default
5 years ago
german
1a3e4518ec
Disable analog joystick from buttons by default
5 years ago
Rodrigo Locatti
bbf78a6df7
Merge pull request #5164 from lioncash/contains
video_core: Make use of ordered container contains() where applicable
5 years ago
Rodrigo Locatti
f80d120d67
Merge pull request #5163 from lioncash/concat
ast: Improve string concat readability in operator()
5 years ago
bunnei
1613bbab8a
Merge pull request #5153 from comex/xx-unix
CMakeLists,network: Create YUZU_UNIX macro to replace __unix__
5 years ago
Lioncash
909671a055
video_core: Make use of ordered container contains() where applicable
With C++20, we can use the more concise contains() member function
instead of comparing the result of the find() call with the end
iterator.
5 years ago
Lioncash
4d6a2247f2
ast: Improve string concat readability in operator()
Provides an in-place format string to make it more pleasant to read.
5 years ago
bunnei
72378f4f6c
Merge pull request #5149 from comex/xx-map-interval
map_interval: Change field order to address uninitialized field warning
5 years ago
Rodrigo Locatti
73f3e1cbf3
Merge pull request #5159 from lioncash/move-amend
shader_ir: std::move node within DeclareAmend()
5 years ago
Rodrigo Locatti
4cab52f258
Merge pull request #5160 from lioncash/buffer-header
buffer_block: Remove unnecessary includes
5 years ago
Lioncash
4704a22c3f
buffer_block: Mark interface as nodiscard where applicable
Prevents logic errors from occurring from unused values.
5 years ago
Lioncash
7caec76970
buffer_block: Remove unnecessary includes
Reduces the amount of dependencies the header pulls in.
5 years ago
Rodrigo Locatti
81249bc311
Merge pull request #5158 from lioncash/video-fmt
video_core: Remove unnecessary enum class casting in logging messages
5 years ago
bunnei
9ba99af200
Merge pull request #5148 from comex/xx-unused-fields
core: Mark unused fields as [[maybe_unused]]
5 years ago
bunnei
6324f1e67f
Merge pull request #5154 from comex/xx-ipc
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
5 years ago
Lioncash
0e7ead8b49
shader_ir: std::move node within DeclareAmend()
Same behavior, but elides an unnecessary atomic reference count
increment and decrement.
5 years ago
Lioncash
ea0e85b869
video_core: Remove unnecessary enum class casting in logging messages
fmt now automatically prints the numeric value of an enum class member
by default, so we don't need to use casts any more.
Reduces the line noise a bit.
5 years ago
LC
7694cb9154
Merge pull request #5147 from comex/xx-purevirt
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
5 years ago
LC
5afcc5fb3d
Merge pull request #5150 from comex/xx-boxcat
boxcat: Avoid unnecessary object copy
5 years ago
LC
f2ca2f4412
Merge pull request #5152 from comex/xx-override
renderer_vulkan: Add missing `override` specifier
5 years ago
LC
60ba2d11df
Merge pull request #5136 from lioncash/video-shadow3
video_core: Resolve more variable shadowing scenarios pt.3
5 years ago
comex
14f8c5e6fe
configure_motion_touch: Fix unescaped backslash in regex
Since this is inside a string literal, backslashes that are part of
regex syntax have to be escaped. But that's ugly, so convert to a raw
string instead.
5 years ago
LC
7aa6cf6b41
Merge pull request #5155 from comex/xx-default
Fix "explicitly defaulted but implicitly deleted" warning
5 years ago
comex
086238f1ac
Fix "explicitly defaulted but implicitly deleted" warning
`PhysicalCore`'s move assignment operator was declared as `= default`,
but was implicitly deleted because `PhysicalCore` has fields
of reference type. Switch to explicitly deleting it to avoid a Clang
warning.
The move *constructor* is still defaulted, and is required to exist due
to the use of `std::vector<PhysicalCore>`.
5 years ago
comex
63994da5c3
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
- Add a type check so that calling Push with an invalid type produces a
compile error rather than a linker error.
- vi.cpp was calling Push with a variable of type `std::size_t`.
There's no explicit overload for `size_t`, but there is one for `u64`,
which on most platforms is the same type as `size_t`. On macOS,
however, it isn't: both types are 64 bits, but `size_t` is `unsigned
long` and `u64` is `unsigned long long`. Regardless, it makes more
sense to explicitly use `u64` here instead of `size_t`.
5 years ago
comex
3c7962df41
CMakeLists,network: Create YUZU_UNIX macro to replace __unix__
__unix__ is not predefined on Apple platforms even though they are Unix.
5 years ago
comex
2451a59949
renderer_vulkan: Add missing `override` specifier
5 years ago
comex
ef14bbc69d
map_interval: Change field order to address uninitialized field warning
Clang complains about `new_chunk`'s constructor using the
then-uninitialized `first_chunk` (even though it's just to get a pointer
into it).
5 years ago
comex
cf99d67e66
core: Mark unused fields as [[maybe_unused]]
5 years ago
comex
8e924224df
boxcat: Avoid unnecessary object copy
5 years ago
LC
03aee5c798
Merge pull request #5146 from comex/xx-num
video_core: Adjust `NUM` macro to avoid Clang warning
5 years ago
comex
e250594b6e
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
5 years ago
comex
38f4b34610
video_core: Adjust `NUM` macro to avoid Clang warning
The previous definition was:
#define NUM(field_name) (sizeof(Maxwell3D::Regs::field_name) / sizeof(u32))
In cases where `field_name` happens to refer to an array, Clang thinks
`sizeof(an array value) / sizeof(a type)` is an instance of the idiom
where `sizeof` is used to compute an array length. So it thinks the
type in the denominator ought to be the array element type, and warns if
it isn't, assuming this is a mistake.
In reality, `NUM` is not used to get array lengths at all, so there is no
mistake. Silence the warning by applying Clang's suggested workaround
of parenthesizing the denominator.
5 years ago
Rodrigo Locatti
722001f513
Merge pull request #5143 from comex/xx-users-size
yuzu_cmd: Remove 'users_size'
5 years ago
Rodrigo Locatti
216928a60b
Merge pull request #5141 from comex/xx-true-false
maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict
5 years ago
bunnei
ee884dbd69
Merge pull request #5140 from FearlessTobi/port-5577
Port citra-emu/citra#5577 : "Update cubeb and request a persistent stream session"
5 years ago
bunnei
dbacf065f4
Merge pull request #5132 from lioncash/xbyak-abi
xbyak_abi: Avoid implicit sign conversions
5 years ago
bunnei
d6bb5cf7c7
Merge pull request #5139 from lioncash/deprecated-qt
game_list_p: Resolve deprecated usage of QVariant operator<
5 years ago
comex
20f4c9175a
maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict
On Apple platforms, FALSE and TRUE are defined as macros by
<mach/boolean.h>, which is included by various system headers.
Note that there appear to be no actual users of the names to fix up.
5 years ago
comex
278bbcb8d7
yuzu_cmd: Remove 'users_size'
Specifically:
const auto size = sdl2_config->GetInteger("System", "users_size", 0);
The variable is never used, producing a warning. I wondered if this
ought to be assigning something to in `Settings`, but nothing else in
the codebase ever mentions a setting called "users_size", so I guess
it's safe to remove...
5 years ago
Vitor Kiguchi
31a3bf1b8c
Update cubeb and request a persistent stream session
5 years ago
Lioncash
5db4785535
video_core: Resolve more variable shadowing scenarios pt.3
Cleans out the rest of the occurrences of variable shadowing and makes
any further occurrences of shadowing compiler errors.
5 years ago
Lioncash
66bb735a95
game_list_p: Resolve deprecated usage of QVariant operator<
This is designated as obsolete in Qt's docs (see:
https://doc.qt.io/qt-5/qvariant-obsolete.html#operator-lt )
5 years ago
Chloe
fe9823a520
Merge pull request #5133 from lioncash/video-shadow2
video_core: Resolve more variable shadowing scenarios pt.2
5 years ago