9aa2bfc60c
loader: Fix scope error in DeconstructedRomDirectory
7 years ago
e1625fdbec
nvdrv: Make Ioctl()'s definition match its prototype
The only reason this wasn't a compilation error is because we use
little-endian systems.
8 years ago
5bdcce6955
nvdrv: Get rid of indirect inclusions
8 years ago
fef6c33e77
Make building cubeb optional
8 years ago
0c0bdb7d9e
service/time: Amend command IDs of ToPosixTime() and ToPosixTimeWithMyRule()
Updates the ID of these based off the information on Switch Brew.
8 years ago
705c5b6166
service: Add usb services
Adds basic skeleton for the usb services based off the information provided by Switch Brew.
8 years ago
5fcac98ec8
client_port: Make all data members private
These members don't need to be entirely exposed, we can instead expose
an API to operate on them without directly needing to mutate them
We can also guard against overflow/API misuse this way as well, given
active_sessions is an unsigned value.
8 years ago
3e421bb6fb
GDBStub works with both Unicorn and Dynarmic now ( #941 )
* GDBStub works with both Unicorn and Dynarmic now
* Tidy up
8 years ago
4de0824ad2
qt/main: Avoid sign conversions in UpdateRecentFiles()
This was intermixing signed and unsigned values when they could all just
be signed.
8 years ago
35f1943b0f
game_list: Remove unnecessary conversion to std::string in ValidateEntry()
We can just use the file interfaces that Qt provides to prevent needing
to convert to std::string.
8 years ago
2d3b313879
game_list: Use QString::fromStdString() where applicable instead of c_str()
The codec used by Qt for const char* and std::string don't necessarily
have to be the same depending on locale. Therefore, we should be using
the correct functions to do the conversions.
8 years ago
c41c5028db
game_list: Join declarations and assignments in onTextChanged()
There's no need to keep these separate from one another.
8 years ago
9790f8c9ff
qt/main: Collapse if statement in UpdateRecentFiles()
Given the function accepts a boolean, we don't need to use an if
statement here and repeat ourselves.
8 years ago
0c6d371dd0
qt/main: Better file-existence checking within OnMenuRecentFile() and UpdateUITheme()
In OnMenuRecentFile() we don't need to construct a QFileInfo instance
just to check if a file exists, we can just use the static member
function to do that (which Qt's documentation also notes as quicker than
constructing an instance).
In UpdateUITheme(), we just want to try and open the file and check the
success of that operation. Technically speaking, between the existence
check and the open call, the file can be deleted or moved, but still
appear to succeed in code. i.e.
1. Existence check -> Returns true
2. File is moved/deleted
3. Open is called, the return value of which isn't checked
4. Nonsense behavior
This way we combine the existence check and the open into one.
8 years ago
ab6bc68bc1
qt: Don't show error dialog when canceling the Load Folder dialog
Previously, when canceling out of the Load Folder dialog, a user would
get an error dialog about the selected folder not containing a main
file, however, by canceling out of the dialog, no selection was actually
made.
8 years ago
56cde60393
qt/game_list_p: Remove redundant base class constructor invocations
These occur automatically without the need to call them. While we're at
it, also std::move the QString instance into its member variable.
8 years ago
a648516863
qt: Add missing override specifiers where applicable
8 years ago
5de7c31baa
qt: Default destructors where applicable
Makes code consistent with our style of defaulting special member
functions where applicable.
8 years ago
11eadbccc9
kernel/event: Make data members private
Instead we can simply provide accessors to the required data instead of
giving external read/write access to the variables directly.
8 years ago
d77ba2a4df
Service/Audio: audout_a.cpp: remove pragma once
8 years ago
881573c77a
maxwell_3d: Remove outdated assert.
8 years ago
2bb2f176b1
gl_rasterizer_cache: Avoid superfluous surface copies.
8 years ago
610c7e7685
perf_stats: Correct literal used for MAX_LAG_TIME_US
ms is shorthand for milliseconds, not microseconds, and given there's no
comment indicating that this was intentional, it probably wasn't.
8 years ago
c34ee8cf08
core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds
Enforces the time unit being returned and also allows using the standard
time utilities to manipulate it.
8 years ago
ab21a210b1
memory: Make prototype parameter names match their definitions
Keeps the code consistent.
8 years ago
856edeb95d
memory: Correct prototype of ZeroBlock
Previously, the prototype wasn't matching the definition, which has a
Processor parameter before the destination address.
8 years ago
572bff0143
memory: Remove unnecessary const qualifiers in prototypes
These aren't necessary, as value-wise const only matters in the
definition.
8 years ago
82ab069b22
core_timing: Convert typedef into a type alias
Makes the alias a little more readable from left-to-right.
8 years ago
c03f854546
core_timing: Use transparent functors where applicable
Gets rid of the need to hardcode the type in multiple places. This will
now be deduced automatically, based off the elements in the container
being provided to the algorithm.
8 years ago
8d948e4f17
loader: Make AppLoader_NCA rely on directory loading code
Eliminates duplicate code shared between their Load methods, after all the only difference is how the romfs is handled.
8 years ago
a3e0a2d3b3
gdbstub: Use type alias for breakpoint maps
Rather than having to type out the full std::map type signature, we can
just use a straightforward alias. While we're at it, rename
GetBreakpointList to GetBreakpointMap, which makes the name more
accurate. We can also get rid of unnecessary u64 static_casts, since
VAddr is an alias for a u64.
8 years ago
6602a1b319
gdbstub: Move all file-static variables into the GDBStub namespace
Keeps everything under the same namespace. While we're at it, enclose
them all within an inner anonymous namespace.
8 years ago
65c0fe0d39
address_arbiter: Return by value from GetThreadsWaitingOnAddress()
In all cases the vector being supplied is empty, so we can just return
by value in these instances.
8 years ago
88023a481d
gdbstub: Replace PAddr alias with VAddr
In all cases, a virtual address is being passed in, not a physical one.
8 years ago
4215d08d37
gl_shader_decompiler: Fix TEXS mask and dest.
8 years ago
5904aa20ce
audio_core: Implement audren_u audio playback.
8 years ago
112a0b8d6d
added braces for conditions
8 years ago
45078c8b24
fix the attrib format for ints
8 years ago
600e4bbeac
audio_core: Use s16 where possible for audio samples.
8 years ago
7688b83a1c
audio_core: Port codec code from Citra for ADPCM decoding.
8 years ago
ed0e62fe9e
service: Add arp services
Adds the basic skeleton of the arp services based off the information
provided by Switch Brew.
8 years ago
2ce618c2c8
service: Remove redundant #pragma once directives
These don't do anything within .cpp files (we don't include cpp files,
so...)
8 years ago
c8617a1465
aes_util: Add static assertion to Transcode() and XTSTranscode() to ensure well-defined behavior
These functions should only be given trivially-copyable types.
8 years ago
f0a2d4da2b
aes_util: Make CalculateNintendoTweak() an internally linked function
This function doesn't directly depend on class state, so it can be
hidden entirely from the interface in the cpp file.
8 years ago
1fb5027501
aes_util: Make Transcode() a const member function
This doesn't modify member state, so it can be made const.
8 years ago
8b86a89dd5
core/crypto: Remove unnecessary includes
8 years ago
d74342ad3f
key_manager: Use regular std::string instead of std::string_view
The benefit of std::string_view comes from the idea of avoiding copies
(essentially acting as a non-owning view), however if we're just going
to copy into a local variable immediately, there's not much benefit
gained here.
8 years ago
950de5fd73
cubeb_sink: Support variable sample_rate and num_channels.
8 years ago
97647e60f2
audio_core: Sinks need unique names as well.
8 years ago
7186882bfe
audio_core: Streams need unique names for CoreTiming.
8 years ago
Zach Hilman