ffc1f4df39
input_common: nitpick about SetHatButton usage
4 years ago
e3ee079aa4
input_common: fix copy-paste error
Found by static analysis with PVS-Studio.
4 years ago
991460cd98
input_common: Reintroduce motion from mouse and use button names
4 years ago
3465aa5d57
Xbox controller default name nit pick
Discord User moon lacer pointed us that official name is 'Xbox' not 'XBox'
4 years ago
ede1976820
Change default name for ps controllers
Minor nitpick
Code is from narr
4 years ago
b6c23d1633
input_common: Handle errors on TAS scripts
4 years ago
0e1d2581b7
input_common: Fix udp motion not automapping to both sides
4 years ago
353317f31e
yuzu: Add controller hotkeys
4 years ago
10439bbfff
input_common: Use accelerometer data for mapping
4 years ago
e1250d7303
[input_common] Move variable declaration closer to usage
MSVC supplied with VS2022 generates "warning C4189: 'CALIBRATION_THRESHOLD':
local variable is initialized but not referenced" which is treated as an
error.
Circumvent it by moving constexpr variable directly into body of lambda function.
4 years ago
af37388ee5
input/SDL: Update SDL hints
SDL_HINT_JOYSTICK_HIDAPI_SWITCH_HOME_LED is no longer needed thanks to new default in SDL 2.0.18.
SDL_HINT_JOYSTICK_HIDAPI_XBOX is reported to cause conflicts with native driver Xbox driver on Linux, and Xbox controllers don't benefit from hidapi anyways.
4 years ago
726de453bb
common/input: Avoid numerous large copies of CallbackStatus
CallbackStatus instances aren't the cheapest things to copy around
(relative to everything else), given that they're currently 520 bytes in
size and are currently copied numerous times when callbacks are invoked.
Instead, we can pass the status by const reference to avoid all the
copying.
4 years ago
3dbb700714
input_poller: Add missing override specifiers
4 years ago
46c7e48143
input_mapping: Amend specification of parameters
param tags are supposed to specify the parameter name without any
quoting.
Silences several -Wdocumentation warnings.
4 years ago
c73ebb7d89
input_poller: Remove several unnecessary @param tags
Silences quite a bit of -Wdocumentation warnings, given the @param tag
is only intended to be used to identify function parameters, not what it
contains.
4 years ago
f63a50ce9d
tas_input: Avoid minor copies in Read/WriteCommandButtons()
We don't need to copy the whole pair
4 years ago
bac72cecf9
tas_input: Remove unnecessary semicolon
Resolves a -Wextra-semi warning
4 years ago
6a9fe940d2
tas_input: Execute clear() even if empty
clear() when empty is simply a no-op, so we can get rid of the check
here and let the stdlib do it for us.
4 years ago
8b6137eb79
tas_input: Remove unnecessary includes
Gets rid of indirect includes and includes only what the interface
needs.
4 years ago
4284fe0d78
tas_input: std::move strings into vector
While we're in the same area, we can also avoid performing std::stoi in
a loop when it only needs to be performed once.
4 years ago
c12653670c
tas_input: Use istringstream over stringstream
This is only using the input facilities, so we don't need to use the
fully-fleged stringstream.
4 years ago
4dce3a6cf4
tas_input: Use u8string_view instead of u8string
Same behavior, but without the potential for extra allocations.
4 years ago
b2c94d8cd4
tas_input: Remove unused std::smatch variable
This also means we can get rid of the dependency on <regex>
4 years ago
f1ff42541a
tas_input: Amend -Wdocumentation warnings
Parameters shouldn't have the colon by their name.
4 years ago
a82bb17b08
tas_input: Make TasAxes enum an enum class
Prevents these values from potentially clashing with anything in other
headers.
4 years ago
71467b1383
input_engine: Fix typo in TriggerOnAxisChange() parameter name
4 years ago
e609218c0f
input_engine: Simplify PreSet* family of functions
We can make use of try_emplace() to insert values only if they don't
already exist.
4 years ago
14f7f35957
input_engine: Avoid redundant map lookups
We can use iterators to avoid looking up into maps twice in the getter
functions.
At the same time we can also avoid copying the ControllerData structs,
since they're 264 bytes in size.
4 years ago
e7c5737e2e
input_engine: Remove left-over namespace qualifiers
These types are part of the InputCommon namespace.
4 years ago
f8db0a76af
input_engine: Iterate by reference rather than by value where applicable
Avoids creating copies of several object instances (some of which being
over 100 bytes in size).
4 years ago
190cfc5997
input_engine: Take BasicMotion by const reference with SetMotion() and TriggerOnMotionChange()
Copies the BasicMotion instance once instead of twice.
4 years ago
e0e9f98fc6
input_engine: std::move InputIdentifier in SetCallback()
Allows avoiding std::function allocations.
4 years ago
cd45635f56
input_engine: Pass LedStatus by const reference
Avoids copies where reasonably applicable
4 years ago
f41c22d30f
input_engine: Pass VibrationStatus by const reference in SetRumble()
Avoids creating copies of the struct where not necessary.
4 years ago
54e164d9de
input_engine: std::move engine name where applicable
We can allow the name to be moved into, allowing allocations to be
avoided.
4 years ago
d62545828a
input_engine: Remove callback clearing in constructor
The callback map is a member variable, so this will always be empty on
initial construction.
4 years ago
7e34562d34
input_engine: Remove unnecessary semi-colons
Silences -Wextra-semi warnings
4 years ago
caae5d3868
input_engine: Remove unnecessary return
This is a void function, so it doesn't need this.
4 years ago
48537c07cd
input_common: Fix error with thread name
4 years ago
e899505921
Revert of 1dabf6d
Caused worker_thread to be stuck in Stage1Completed state until job's destruction.
4 years ago
bd95c199bc
[input_common] Add completion test for CalibrationConfigurationJob
4 years ago
7b56b2cab6
input_common: Fully implement UDP controllers
4 years ago
b8b849dc2e
input_common: Move button names to the frontend
4 years ago
bc9641614d
input_common: Fix SDL controller with inverted axis
4 years ago
30de38ee7f
kraken: Address comments from review
Fix compiler bug
4 years ago
25521cd948
core/hid: Improve accuary of mouse implementation
4 years ago
dfb63175d1
core/hid: Fully implement native mouse
4 years ago
6032358402
input_common: Allow keyboard to be backwards compatible
4 years ago
ebfe40dec8
core/hid: Improve accuracy of the keyboard implementation
4 years ago
94c972fb36
input_common: Fix motion from 3 axis
4 years ago
Valeri