3dbb700714
input_poller: Add missing override specifiers
4 years ago
46c7e48143
input_mapping: Amend specification of parameters
param tags are supposed to specify the parameter name without any
quoting.
Silences several -Wdocumentation warnings.
4 years ago
c73ebb7d89
input_poller: Remove several unnecessary @param tags
Silences quite a bit of -Wdocumentation warnings, given the @param tag
is only intended to be used to identify function parameters, not what it
contains.
4 years ago
f63a50ce9d
tas_input: Avoid minor copies in Read/WriteCommandButtons()
We don't need to copy the whole pair
4 years ago
bac72cecf9
tas_input: Remove unnecessary semicolon
Resolves a -Wextra-semi warning
4 years ago
6a9fe940d2
tas_input: Execute clear() even if empty
clear() when empty is simply a no-op, so we can get rid of the check
here and let the stdlib do it for us.
4 years ago
8b6137eb79
tas_input: Remove unnecessary includes
Gets rid of indirect includes and includes only what the interface
needs.
4 years ago
4284fe0d78
tas_input: std::move strings into vector
While we're in the same area, we can also avoid performing std::stoi in
a loop when it only needs to be performed once.
4 years ago
c12653670c
tas_input: Use istringstream over stringstream
This is only using the input facilities, so we don't need to use the
fully-fleged stringstream.
4 years ago
4dce3a6cf4
tas_input: Use u8string_view instead of u8string
Same behavior, but without the potential for extra allocations.
4 years ago
b2c94d8cd4
tas_input: Remove unused std::smatch variable
This also means we can get rid of the dependency on <regex>
4 years ago
f1ff42541a
tas_input: Amend -Wdocumentation warnings
Parameters shouldn't have the colon by their name.
4 years ago
a82bb17b08
tas_input: Make TasAxes enum an enum class
Prevents these values from potentially clashing with anything in other
headers.
4 years ago
71467b1383
input_engine: Fix typo in TriggerOnAxisChange() parameter name
4 years ago
e609218c0f
input_engine: Simplify PreSet* family of functions
We can make use of try_emplace() to insert values only if they don't
already exist.
4 years ago
14f7f35957
input_engine: Avoid redundant map lookups
We can use iterators to avoid looking up into maps twice in the getter
functions.
At the same time we can also avoid copying the ControllerData structs,
since they're 264 bytes in size.
4 years ago
e7c5737e2e
input_engine: Remove left-over namespace qualifiers
These types are part of the InputCommon namespace.
4 years ago
f8db0a76af
input_engine: Iterate by reference rather than by value where applicable
Avoids creating copies of several object instances (some of which being
over 100 bytes in size).
4 years ago
190cfc5997
input_engine: Take BasicMotion by const reference with SetMotion() and TriggerOnMotionChange()
Copies the BasicMotion instance once instead of twice.
4 years ago
e0e9f98fc6
input_engine: std::move InputIdentifier in SetCallback()
Allows avoiding std::function allocations.
4 years ago
cd45635f56
input_engine: Pass LedStatus by const reference
Avoids copies where reasonably applicable
4 years ago
f41c22d30f
input_engine: Pass VibrationStatus by const reference in SetRumble()
Avoids creating copies of the struct where not necessary.
4 years ago
54e164d9de
input_engine: std::move engine name where applicable
We can allow the name to be moved into, allowing allocations to be
avoided.
4 years ago
d62545828a
input_engine: Remove callback clearing in constructor
The callback map is a member variable, so this will always be empty on
initial construction.
4 years ago
7e34562d34
input_engine: Remove unnecessary semi-colons
Silences -Wextra-semi warnings
4 years ago
caae5d3868
input_engine: Remove unnecessary return
This is a void function, so it doesn't need this.
4 years ago
48537c07cd
input_common: Fix error with thread name
4 years ago
e899505921
Revert of 1dabf6d
Caused worker_thread to be stuck in Stage1Completed state until job's destruction.
4 years ago
bd95c199bc
[input_common] Add completion test for CalibrationConfigurationJob
4 years ago
7b56b2cab6
input_common: Fully implement UDP controllers
4 years ago
b8b849dc2e
input_common: Move button names to the frontend
4 years ago
bc9641614d
input_common: Fix SDL controller with inverted axis
4 years ago
30de38ee7f
kraken: Address comments from review
Fix compiler bug
4 years ago
25521cd948
core/hid: Improve accuary of mouse implementation
4 years ago
dfb63175d1
core/hid: Fully implement native mouse
4 years ago
6032358402
input_common: Allow keyboard to be backwards compatible
4 years ago
ebfe40dec8
core/hid: Improve accuracy of the keyboard implementation
4 years ago
94c972fb36
input_common: Fix motion from 3 axis
4 years ago
a4cdafed54
core/hid: Prevent Emulated controller from flapping with multiple inputs devices
4 years ago
93997b234f
core/hid: Fully emulate motion from button
4 years ago
4736326a05
second commit lion review
4 years ago
a8852024b6
settings: Fix Debug controller type options
4 years ago
9f91335a71
kraken: Address comments from review
start lion review
4 years ago
f63c6fce6d
input_common: Revert deleted TAS functions
4 years ago
254d133be2
input_common: Fix GC adapter initialization
Fix GC controller
4 years ago
3cd0dd4227
input_common: Fix UDP uuid
4 years ago
124404e756
input_common: Add multiple vibration curves
4 years ago
012691087a
core/hid: Rework battery mappings
4 years ago
ae6ba2c8bd
input_common: Add manual update options to input devices
4 years ago
d1bac9024d
settings: Fix mouse and keyboard mappings
4 years ago
Lioncash