112a0b8d6d
added braces for conditions
8 years ago
45078c8b24
fix the attrib format for ints
8 years ago
ed0e62fe9e
service: Add arp services
Adds the basic skeleton of the arp services based off the information
provided by Switch Brew.
8 years ago
2ce618c2c8
service: Remove redundant #pragma once directives
These don't do anything within .cpp files (we don't include cpp files,
so...)
8 years ago
c8617a1465
aes_util: Add static assertion to Transcode() and XTSTranscode() to ensure well-defined behavior
These functions should only be given trivially-copyable types.
8 years ago
f0a2d4da2b
aes_util: Make CalculateNintendoTweak() an internally linked function
This function doesn't directly depend on class state, so it can be
hidden entirely from the interface in the cpp file.
8 years ago
1fb5027501
aes_util: Make Transcode() a const member function
This doesn't modify member state, so it can be made const.
8 years ago
8b86a89dd5
core/crypto: Remove unnecessary includes
8 years ago
d74342ad3f
key_manager: Use regular std::string instead of std::string_view
The benefit of std::string_view comes from the idea of avoiding copies
(essentially acting as a non-owning view), however if we're just going
to copy into a local variable immediately, there's not much benefit
gained here.
8 years ago
32901799b5
gl_shader_manager: Invert conditional in SetShaderUniformBlockBinding()
This lets us indent the majority of the code and places the error case
first.
8 years ago
c043a5c930
gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding()
Ensures both operands have the same sign in the comparison.
While we're at it, we can get rid of the redundant casting of ub_size to
an int. This type will always be trivial and alias a built-in type (not
doing so would break backwards compatibility at a standard level).
8 years ago
6f3a3ed8c5
kernel/thread: Fix potential crashes introduced in 3bcf090d37
This amends cases where crashes can occur that were missed due to the
odd way the previous code was set up (using 3DS memory regions that
don't exist).
8 years ago
73e1be4350
kernel/process: Use std::array where applicable
8 years ago
73f162a5b0
kernel/process: Use accessors instead of class members for referencing segment array
Using member variables for referencing the segments array increases the
size of the class in memory for little benefit. The same behavior can be
achieved through the use of accessors that just return the relevant
segment.
8 years ago
0e92e67e06
memory: Remove unused GetSpecialHandlers() function
This is just unused code, so we may as well get rid of it.
8 years ago
02cdd82efc
video_core: Remove unimplemented Start() function prototype
Given this has no definition, we can just remove it entirely.
8 years ago
c155adb42a
gl_shader_decompiler: Remove unused variable in GenerateDeclarations()
This variable was being incremented, but we were never actually using
it.
8 years ago
300a4e3d79
gl_shader_manager: Make ProgramManager's GetCurrentProgramStage() a const member function
This function doesn't modify class state, so it can be made const.
8 years ago
3bcf090d37
core/memory: Get rid of 3DS leftovers
Removes leftover code from citra that isn't needed.
8 years ago
4a4641a134
Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests ( #851 )
8 years ago
f90c667a44
yuzu: Use Qt 5 signal/slots where applicable
Makes the signal/slot connections type-safe instead of string-based.
8 years ago
fc2d6869bf
input_common: Use std::move where applicable
Avoids unnecessary atomic reference count increments and decrements
8 years ago
d682d53bb2
input_common: Add missing override specifiers
8 years ago
6abb522f98
Implement RGB32F PixelFormat ( #886 ) (used by Go Vacation)
8 years ago
bf632d8e1e
kernel/vm_manager: Convert loop into std::any_of()
8 years ago
ec7319a5de
kernel/vm_manager: Use const where applicable
Makes our immutable state explicit.
8 years ago
26e2e7b657
kernel/vm_manager: Use the VAddr type alias in CarveVMA()
These two variables correspond to address ranges.
8 years ago
fa173d1874
kernel/thread: Make GetFreeThreadLocalSlot()'s loop indices size_t
Avoids using a u32 to compare against a range of size_t, which can be a
source of warnings. While we're at it, compress a std::tie into a
structured binding.
8 years ago
12afa56830
kernel/thread: Make GetFreeThreadLocalSlot() reference parameter a const reference
This function only reads the data being referenced, it doesn't modify
it, so we can turn the reference into a const reference.
8 years ago
16c5f5fe1b
kernel/thread: Make GetFreeThreadLocalSlot() internally linked
This function isn't used outside of this translation unit, so we can
make it internally linked.
8 years ago
5b317d1b80
vfs_vector: Remove unused variable in FindAndRemoveVectorElement()
This wasn't being used for anything, so it can be removed.
8 years ago
0bb1b9c168
vfs_vector: Avoid unnecessary copies where applicable
The lambda elements should be taken by const reference here, and we can
move the virtual directory passed to ReplaceFileWithSubdirectory()
8 years ago
68150d3d79
gl_state: Make texture_units a std::array
Gets rid of the use of a raw C array.
8 years ago
807d0cf4f2
gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader()
Avoids performing unnecessary copies of 65560 byte sized ShaderSetup
instances, considering it's only used as part of lookup and not
modified.
Given the parameters were already const, it's likely taking these
parameters by reference was intended but the ampersand was forgotten.
8 years ago
9f5ba9df95
math_util: Always initialize members of Rectangle
Prevents potentially using the members uninitialized.
8 years ago
db3603df94
hw: Remove unused files
None of these files are used in any meaningful way. They're just
leftovers from citra. Also has the benefit of getting rid of an unused
global variable.
8 years ago
6ac24e4e5a
service: Add migration services
Adds the basic skeleton for the mig:usr service based off information
provided by Switch Brew.
8 years ago
07a3c8a2a5
audio_out: Use Buffer::Tag alias in GetTagsAndReleaseBuffers()'s prototype
This makes the Buffer::Tag usage consistent with the Stream class's
prototype of GetTagsAndReleaseBuffers().
8 years ago
881380bc97
sink_details: Deduplicate long std::function repetition
We can just use type aliases to avoid needing to write the same long
type twice
8 years ago
5061e89fd1
sink_details: std::move std::function instances
Given std::function is allowed to potentially allocate, these should be
std::move'd to prevent potential reallocation (should that ever happen).
8 years ago
38c2af9330
kernel: Move object class to its own source files
General moving to keep kernel object types separate from the direct
kernel code. Also essentially a preliminary cleanup before eliminating
global kernel state in the kernel code.
8 years ago
f29d848665
logging/log: Remove incorrect description in PCV doc comment
PCV isn't the parental control service.
8 years ago
4d9067936c
service: Add psc services
Adds the basic skeleton for the psc services based off the information
provided by Switch Brew.
8 years ago
153a00ebc0
video_core: Make global EmuWindow instance part of the base renderer class
Makes the global a member of the RendererBase class. We also change this
to be a reference. Passing any form of null pointer to these functions
is incorrect entirely, especially given the code itself assumes that the
pointer would always be in a valid state.
This also makes it easier to follow the lifecycle of instances being
used, as we explicitly interact the renderer with the rasterizer, rather
than it just operating on a global pointer.
8 years ago
a155fe49dd
service/ns: Add missing ns services
Implements the basic skeleton of ns:am2, ns:ec, ns:rid, ns:rt, ns:su,
ns:vm, and ns:web based off the information provided by Switch Brew and
SwIPC.
8 years ago
732fe76a41
lm: Amend name of ILogger
Previously this was being registered with the name "Logger". While we're
at it, also change the name of the class to match it.
8 years ago
1d3dfe7e22
service/filesystem: Add fsp:ldr and fsp:pr services
Adds the basic skeleton for the remaining fsp services based off
information provided by Switch Brew.
8 years ago
a267a3cc08
service: Add capture services
Adds the basic skeleton for the capture services based off information
provided by Switch Brew.
8 years ago
2635578300
service: Add bpc and pcv services
Adds the basic skeleton for the remaining pcv-related services based off
information on Switch Brew.
8 years ago
6b77105b3d
Implement R32_FLOAT RenderTargetFormat
8 years ago
David Marcec