52fcd2e880
Merge pull request #732 from lioncash/unused
nso: Minor changes
8 years ago
133c99fb4a
Merge pull request #731 from lioncash/shadow
gl_shader_decompiler: Eliminate variable and declaration shadowing
8 years ago
34d18dac20
HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error.
And make IManagerForApplication::CheckAvailability always return false.
Returning a bogus id from GetAccountId causes games to crash on boot.
We should investigate this with a hwtest and either stub it properly or implement it.
8 years ago
d1c793d468
externals: Update glad to version 0.1.25
Keeps the OpenGL loader library up to date. Previously we were at
version 0.1.16
8 years ago
f53a9138bb
gl_state: Make references const where applicable in Apply()
8 years ago
80a916dc0a
gl_state: Get rid of mismatched sign conversions
While we're at it, amend the loop variable type to be the same width as
that returned by the .size() call.
8 years ago
c9b1340d3d
loader/{nca, nro}: std::move VirtualFile in the constructors where applicable
This avoids unnecessary atomic reference count increments and decrements
8 years ago
02e5e6fba3
vfs_offset: std::move file and name parameters of OffsetVfsFile
Avoids potentially unnecessary atomic reference count incrementing and
decrementing, as well as string copying.
8 years ago
66808c8489
Merge pull request #730 from lioncash/string
gl_shader_decompiler: Remove unnecessary const from return values
8 years ago
280dd6eb26
Merge pull request #729 from lioncash/simplify
pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority()
8 years ago
2ce4fde1ef
audren_u: Use a std::array instead of std::string for holding the audio interface/device name
std::string doesn't include the null-terminator in its data() + size()
range. This ensures that the null-terminator will also be written to the buffer
8 years ago
516bc05b15
audout_u: Use a std::array instead of std::string for holding the audio interface name
Uses a type that doesn't potentially dynamically allocate, and ensures
that the name of the interface is properly null-terminated when writing
it to the buffer.
8 years ago
10a91d9b9a
maxwell_3d: Remove unused variable within GetStageTextures()
8 years ago
059d0017f1
thread: Convert ThreadStatus into an enum class
Makes the thread status strongly typed, so implicit conversions can't
happen. It also makes it easier to catch mistakes at compile time.
8 years ago
3fbde66789
partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()
This should be returned here, otherwise pfs_dirs is effectively only
ever added to, but never read.
8 years ago
3bc310cb92
nso: Silence implicit sign conversion warnings
8 years ago
d0dd836d53
nso: Remove unused function ReadSegment()
8 years ago
41a8990ba7
gl_shader_decompiler: Eliminate variable and declaration shadowing
Ensures that no identifiers are being hidden, which also reduces
compiler warnings.
8 years ago
5b433431aa
gl_shader_decompiler: Remove unnecessary const from return values
This adds nothing from a behavioral point of view, and can inhibit the
move constructor/RVO
8 years ago
433c9c7bac
pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority()
With the new overload, we can simply pass the container directly.
8 years ago
b55fa06eef
Merge pull request #726 from lioncash/overload
hle_ipc: Introduce generic WriteBuffer overload for multiple container types
8 years ago
a5427ba87a
Merge pull request #725 from lioncash/bytes
pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority()
8 years ago
9cdfa3a942
Merge pull request #728 from Subv/acc_profile
HLE/ACC: Change the default user id and small improvements to the way we handle profiles
8 years ago
ae40418f2e
Merge pull request #727 from Subv/acc_users
HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers.
8 years ago
98ebfedfa9
Merge pull request #724 from lioncash/printf
pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority()
8 years ago
0e5f6180db
Merge pull request #723 from lioncash/gdb
gdbstub: Get rid of a few signed/unsigned comparisons
8 years ago
9d65a4481e
Merge pull request #722 from lioncash/signed
hid: Resolve a signed/unsigned comparison warning
8 years ago
e9c9207523
Merge pull request #721 from lioncash/svc
svc: Correct always true assertion case in SetThreadCoreMask
8 years ago
fdf72b6b60
Merge pull request #719 from lioncash/docs
loader: Amend Doxygen comments
8 years ago
b4e1375e78
Merge pull request #718 from lioncash/read
loader/nso: Check if read succeeded in IdentifyFile() before checking magic value
8 years ago
dbb4596293
Merge pull request #717 from lioncash/explicit
hle/service: Make constructors explicit where applicable
8 years ago
5bad464f7b
HLE/ACC: Return an IProfile that is consistent with what was requested.
The default username for now is "yuzu".
We should eventually allow the creation of users in the emulator and have the ability to modify their parameters.
8 years ago
791d6b8b3a
HLE/ACC: Change the default user id to be consistent with what we tell games on startup.
In IApplicationFunctions::PopLaunchParameter we tell the games that they were launched as user id 1.
8 years ago
3c8e295c50
HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers.
We only emulate a single user id for now.
8 years ago
b4a4383fb5
Merge pull request #716 from lioncash/construct
nvflinger: Emplace Display instances directly
8 years ago
2b158ebd25
hle_ipc: Introduce generic WriteBuffer overload for multiple container types
This introduces a slightly more generic variant of WriteBuffer().
Notably, this variant doesn't constrain the arguments to only accepting
std::vector instances. It accepts whatever adheres to the
ContiguousContainer concept in the C++ standard library.
This essentially means, std::array, std::string, and std::vector can be
used directly with this interface. The interface no longer forces you to
solely use containers that dynamically allocate.
To ensure our overloads play nice with one another, we only enable the
container-based WriteBuffer if the argument is not a pointer, otherwise
we fall back to the pointer-based one.
8 years ago
a5d3565cd8
Merge pull request #715 from lioncash/const-ref
nvdrv: Take std::string by const reference in GetDevice()
8 years ago
ee244af2f4
Merge pull request #720 from Subv/getentrytype_root
Filesystem: Return EntryType::Directory for the root directory.
8 years ago
0dcaa4485b
pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority()
This WriteBuffer overload expects its size argument to be in bytes, not
elements.
8 years ago
9ee475f731
svc: Correct always true assertion case in SetThreadCoreMask
The reason this would never be true is that ideal_processor is a u8 and
THREADPROCESSORID_DEFAULT is an s32. In this case, it boils down to how
arithmetic conversions are performed before performing the comparison.
If an unsigned value has a lesser conversion rank (aka smaller size)
than the signed type being compared, then the unsigned value is promoted
to the signed value (i.e. u8 -> s32 happens before the comparison). No
sign-extension occurs here either.
An alternative phrasing:
Say we have a variable named core and it's given a value of -2.
u8 core = -2;
This becomes 254 due to the lack of sign. During integral promotion to
the signed type, this still remains as 254, and therefore the condition
will always be true, because no matter what value the u8 is given it
will never be -2 in terms of 32 bits.
Now, if one type was a s32 and one was a u32, this would be entirely
different, since they have the same bit width (and the signed type would
be converted to unsigned instead of the other way around) but would
still have its representation preserved in terms of bits, allowing the
comparison to be false in some cases, as opposed to being true all the
time.
---
We also get rid of two signed/unsigned comparison warnings while we're
at it.
8 years ago
2783d58ab3
pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority()
This can just use the fmt specifiers and be type-agnostic.
8 years ago
9017666b6f
Merge pull request #714 from lioncash/index
hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads
8 years ago
1f2644b474
Merge pull request #712 from lioncash/fsp
fsp_srv: Misc individual changes
8 years ago
19be3828b6
gdbstub: Get rid of a few signed/unsigned comparisons
Ensures both operands in comparisons are the same signedness.
8 years ago
60eab9b720
hid: Use a ranged-for loops in UpdatePadCallback
Modernizes the loops themselves while also getting rid of a signed/unsigned
comparison in a loop condition.
8 years ago
68b6099706
hid: Use HID_NUM_LAYOUTS constant for indicating size of the layouts array
Gets rid of the use of a magic constant
8 years ago
153756ced5
Merge pull request #713 from lioncash/filesys
filesystem: Minor changes
8 years ago
9f6fe39602
Merge pull request #711 from lioncash/swap
common/swap: Minor changes
8 years ago
a8139e0c59
Merge pull request #710 from lioncash/unused
common/common_funcs: Remove unused rotation functions
8 years ago
fb8a2dd552
Merge pull request #694 from lioncash/warn
loader/{nro, nso}: Resolve compilation warnings
8 years ago
bunnei