33fbcb45a7
string_util: Remove AsciiToHex()
Easy TODO
8 years ago
88ba94e8a2
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
This function doesn't alter class state.
8 years ago
9abc5763b6
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
8 years ago
cf30c4be22
gl_state: Temporarily disable culling and depth test.
8 years ago
4790bb907d
content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
8 years ago
87a9bb392b
content_archive: Add missing standard includes
8 years ago
0b566f43a1
content_archive: std::move VirtualFile in NCA's constructor
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
8 years ago
5e626c774f
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
We can just use a generic lambda to avoid writing the same thing twice.
8 years ago
b496a9eefe
decoders: Fix calc of swizzle image_width_in_gobs.
8 years ago
29aff8d5ab
Virtual Filesystem 2: Electric Boogaloo ( #676 )
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
8 years ago
72207577b2
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
8 years ago
2cd3141c30
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
This was introduced within 4f81bc4e1b
8 years ago
296e68fd43
service/prepo: Add missing header guard
8 years ago
93cba6f699
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
Without these, this would perform concatenation, which is definitely not
what we want here.
8 years ago
46458e7284
core/memory, core/hle/kernel: Use std::move where applicable
Avoids pointless copies
8 years ago
10d2ab8098
core: Make System's default constructor private
This makes it a compilation error to construct additional instances of
the System class directly, preventing accidental wasteful constructions
over and over.
8 years ago
3a4841e403
core: Don't construct instance of Core::System, just to access its live instance
This would result in a lot of allocations and related object
construction, just to toss it all away immediately after the call.
These are definitely not intentional, and it was intended that all of
these should have been accessing the static function GetInstance()
through the name itself, not constructed instances.
8 years ago
f5d7706ca1
externals: update fmt to version 5.1.0
Previously, we were on 4.1.0, which was a major version behind.
8 years ago
079be8032d
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
Previously this wouldn't compile, since no such function named
SaveStructDebugInfo() exists.
8 years ago
d17e172d92
game_list: Make ContainsAllWords an internally linked non-member function
This function actually depends on no internal class state, so it doesn't
even need to be a part of the class interface.
8 years ago
c337272ca9
Fill in more fields in TouchScreenEntryTouch
8 years ago
f2f368014e
Single touch support
8 years ago
c65a8fafa0
telemetry: Remove unnecessary Field constructor
We can just take the value parameter by value which allows both moving
into it, and copies at the same time, depending on the calling code.
8 years ago
0aebe6b3d5
telemetry: Make operator== and operator!= const member functions of Field
These operators don't modify internal class state, so they can be made
const member functions. While we're at it, drop the unnecessary inline
keywords. Member functions that are defined in the class declaration are
already inline by default.
8 years ago
3575d367a4
telemetry: Default copy/move constructors and assignment operators
This provides the equivalent behavior, but without as much boilerplate.
While we're at it, explicitly default the move constructor, since we
have a move-assignment operator defined.
8 years ago
f4b98a857b
game_list: Upper-case containsAllWords to ContainsAllWords()
This makes it consistent with most of the other private utility
functions.
8 years ago
c8f3fc9a4b
game_list: Make containsAllWords a const member function
This doesn't actually modify the internal class state, so it can be a
const member function. While we're at it, amend the function to take
its arguments by const reference.
8 years ago
f4c69149f9
game_list: Remove unnecessary QString initialization in KeyReleaseEater
QString initializes to an empty string by default, so this does nothing
meaningful. While we're at it, use a constructor initializer list for
initializing the gamelist member variable.
8 years ago
6a03badcbc
astc: Initialize vector size directly in Decompress
There's no need to perform a separate resize.
8 years ago
0f148548f3
astc: Mark functions as internally linked where applicable
8 years ago
c5803e30d3
astc: const-correctness changes where applicable
A few member functions didn't actually modify class state, so these can
be amended as necessary.
8 years ago
e3fadb9616
astc: Delete Bits' copy contstructor and assignment operator
This also potentially avoids warnings, considering the copy assignment
operator is supposed to have a return value.
8 years ago
4cd52a34b9
astc: In-class initialize member variables where appropriate
8 years ago
03c2d049d4
settings: Turn docked mode off by default.
8 years ago
49e5de9f03
vi: Change TransactionId::CancelBuffer to LOG_CRITICAL.
8 years ago
0d1a99edf6
vi: Fix size for ListDisplays default display.
8 years ago
c3dd456d51
vi: Partially implement buffer crop parameters.
8 years ago
3d3b10adc7
GPU: Added register definitions for the stencil parameters.
8 years ago
69bfe075b5
General Filesystem and Save Data Fixes ( #670 )
8 years ago
170e19d4ea
nvflinger: Fix for BufferQueue event handling.
8 years ago
3b885691a1
Kernel/Arbiter: Fix bug in WaitIfLessThan
8 years ago
56cc1c11ec
scheduler: Clear exclusive state when switching contexts
8 years ago
7d209b3c9f
HID: Update controllers less often
8 years ago
497b81558e
Logging: Dump all logs in the queue on close in debug mode
8 years ago
3a96670f2d
gl_rasterizer_cache: Implement texture format G8R8.
8 years ago
3145114190
gl_rasterizer_cache: Fix incorrect offset in ConvertS8Z24ToZ24S8.
8 years ago
e21190f47f
gl_rasterizer_cache: Implement depth format Z16_UNORM.
8 years ago
6daebaaa57
Logging: Don't lock the queue for the duration of the write
8 years ago
b07f4d6afb
Services/BSD: Corrected the return for StartMonitoring according to SwIPC.
8 years ago
7e5e4f8d7a
FileSys: Append the requested path to the filesystem base path in DeleteFile.
We were trying to delete things in the current directory instead of the actual filesystem directory. This may fix some savedata issues in some games.
8 years ago
Lioncash