726de453bb
common/input: Avoid numerous large copies of CallbackStatus
CallbackStatus instances aren't the cheapest things to copy around
(relative to everything else), given that they're currently 520 bytes in
size and are currently copied numerous times when callbacks are invoked.
Instead, we can pass the status by const reference to avoid all the
copying.
4 years ago
2e4b0fa68c
common/cpu_detect: Remove CPU family and model
We currently do not make use of these fields, remove them for now.
4 years ago
319b0ed324
common/input: Remove unnecessary returns
Given these return void, these can be omitted.
4 years ago
3dbb700714
input_poller: Add missing override specifiers
4 years ago
46c7e48143
input_mapping: Amend specification of parameters
param tags are supposed to specify the parameter name without any
quoting.
Silences several -Wdocumentation warnings.
4 years ago
c73ebb7d89
input_poller: Remove several unnecessary @param tags
Silences quite a bit of -Wdocumentation warnings, given the @param tag
is only intended to be used to identify function parameters, not what it
contains.
4 years ago
21ef5f290d
qt_software_keyboard: Fix out of bounds array access
We were unconditionally accessing the keyboard_buttons array, even if the bottom_osk_index was for the numberpad, leading to an out of bounds array access. Fix this by accessing the proper array for the current button when the index is for the numberpad.
4 years ago
f63a50ce9d
tas_input: Avoid minor copies in Read/WriteCommandButtons()
We don't need to copy the whole pair
4 years ago
bac72cecf9
tas_input: Remove unnecessary semicolon
Resolves a -Wextra-semi warning
4 years ago
6a9fe940d2
tas_input: Execute clear() even if empty
clear() when empty is simply a no-op, so we can get rid of the check
here and let the stdlib do it for us.
4 years ago
8b6137eb79
tas_input: Remove unnecessary includes
Gets rid of indirect includes and includes only what the interface
needs.
4 years ago
4284fe0d78
tas_input: std::move strings into vector
While we're in the same area, we can also avoid performing std::stoi in
a loop when it only needs to be performed once.
4 years ago
c12653670c
tas_input: Use istringstream over stringstream
This is only using the input facilities, so we don't need to use the
fully-fleged stringstream.
4 years ago
4dce3a6cf4
tas_input: Use u8string_view instead of u8string
Same behavior, but without the potential for extra allocations.
4 years ago
b2c94d8cd4
tas_input: Remove unused std::smatch variable
This also means we can get rid of the dependency on <regex>
4 years ago
f1ff42541a
tas_input: Amend -Wdocumentation warnings
Parameters shouldn't have the colon by their name.
4 years ago
a82bb17b08
tas_input: Make TasAxes enum an enum class
Prevents these values from potentially clashing with anything in other
headers.
4 years ago
71467b1383
input_engine: Fix typo in TriggerOnAxisChange() parameter name
4 years ago
e609218c0f
input_engine: Simplify PreSet* family of functions
We can make use of try_emplace() to insert values only if they don't
already exist.
4 years ago
14f7f35957
input_engine: Avoid redundant map lookups
We can use iterators to avoid looking up into maps twice in the getter
functions.
At the same time we can also avoid copying the ControllerData structs,
since they're 264 bytes in size.
4 years ago
e7c5737e2e
input_engine: Remove left-over namespace qualifiers
These types are part of the InputCommon namespace.
4 years ago
f8db0a76af
input_engine: Iterate by reference rather than by value where applicable
Avoids creating copies of several object instances (some of which being
over 100 bytes in size).
4 years ago
190cfc5997
input_engine: Take BasicMotion by const reference with SetMotion() and TriggerOnMotionChange()
Copies the BasicMotion instance once instead of twice.
4 years ago
e0e9f98fc6
input_engine: std::move InputIdentifier in SetCallback()
Allows avoiding std::function allocations.
4 years ago
cd45635f56
input_engine: Pass LedStatus by const reference
Avoids copies where reasonably applicable
4 years ago
f41c22d30f
input_engine: Pass VibrationStatus by const reference in SetRumble()
Avoids creating copies of the struct where not necessary.
4 years ago
54e164d9de
input_engine: std::move engine name where applicable
We can allow the name to be moved into, allowing allocations to be
avoided.
4 years ago
d62545828a
input_engine: Remove callback clearing in constructor
The callback map is a member variable, so this will always be empty on
initial construction.
4 years ago
7e34562d34
input_engine: Remove unnecessary semi-colons
Silences -Wextra-semi warnings
4 years ago
caae5d3868
input_engine: Remove unnecessary return
This is a void function, so it doesn't need this.
4 years ago
295b676fe6
Remove erroneous #pragma once
4 years ago
66a86f54af
service/hid: Improve console motion accuracy
4 years ago
8f764d62a5
game_list: Add persistent setting for the favorites row expanded state
Previously, the favorites row was always expanded on launch. This change introduces a persistent setting that allows the favorites row's expanded state to be remembered between launches.
4 years ago
036cb348bf
maxwell_to_vk: Add ASTC_2D_5X4_UNORM
4 years ago
755963ada1
Fix blit image/view not compatible
4 years ago
0f7d2bbd55
maxwell_to_vk: Add ASTC_2D_8X5_UNORM
- Used by Lego City Undercover
4 years ago
006965d3c0
profiler: Use QWheelEvent position().toPoint()
QWheelEvent::pos() is deprecated. Make use of position().toPoint() instead.
4 years ago
052c01db9a
renderer_vulkan: Add R16G16_UINT
- Used by Immortals Fenyx Rising
4 years ago
9a28199c5a
Update k_code_memory.h
4 years ago
4b0b2d7d1d
make KCodeMemory::GetSourceAddress const
Co-authored-by: Mai M. <mathew1800@gmail.com>
4 years ago
aca763fd98
main: Update video core popup
Old version had formatting issues, and I want to provide an answer to the most common reason this pops up in the first place, outdated drivers.
4 years ago
5788e077cd
hle: kernel k_scheduler: EnableScheduling: Remove redundant GetCurrentThreadPointer calls.
4 years ago
1b1ed86ec7
hle: kernel k_process: Remove unnecessary .at usage with thread pinning methods.
4 years ago
38a6477770
hle: kernel: Remove unnecessary virtual specifier on NotifyAvailable.
4 years ago
829c4b6144
hle: kernel: Remove unnecessary virtual specifier on EndWait.
4 years ago
1457a75a40
hle: kernel: k_light_condition_variable: Revert unnecessary license comment changes.
4 years ago
cd4582dc8b
hle: kernel: k_condition_variable: Revert unnecessary style changes.
4 years ago
4b2aa52da9
hle: kernel: Remove unnecessary virtual specifier on CancelWait.
4 years ago
273223d5f1
hle: kernel: service_thread: Force stop threads on destruction.
4 years ago
0231cbd79f
hle: kernel: k_light_lock: Implement CancelWait.
- Fixes a crash in Megadimension Neptunia VII.
4 years ago
Lioncash