eden-emu/eden - eden - InfoTonic

Commit Graph

Author	SHA1	Message	Date
FreddyFunk	27f51145b5	Fix Clang Format	7 years ago
Lioncash	46a7c8826b	common/swap: Improve codegen of the default swap fallbacks Uses arithmetic that can be identified more trivially by compilers for optimizations. e.g. Rather than shifting the halves of the value and then swapping and combining them, we can swap them in place. e.g. for the original swap32 code on x86-64, clang 8.0 would generate: mov ecx, edi rol cx, 8 shl ecx, 16 shr edi, 16 rol di, 8 movzx eax, di or eax, ecx ret while GCC 8.3 would generate the ideal: mov eax, edi bswap eax ret now both generate the same optimal output. MSVC used to generate the following with the old code: mov eax, ecx rol cx, 8 shr eax, 16 rol ax, 8 movzx ecx, cx movzx eax, ax shl ecx, 16 or eax, ecx ret 0 Now MSVC also generates a similar, but equally optimal result as clang/GCC: bswap ecx mov eax, ecx ret 0 ==== In the swap64 case, for the original code, clang 8.0 would generate: mov eax, edi bswap eax shl rax, 32 shr rdi, 32 bswap edi or rax, rdi ret (almost there, but still missing the mark) while, again, GCC 8.3 would generate the more ideal: mov rax, rdi bswap rax ret now clang also generates the optimal sequence for this fallback as well. This is a case where MSVC unfortunately falls short, despite the new code, this one still generates a doozy of an output. mov r8, rcx mov r9, rcx mov rax, 71776119061217280 mov rdx, r8 and r9, rax and edx, 65280 mov rax, rcx shr rax, 16 or r9, rax mov rax, rcx shr r9, 16 mov rcx, 280375465082880 and rax, rcx mov rcx, 1095216660480 or r9, rax mov rax, r8 and rax, rcx shr r9, 16 or r9, rax mov rcx, r8 mov rax, r8 shr r9, 8 shl rax, 16 and ecx, 16711680 or rdx, rax mov eax, -16777216 and rax, r8 shl rdx, 16 or rdx, rcx shl rdx, 16 or rax, rdx shl rax, 8 or rax, r9 ret 0 which is pretty unfortunate.	7 years ago
Lioncash	0d2300473a	common/swap: Mark byte swapping free functions with [[nodiscard]] and noexcept Allows the compiler to inform when the result of a swap function is being ignored (which is 100% a bug in all usage scenarios). We also mark them noexcept to allow other functions using them to be able to be marked as noexcept and play nicely with things that potentially inspect "nothrowability".	7 years ago
Lioncash	d9fa38ef42	common/swap: Simplify swap function ifdefs Including every OS' own built-in byte swapping functions is kind of undesirable, since it adds yet another build path to ensure compilation succeeds on. Given we only support clang, GCC, and MSVC for the time being, we can utilize their built-in functions directly instead of going through the OS's API functions. This shrinks the overall code down to just if (msvc) use msvc's functions else if (clang or gcc) use clang/gcc's builtins else use the slow path	7 years ago
Lioncash	424250354c	common/swap: Remove 32-bit ARM path We don't plan to support host 32-bit ARM execution environments, so this is essentially dead code.	7 years ago
Lioncash	32e7264142	common/scope_exit: Replace std::move with std::forward in ScopeExit() The template type here is actually a forwarding reference, not an rvalue reference in this case, so it's more appropriate to use std::forward to preserve the value category of the type being moved.	7 years ago
Lioncash	255a6c6f4b	kernel: Make handle type declarations constexpr Some objects declare their handle type as const, while others declare it as constexpr. This makes the const ones constexpr for consistency, and prevent unexpected compilation errors if these happen to be attempted to be used within a constexpr context.	7 years ago
FreddyFunk	9ddb70acb2	ui_settings: Rename game directory variables	7 years ago
Fernando Sahmkow	5a01502521	gl_rasterizer_cache: Relax restrictions on FastCopySurface and FastLayeredCopySurface	7 years ago
ReinUsesLisp	d334042c75	vk_shader_decompiler: Implement flow primitives	7 years ago
ReinUsesLisp	e3c886a149	vk_shader_decompiler: Implement most common texture primitives	7 years ago
ReinUsesLisp	7b813afc88	vk_shader_decompiler: Implement texture decompilation helper functions	7 years ago
ReinUsesLisp	357a5fcded	vk_shader_decompiler: Implement Assign and LogicalAssign	7 years ago
ReinUsesLisp	b6b1cc9ffa	vk_shader_decompiler: Implement non-OperationCode visits	7 years ago
ReinUsesLisp	4d83f1ea9e	vk_shader_decompiler: Implement OperationCode decompilation interface	7 years ago
ReinUsesLisp	86647aee2e	vk_shader_decompiler: Implement Visit	7 years ago
ReinUsesLisp	4d331aeab6	vk_shader_decompiler: Implement labels tree and flow	7 years ago
ReinUsesLisp	946b97b6f4	vk_shader_decompiler: Implement declarations	7 years ago
ReinUsesLisp	0589785e80	vk_shader_decompiler: Declare and stub interface for a SPIR-V decompiler	7 years ago
ReinUsesLisp	6272cafac7	video_core: Add sirit as optional dependency with Vulkan sirit is a runtime assembler for SPIR-V	7 years ago
Lioncash	c7d85ae11e	kernel/server_session: Remove obsolete TODOs These are holdovers from Citra.	7 years ago
Fernando Sahmkow	3d337af7b8	Remove bounding in LD_C	7 years ago
Fernando Sahmkow	50484ee68a	Correct Fermi Copy on Linear Textures.	7 years ago
Lioncash	9e3d4595b7	kernel/process: Set page table when page table resizes occur. We need to ensure dynarmic gets a valid pointer if the page table is resized (the relevant pointers would be invalidated in this scenario). In this scenario, the page table can be resized depending on what kind of address space is specified within the NPDM metadata (if it's present).	7 years ago
Lioncash	af836c2968	yuzu/loading_screen: Resolve runtime Qt string formatting warnings In our error console, when loading a game, the strings: QString::arg: Argument missing: "Loading...", 0 QString::arg: Argument missing: "Launching...", 0 would occasionally pop up when the loading screen was running. This was due to the strings being assumed to have formatting indicators in them, however only two out of the four strings actually have them. This only applies the arguments to the strings that have formatting specifiers provided, which avoids these warnings from occurring.	7 years ago
Fernando Sahmkow	7f9e792814	gl_backend: Align Pixel Storage This commit makes sure GL reads on the correct pack size for the respective texture buffer.	7 years ago
Fernando Sahmkow	25e6fb72eb	Correct LOP_IMN encoding	7 years ago
Fernando Sahmkow	34b15b69df	Correct XMAD mode, psl and high_b on different encodings.	7 years ago
Lioncash	43e9b334af	kernel/svc: Deglobalize the supervisor call handlers Adjusts the interface of the wrappers to take a system reference, which allows accessing a system instance without using the global accessors. This also allows getting rid of all global accessors within the supervisor call handling code. While this does make the wrappers themselves slightly more noisy, this will be further cleaned up in a follow-up. This eliminates the global system accessors in the current code while preserving the existing interface.	7 years ago
Fernando Sahmkow	a576cd4a8c	Permit a Null Shader in case of a bad host_ptr.	7 years ago
Lioncash	024bdfdc08	core/memory: Remove unused enum constants These are holdovers from Citra and can be removed.	7 years ago
Lioncash	08424ab57f	core/memory: Remove GetCurrentPageTable() Now that nothing actually touches the internal page table aside from the memory subsystem itself, we can remove the accessor to it.	7 years ago
Lioncash	c1a788780d	arm/arm_dynarmic: Remove unnecessary current_page_table member Given the page table will always be guaranteed to be that of whatever the current process is, we no longer need to keep this around.	7 years ago
Lioncash	6a929c3a2c	kernel: Handle page table switching within MakeCurrentProcess() Centralizes the page table switching to one spot, rather than making calling code deal with it everywhere.	7 years ago
Lioncash	bfbadb38be	kernel/server_session: Return a std::pair from CreateSessionPair() Keeps the return type consistent with the function name. While we're at it, we can also reduce the amount of boilerplate involved with handling these by using structured bindings.	7 years ago
Lioncash	05243b3041	kernel/server_port: Return a std::pair from CreatePortPair() Returns the same type that the function name describes.	7 years ago
ReinUsesLisp	8092d3fad0	maxwell_3d: Reduce severity of ProcessSyncPoint	7 years ago
Lioncash	053aae66c1	video_core/textures/convert: Replace include with a forward declaration Avoids dragging in a direct dependency in a header.	7 years ago
Lioncash	44d91d561a	video_core/texures/texture: Remove unnecessary includes Nothing in this header relies on common_funcs or the memory manager. This gets rid of reliance on indirect inclusions in the OpenGL caches.	7 years ago
Lioncash	366895989c	yuzu/debugger: Remove graphics surface viewer This doesn't actually work anymore, and given how long it's been left in that state, it's unlikely anyone actually seriously used it. Generally it's preferable to use RenderDoc or Nsight to view surfaces.	7 years ago
bunnei	2a4a454793	memory_manager: Improved implementation of read/write/copy block. - Fixes graphical issues with Chocobo's Mystery Dungeon EVERY BUDDY! - Fixes a crash with Mario Tennis Aces	7 years ago
Lioncash	a812485b94	video_core/macro_interpreter: Remove assertion within FetchParameter() We can just use .at(), which essentially does the same thing, but with less code.	7 years ago
Lioncash	d2143cb59c	video_core/macro_interpreter: Simplify GetRegister() Given we already ensure nothing can set the zeroth register in SetRegister(), we don't need to check if the index is zero and special case it. We can just access the register normally, since it's already going to be zero. We can also replace the assertion with .at() to perform the equivalent behavior inline as part of the API.	7 years ago
Lioncash	69846b1557	video_core/memory_manager: Make Read() a const qualified member function Given this doesn't actually alter internal state, this can be made a const member function.	7 years ago
Lioncash	e36500c07f	video_core/memory_manager: Make ReadBlock() a const qualifier member function Now, since we have a const qualified variant of GetPointer(), we can put it to use in ReadBlock() to retrieve the source pointer that is passed into memcpy. Now block reading may be done from a const context.	7 years ago
Lioncash	514351af96	video_core/memory_manager: Add a const qualified variant of GetPointer() Allows retrieving read-only pointers from a const context externally.	7 years ago
Lioncash	72e8ac8e4e	video_core/memory_manager: Make FindFreeRegion() a const member function This doesn't modify internal state, so it can be made a const member function.	7 years ago
Lioncash	ad244b004b	video_core/memory_manager: Make GpuToCpuAddress() a const member function This doesn't modify any internal state, so it can be made a const member function to allow its use in const contexts.	7 years ago
Lioncash	c289629f97	yuzu/debugger/graphics_surface: Display error messages for file I/O errors	7 years ago
Lioncash	64e191b2b8	yuzu/debugger/graphics_surface: Tidy up SaveSurface - Use QStringLiteral where applicable. - Use const where applicable - Remove unnecessary precondition check (we already assert the pixbuf being non null)	7 years ago

1 2 3 4 5 ...

9804 Commits (8cbba96a1607ca40a66108f3cc7a3b79f88e81c6)