6fff93da5f
fsp_srv: Remove unnecessary vector construction in IFile's Write() function
We can avoid constructing a std::vector here by simply passing a pointer
to the original data and the size of the copy we wish to perform to the
backend's Write() function instead, avoiding copying the data where it's
otherwise not needed.
8 years ago
45e747beaa
fsp_srv: Remove unnecessary std::vector construction in IDirectory's Read() function
We were using a second std::vector as a buffer to convert another
std::vector's data into a byte sequence, however we can just use
pointers to the original data and use them directly with WriteBuffer,
which avoids copying the data at all into a separate std::vector.
We simply cast the pointers to u8* (which is allowed by the standard,
given std::uint8_t is an alias for unsigned char on platforms that we
support).
8 years ago
f15104730f
Merge pull request #699 from lioncash/vfs
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
8 years ago
ca8697b7d9
Merge pull request #697 from bunnei/disable-depth-cull
gl_state: Temporarily disable culling and depth test.
8 years ago
043ab179b5
filesystem: std::move VirtualDir instance in VfsDirectoryServiceWrapper's constructor
Avoids unnecessary atomic reference count incrementing and decrementing
8 years ago
7ab5eb948c
filesystem: Use std::string's empty() function instead of comparing against a literal
This is simply a basic value check as opposed to potentially doing
string based operations (unlikely, but still, avoiding it is free).
8 years ago
9dccecb6b0
filesystem: Remove pragma disabling global optimizations
This was just an artifact missed during PR review.
8 years ago
b9758eeb2f
fsp_srv: Make IStorage constructor explicit
Prevents implicit conversions.
8 years ago
c835e6f941
fsp_srv: Add missing includes
Gets rid of relying on indirect inclusions.
8 years ago
b4efdeb80b
fsp_srv: Resolve sign-mismatch warnings in assertion comparisons
8 years ago
106207e2ca
fsp_srv: Respect write length in Write()
Previously we were just copying the data whole-sale, even if the length
was less than the total data size. This effectively makes the
actual_data vector useless, which is likely not intended.
Instead, amend this to only copy the given length amount of data.
At the same time, we can avoid zeroing out the data before using it by
passing iterators to the constructor instead of a size.
8 years ago
5edccd695c
common/swap: Remove unnecessary const on return value of swap()
8 years ago
f66d29acf2
common/swap: Use static_cast where applicable
8 years ago
d7ebfa40a1
common/swap: Use using aliases where applicable
8 years ago
3ec8aa2bb9
common/common_funcs: Remove unused rotation functions
These are unused and essentially don't provide much benefit either. If
we ever need rotation functions, these can be introduced in a way that
they don't sit in a common_* header and require a bunch of ifdefing to
simply be available
8 years ago
03d8c78199
common/misc: Deduplicate code in GetLastErrorMsg()
Android and macOS have supported thread_local for quite a while, but
most importantly is that we don't even really need it. Instead of using
a thread-local buffer, we can just return a non-static buffer as a
std::string, avoiding the need for that quality entirely.
8 years ago
1dbed8591f
externals: Update Xbyak to 5.65
Keeps the JIT assembler library up to date and ensures we don't run into
any issues that may have been resolved.
8 years ago
c95cc86b63
externals: Update catch to v2.2.3
Keeps the unit-testing library up to date.
8 years ago
ba015f825f
file_util: return string by const reference for GetExeDirectory()
This disallows modifying the internal string buffer (which shouldn't be
modified anyhow).
8 years ago
49881ebe2c
Merge pull request #700 from bunnei/update-dynarmic
externals: Update dynarmic to 5a91c94.
8 years ago
7ad7ee1411
string_util: Remove AsciiToHex()
Easy TODO
8 years ago
25c34badfa
Merge pull request #692 from lioncash/assign
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
8 years ago
90042f35a5
Merge pull request #690 from lioncash/move
core/memory, core/hle/kernel: Use std::move where applicable
8 years ago
f92bb43138
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
This function doesn't alter class state.
8 years ago
a9b596c444
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
8 years ago
9a4fa973c8
gl_state: Temporarily disable culling and depth test.
8 years ago
9eb43dc910
content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
8 years ago
701bdfd753
content_archive: Add missing standard includes
8 years ago
37d9478e38
externals: Update dynarmic to 5a91c94.
8 years ago
bff53f234d
content_archive: std::move VirtualFile in NCA's constructor
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
8 years ago
47858aed98
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
We can just use a generic lambda to avoid writing the same thing twice.
8 years ago
f6f77b403e
Merge pull request #691 from lioncash/guard
service/prepo: Add missing header guard
8 years ago
35b7d6ec37
Merge pull request #686 from lioncash/fmt
externals: update fmt to version 5.1.0
8 years ago
d0f53d27e0
loader/nro: Resolve sign mismatch warnings
8 years ago
b20bac710d
loader/nso: Remove unnecessary vector resizes
We can just initialize these vectors directly via their constructor.
8 years ago
0a48b45954
loader/nso: Resolve sign mismatch warnings
8 years ago
6f120be510
Merge pull request #688 from lioncash/comma
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
8 years ago
8387313266
Merge pull request #693 from lioncash/unused
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
8 years ago
5ab4dc3e1e
Merge pull request #687 from lioncash/instance
core: Don't construct instance of Core::System, just to access its live instance
8 years ago
c2109ba58e
Merge pull request #680 from bunnei/fix-swizz
decoders: Fix calc of swizzle image_width_in_gobs.
8 years ago
fc156e2d70
Merge pull request #685 from lioncash/build
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
8 years ago
55ef6c6686
Merge pull request #684 from lioncash/nonmember
game_list: Make ContainsAllWords an internally linked non-member function
8 years ago
47a305ed54
decoders: Fix calc of swizzle image_width_in_gobs.
8 years ago
82150bd5c1
Virtual Filesystem 2: Electric Boogaloo ( #676 )
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
8 years ago
b7e7ddbdfc
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
8 years ago
76a9fc2f85
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
This was introduced within d12af72c8f
8 years ago
26e188d074
service/prepo: Add missing header guard
8 years ago
81bf614695
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
Without these, this would perform concatenation, which is definitely not
what we want here.
8 years ago
b1b1c60009
core/memory, core/hle/kernel: Use std::move where applicable
Avoids pointless copies
8 years ago
74185c108e
core: Make System's default constructor private
This makes it a compilation error to construct additional instances of
the System class directly, preventing accidental wasteful constructions
over and over.
8 years ago
Lioncash