Lioncash
77ce85f51d
yuzu/bootmanager: Log out screenshot destination path
We can make this message more meaningful by indicating the location the
screenshot has been saved to. We can also log out whenever a screenshot
could not be saved (e.g. due to filesystem permissions or some other
reason).
7 years ago
Lioncash
e32bf646cf
yuzu/bootmanager: Treat the resolution factor as a u32
Treating it as a u16 can result in a sign-conversion warning when
performing arithmetic with it, as u16 promotes to an int when aritmetic
is performed on it, not unsigned int.
This also makes the interface more uniform, as the layout interface now
operates on u32 across the board.
7 years ago
Lioncash
536c9cf006
yuzu/bootmanager: Default EmuThread's destructor in the cpp file
This class contains non-trivial members, so we should default the
destructor's definition within the cpp file.
7 years ago
Lioncash
0a650ec99e
yuzu/bootmanager: unsigned -> u32
Same thing (for platforms we support), less reading.
7 years ago
Lioncash
2575403acf
yuzu/bootmanager: Change false literal to 0 for setSwapInterval()
This function is defined as taking an int, not a bool.
7 years ago
Lioncash
cfb59aad3f
yuzu/bootmanager: Remove pointer downcast in GRenderWindow's constructor
We can just pass a pointer to GMainWindow directly and make it a
requirement of the interface. This makes the interface a little safer,
since this would technically otherwise allow any random QWidget to be
the parent of a render window, downcasting it to GMainWindow (which is
undefined behavior).
7 years ago
Lioncash
49e3a6e924
yuzu/bootmanager: Remove unnecessary pointer casts
We can just invoke these functions by qualifying the object name before
the function.
7 years ago
Lioncash
d0d97de1e4
game_list_worker: Use QFile over our own IOFile instance or std streams
Stays consistent in our code with using Qt's provided mechanisms, and
also properly handles Unicode paths (which file streams on Windows don't
do very well).
7 years ago
Lioncash
de2533d389
game_list_worker: Remove template specializations
This is equivalent to specifying two separate functions, so we can just
do that.
7 years ago
Zach Hilman
9b2d38582f
main: Remove extraneous comment
7 years ago
fearlessTobi
d9c1b94f03
yuzu: Remove unused birthday setting
Fixes #2522 .
7 years ago
Zach Hilman
46e2ca5475
game_list_worker: Add better error handling to caching
7 years ago
Zach Hilman
944c07ac7d
yuzu: Clear partial/full game list cache when data is updated
7 years ago
Zach Hilman
f95bdb5088
game_list: Implement caching for game list
Preserves list of add ons and the icon, which are the two costliest parts of game list population.
7 years ago
Zach Hilman
180f22f17e
ui_settings: Add option to cache game list
7 years ago
ReinUsesLisp
37eaf39b44
emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy
There's no performance improvement in passing an unsigned pair by
reference.
7 years ago
Lioncash
88cd5e888e
configure_hotkeys: Remove unnecessary Settings::Apply() call
Nothing from the hotkeys dialog relies on this call occurring, and is
already called from the dialog that calls applyConfiguration().
7 years ago
Lioncash
6640f631e2
configure_hotkeys: Tidy up key sequence conflict error string
Avoids mentioning the user and formalizes the error itself.
7 years ago
Lioncash
d61199721d
configure_hotkeys: Change critical error dialog into a warning dialog
critical() is intended for critical/fatal errors that threaten the
overall stability of an application. A user entering a conflicting key
sequence is neither of those.
7 years ago
Lioncash
ef3c0f54d0
configure_hotkeys: Move conflict detection logic to IsUsedKey()
We don't need to extract the entire set of hotkeys into a list and then
iterate through it. We can traverse the list and early-exit if we're
able to.
7 years ago
Lioncash
c03fb00ac1
configure_hotkeys: Remove unused EmitHotkeysChanged()
1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal.
7 years ago
Lioncash
5d645c6dd9
sequence_dialog: Reorganize the constructor
The previous code was all "smushed" together wasn't really grouped
together that well.
This spaces things out and separates them by relation to one another,
making it easier to visually parse the individual sections of code that
make up the constructor.
7 years ago
Lioncash
9218e347cd
sequence_dialog: Remove unnecessary horizontal specifier
QDialogButtonBoxes are horizontal by default.
7 years ago
Lioncash
d623e38d18
yuzu/configuration/configure_graphics: Eliminate type narrowing in a connect call
A checkbox is able to be tri-state, giving it three possible activity
types, so in the connect call here, it would actually be truncating an
int into a bool.
Instead, we can just listen on the toggled() signal, which passes along
a bool, not an int.
7 years ago
Lioncash
3c0280cf66
yuzu/CMakeLists: Disable implicit QString conversions
Now that all of our code is compilable with implicit QString
conversions, we can enforce it at compile-time by disabling them.
7 years ago
Lioncash
bb06b98d81
yuzu/applets/software_keyboard: Remove unused assert header
This isn't actually used anywhere, so it can be removed.
7 years ago
Lioncash
16bf791939
yuzu/applets/software_keyboard: std::move argument in MainWindowFinishedText()
Given the std::optional can contain an object type that heap allocates,
we can use std::move to avoid an unnecessary copy/allocation from
occurring.
7 years ago
Lioncash
b3d7180164
yuzu/applets/software_keyboard: Resolve sign mismatch comparison
Qt uses a signed value to represent container sizes, so this was causing
a sign mismatch warning.
7 years ago
Lioncash
cf9cc41478
yuzu/applets/software_keyboard: Specify string conversions explicitly
Allows the software keyboard applet code to compile with implicit string
conversions disabled.
7 years ago
Lioncash
f5d416e071
yuzu/applets/error: Specify string conversions explicitly
Allows the error applet to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
6f2a8fbb13
yuzu/main: Specify string conversions where applicable
7 years ago
ReinUsesLisp
c03b8c4c19
gl_shader_cache: Use shared contexts to build shaders in parallel
7 years ago
Lioncash
f49a04ba39
yuzu/configuration/config: Make default hotkeys an internally-linked array in the cpp file
Given the array is a private static array, we can just make it
internally linked to hide it from external code. This also allows us to
remove an inclusion within the header.
7 years ago
Lioncash
938d6dca30
yuzu/configuration/config: Specify string conversions explicitly
Allows the configuration code to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
bc32474901
yuzu/game_list: Specify string conversions explicitly
Allows the game list code to compile successfully with implicit string
conversions disabled.
7 years ago
Lioncash
ed2fedac13
yuzu/game_list_worker: Specify string conversions explicitly
Allows the game list worker code to compile successfully with implicit
string conversions disabled.
7 years ago
Lioncash
7a82d6f394
yuzu/game_list_p: Amend mentions of SMDH in comments
SMDH is a metadata format used in some executable formats for the
Nintendo 3DS. Switch executables don't utilize this metadata format, so
this just a holdover from Citra and can be corrected.
7 years ago
Lioncash
486c3e6085
yuzu/game_list_p: Specify string conversions explicitly
Allows the game list item code to build with implicit string conversions
disabled.
7 years ago
Lioncash
922d8c6cb4
yuzu/loading_screen: Specify string conversions explicitly
Allows the loading screen code to compile with implicit string
conversions disabled.
While we're at it remove unnecessary const usages, and add it to nearby
variables where appropriate.
7 years ago
Lioncash
fd34732e26
yuzu/bootmanager: Specify string conversions explicitly
Allows the bootmanager code to compile with implicit string conversions
disabled.
7 years ago
Lioncash
317f1263fb
yuzu/util: Specify string conversions explicitly
Allows the util code to build with implicit string conversions disabled.
7 years ago
Lioncash
2318c394a8
yuzu/configuration/configure_web: Specify string conversions explicitly
Allows the web config code to compile with implicit string conversions
disabled. We can also deduplicate the calls to create the pixmap.
7 years ago
Lioncash
d9c4d64ed5
yuzu/configuration/configure_system: Specify string conversions explicitly
Allows the system config code to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
428d8098a7
yuzu/configuration/configure_profile_manager: Mark UI string as translatable
This is a user-facing string, so it should be marked as translatable.
7 years ago
Lioncash
17255cd835
yuzu/configuration/configure_per_general: Specify string conversions explicitly
Allows the per-game configuration to be successfully built with implicit
string conversions disabled.
7 years ago
Lioncash
3039211c20
yuzu/configuration/configure_mouse_advanced: Clean up array accesses
Deduplicates array accesses and uses a named variable where appropriate.
7 years ago
Lioncash
c9c4208c4a
yuzu/configuration/configure_mouse_advanced: Specify string conversions explicitly
Allows the advanced mouse configuration code to build with implicit
string conversions disabled.
7 years ago
Lioncash
aa83639b78
yuzu/configuration/configure_input_player: Clean up array accesses
Rather than repeatedly index arrays that have quite a large array index,
we can just use a named variable instead.
7 years ago
Lioncash
4d2da5a40a
yuzu/configuration/configure_input_player: Specify string conversions explicitly
Allows the player input configuration code to compile with implicit
string conversions disabled.
7 years ago
Lioncash
d81d4a0f68
yuzu/configuration/configure_input: Mark controller type names as translateable
These are user-facing strings, so they should be localizable.
7 years ago