2aa1ec7f8d
gl_rasterizer: Use in-class member initializers where applicable
We can just assign to the members directly in these cases.
8 years ago
772c408826
gl_rasterizer: Implement texture border color.
8 years ago
a5062c345f
maxwell_to_gl: Implement Texture::WrapMode::Border.
8 years ago
3a80e8ab24
GPU: Implement texture format R32F.
8 years ago
75c3f87d24
arm_dynarmic: Make MakeJit() a const member function
This functions doesn't modify instance state, so it can be a made a
const member function.
8 years ago
88f34a5b96
core: Make converting constructors explicit where applicable
Avoids unwanted implicit conversions. Thankfully, given the large amount
of cleanup in past PRs, only this tiny amount is left over to cover.
8 years ago
295d3104fb
maxwell_to_gl: Implement VertexAttribute::Type::UnsignedInt.
8 years ago
592a444838
apm/interface: Remove redundant declaration of InstallInterfaces()
This is already declared in apm/apm.h
8 years ago
ecc4f5065a
mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by reference
The pointed to thread's members are simply observed in this case, so we
don't need to copy it here.
8 years ago
bd410ce242
VFS Regression and Accuracy Fixes ( #776 )
* Regression and Mode Fixes
* Review Fixes
* string_view correction
* Add operator& for FileSys::Mode
* Return std::string from SanitizePath
* Farming Simulator Fix
* Use != With mode operator&
8 years ago
a15433c2a9
hle_ipc: Make constructors explicit where applicable
8 years ago
97ce8f0457
gl_shader_decompiler: Correct return value of WriteTexsInstruction()
This should be returning void, not a std::string
8 years ago
1c25b997e8
ipc_helpers: Make member variables of ResponseBuilder private
These aren't used externally at all, so they can be made private.
8 years ago
567ae2ae9c
gl_shader_decompiler: Implement shader instruction TLDS.
8 years ago
889da74c9d
gl_rasterizer_cache: Implement RenderTargetFormat RG32_FLOAT.
8 years ago
c8cb44909a
gl_rasterizer_cache: Implement RenderTargetFormat RGBA32_FLOAT.
8 years ago
e1ffcc6817
gl_rasterizer_cache: Implement RenderTargetFormat BGRA8_UNORM.
8 years ago
ff355e7684
gl_rasterizer_cache: Add missing log statements.
8 years ago
04cf719b92
gl_shader_decompiler: Print instruction value in shader comments.
8 years ago
658f096c03
gl_shader_decompiler: Check if SetRegister result is ZeroIndex.
8 years ago
78051d5378
exclusive_monitor: Use consistent type alias for u64
Uses the same type aliases we use for virtual addresses, and converts
one lingering usage of std::array<uint64_t, 2> to u128 for consistency.
8 years ago
6904f9f6b1
partition_filesystem: Use std::move where applicable
Avoids copying a std::string instance and avoids unnecessary atomic
reference count incrementing and decrementing.
8 years ago
204ed73e8c
loader: Remove unnecessary constructor call in IdentifyFile()
RealVfsFile inherits from VfsFile, the instance from std::make_shared is
already compatible with the function argument type, making the copy
constructor call unnecessary.
8 years ago
d5a96f2c94
linker: Remove unused parameter from WriteRelocations()
is_jump_relocation is never used within the function, so we can just
remove it.
8 years ago
3a72ee5fec
nro: Replace inclusion with a forward declaration
It's sufficient to use a forward declaration instead of a direct
inclusion here.
8 years ago
a2c69eb949
nro: Make bracing consistent
Makes the code more uniform, and also braces cases where the body of an
unbraced conditional travels more than one line.
8 years ago
6fd1615b93
nro: Make constructor explicit
Makes it consistent with the other Apploader constructors, and prevents
implicit conversions.
8 years ago
df82410454
nro: Remove unused forward declaration
This isn't used anywhere in the header.
8 years ago
71c3648ad6
gl_shader_decompiler: Simplify GetCommonDeclarations()
8 years ago
6e39fa5950
vi: Add std::is_trivially_copyable checks to Read and Write functions
It's undefined behavior to memcpy an object that isn't considered
trivially copyable, so put a compile-time check in to make sure this
doesn't occur.
8 years ago
dab340a3b3
vi: std::move std::vector in constructors where applicable
Allows avoiding unnecessary copies of the vector depending on the
calling code.
While we're at it, remove a redundant no-parameter base constructor call
8 years ago
ec38b938da
hle: Remove config_mem.h/.cpp
This is just an unused hold-over from citra, so we can get rid of this
to trim off an exposed global, among other things.
8 years ago
aba0f5452d
hle: Remove shared_page.h/.cpp
This is a holdover from citra that's essentially unused.
8 years ago
f53d6ee0bc
set: Add missing log call in GetAvailableLanguageCodeCount()
Forgot to include this in 2c22e4be19
8 years ago
ac0c52dd5f
NRO Assets and NACP file format
Cleanup
Review fixes
8 years ago
2c22e4be19
set: Implement GetAvailableLanguageCodeCount()
This just returns the size of the language code buffer.
8 years ago
6b4ed7cf2f
set: Correct return code size of value in GetAvailableLanguageCodes()
The return code should be 32-bit in size.
8 years ago
54b477c4f9
string_util: Get rid of separate resize() in CPToUTF16(), UTF16ToUTF8(), CodeToUTF8() and UTF8ToUTF16()
There's no need to perform the resize separately here, since the
constructor allows presizing the buffer.
Also move the empty string check before the construction of the string
to make the early out more straightforward.
8 years ago
cd09896057
string_util: Use emplace_back() in SplitString() instead of push_back()
This is equivalent to doing:
push_back(std::string(""));
which is likely not to cause issues, assuming a decent std::string
implementation with small-string optimizations implemented in its
design, however it's still a little unnecessary to copy that buffer
regardless. Instead, we can use emplace_back() to directly construct the
empty string within the std::vector instance, eliminating any possible
overhead from the copy.
8 years ago
7b00b5c322
string_util: Remove unnecessary std::string instance in TabsToSpaces()
We can just use the variant of std::string's replace() function that can
replace an occurrence with N copies of the same character, eliminating
the need to allocate a std::string containing a buffer of spaces.
8 years ago
e9639ffafa
Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel.
8 years ago
555a0638ec
Frontend: Check for more required OpenGL extensions during startup.
8 years ago
34bf2dbf68
Implement exclusive monitor
8 years ago
db185e6950
gl_shader_decompiler: Remove redundant Subroutine construction in AddSubroutine()
We don't need to toss away the Subroutine instance after the find() call
and reconstruct another instance with the same data right after it.
Particularly give Subroutine contains a std::set.
8 years ago
392383692c
shader_bytecode: Implement other TEXS masks.
8 years ago
2cbc2717e4
vfs: Correct file_p variable usage within InterpretAsDirectory()
ReplaceFileWithSubdirectory() takes a VirtualFile and a VirtualDir, but
it was being passed a string as one of its arguments. The only reason
this never caused issues is because this template isn't instantiated
anywhere yet.
This corrects an issue before it occurs.
8 years ago
861405d6c0
file_util, vfs: Use std::string_view where applicable
Avoids unnecessary construction of std::string instances where
applicable.
8 years ago
e8f619cc71
gl_shader_decompiler: Remove unused state tracking and minor cleanup.
8 years ago
3a6bad38b6
gl_shader_decompiler: Implement SEL instruction.
8 years ago
5440a4a9d9
file_util: Remove goto usages from Copy()
We can just leverage std::unique_ptr to automatically close these for us
in error cases instead of jumping to the end of the function to call
fclose on them.
8 years ago
Lioncash