Browse Source

Avoid OOB array access reading passthrough attr mask

YFC 1.5 extended the size of the varying mask used to hold passthrough attrs without considering this
pull/15/merge
Billy Laws 3 years ago
committed by GitHub
parent
commit
d34275a260
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      src/shader_recompiler/frontend/maxwell/translate_program.cpp

2
src/shader_recompiler/frontend/maxwell/translate_program.cpp

@ -259,7 +259,7 @@ IR::Program TranslateProgram(ObjectPool<IR::Inst>& inst_pool, ObjectPool<IR::Blo
program.is_geometry_passthrough = sph.common0.geometry_passthrough != 0; program.is_geometry_passthrough = sph.common0.geometry_passthrough != 0;
if (program.is_geometry_passthrough) { if (program.is_geometry_passthrough) {
const auto& mask{env.GpPassthroughMask()}; const auto& mask{env.GpPassthroughMask()};
for (size_t i = 0; i < program.info.passthrough.mask.size(); ++i) {
for (size_t i = 0; i < mask.size() * 32; ++i) {
program.info.passthrough.mask[i] = ((mask[i / 32] >> (i % 32)) & 1) == 0; program.info.passthrough.mask[i] = ((mask[i / 32] >> (i % 32)) & 1) == 0;
} }

Loading…
Cancel
Save