[vulkan] Dead code removal from VertexInputDynamicState

src/video_core/renderer_vulkan/vk_buffer_cache.cpp

@@ -598,17 +598,6 @@ void BufferCacheRuntime::BindVertexBuffer(u32 index, VkBuffer buffer, u32 offset
     if (index >= device.GetMaxVertexInputBindings()) {
         return;
     }
-    const bool use_dynamic_vertex_input_binding_stride =
-        device.IsExtExtendedDynamicStateSupported() &&
-        use_vertex_input_binding_stride_dynamic_state;
-    if (use_dynamic_vertex_input_binding_stride) {
-        scheduler.Record([index, buffer, offset, size, stride](vk::CommandBuffer cmdbuf) {
-            const VkDeviceSize vk_offset = buffer != VK_NULL_HANDLE ? offset : 0;
-            const VkDeviceSize vk_size = buffer != VK_NULL_HANDLE ? size : VK_WHOLE_SIZE;
-            const VkDeviceSize vk_stride = stride;
-            cmdbuf.BindVertexBuffers2EXT(index, 1, &buffer, &vk_offset, &vk_size, &vk_stride);
-        });
-    } else {
     if (!device.HasNullDescriptor() && buffer == VK_NULL_HANDLE) {
         ReserveNullBuffer();
         buffer = *null_buffer;
@@ -617,7 +606,6 @@ void BufferCacheRuntime::BindVertexBuffer(u32 index, VkBuffer buffer, u32 offset
     scheduler.Record([index, buffer, offset](vk::CommandBuffer cmdbuf) {
         cmdbuf.BindVertexBuffer(index, buffer, offset);
     });
-    }
 }
 
 void BufferCacheRuntime::BindVertexBuffers(VideoCommon::HostBindings<Buffer>& bindings) {
@@ -641,25 +629,12 @@ void BufferCacheRuntime::BindVertexBuffers(VideoCommon::HostBindings<Buffer>& bi
     if (binding_count == 0) {
         return;
     }
-    const bool use_dynamic_vertex_input_binding_stride =
-        device.IsExtExtendedDynamicStateSupported() &&
-        use_vertex_input_binding_stride_dynamic_state;
-    if (use_dynamic_vertex_input_binding_stride) {
-        scheduler.Record([bindings_ = std::move(bindings),
-                          buffer_handles_ = std::move(buffer_handles),
-                          binding_count](vk::CommandBuffer cmdbuf) {
-            cmdbuf.BindVertexBuffers2EXT(bindings_.min_index, binding_count, buffer_handles_.data(),
-                                         bindings_.offsets.data(), bindings_.sizes.data(),
-                                         bindings_.strides.data());
-        });
-    } else {
     scheduler.Record([bindings_ = std::move(bindings),
                       buffer_handles_ = std::move(buffer_handles),
                       binding_count](vk::CommandBuffer cmdbuf) {
         cmdbuf.BindVertexBuffers(bindings_.min_index, binding_count, buffer_handles_.data(),
                                  bindings_.offsets.data());
     });
-    }
 }
 
 void BufferCacheRuntime::BindTransformFeedbackBuffer(u32 index, VkBuffer buffer, u32 offset,

src/video_core/renderer_vulkan/vk_buffer_cache.h

@@ -127,9 +127,6 @@ public:
 
     void BindVertexBuffers(VideoCommon::HostBindings<Buffer>& bindings);
 
-    void SetUseVertexInputBindingStrideDynamicState(bool enabled) {
-        use_vertex_input_binding_stride_dynamic_state = enabled;
-    }
 
     void BindTransformFeedbackBuffer(u32 index, VkBuffer buffer, u32 offset, u32 size);
 
@@ -187,8 +184,6 @@ private:
     std::unique_ptr<Uint8Pass> uint8_pass;
     QuadIndexedPass quad_index_pass;    
 
-    bool use_vertex_input_binding_stride_dynamic_state = true;
-
     bool limit_dynamic_storage_buffers = false;
     u32 max_dynamic_storage_buffers = (std::numeric_limits<u32>::max)();
 };

src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp

@@ -462,7 +462,6 @@ bool GraphicsPipeline::ConfigureImpl(bool is_indexed) {
         bind_stage_info(4);
     }
 
-    buffer_cache.runtime.SetUseVertexInputBindingStrideDynamicState(UsesExtendedDynamicState());
     buffer_cache.UpdateGraphicsBuffers(is_indexed);
     buffer_cache.BindHostGeometryBuffers(is_indexed);
 
@@ -906,8 +905,6 @@ void GraphicsPipeline::MakePipeline(VkRenderPass render_pass) {
             VK_DYNAMIC_STATE_STENCIL_OP_EXT,
         };
         dynamic_states.insert(dynamic_states.end(), extended.begin(), extended.end());
-
-        dynamic_states.push_back(VK_DYNAMIC_STATE_VERTEX_INPUT_BINDING_STRIDE_EXT);
     } else {
         dynamic_states.push_back(VK_DYNAMIC_STATE_VIEWPORT);
         dynamic_states.push_back(VK_DYNAMIC_STATE_SCISSOR);