Merge pull request #3123 from ReinUsesLisp/logging-return

common/logging: Silence no return value warnings
6 years ago · 6f822067f2
1 changed files with 6 additions and 2 deletions
--- a/src/common/logging/backend.cpp
+++ b/src/common/logging/backend.cpp
@ -272,8 +272,10 @@ const char* GetLogClassName(Class log_class) {
 #undef CLS
 #undef SUB
    case Class::Count:
-        UNREACHABLE();
+        break;
    }
+    UNREACHABLE();
+    return "Invalid";
 }

 const char* GetLevelName(Level log_level) {
@ -288,9 +290,11 @@ const char* GetLevelName(Level log_level) {
        LVL(Error);
        LVL(Critical);
    case Level::Count:
-        UNREACHABLE();
+        break;
    }
 #undef LVL
+    UNREACHABLE();
+    return "Invalid";
 }

 void SetGlobalFilter(const Filter& filter) {