Browse Source

Kernel: Address Feedback

nce_cpp
Fernando Sahmkow 7 years ago
committed by FernandoS27
parent
commit
5581a0d296
  1. 1
      src/common/alignment.h
  2. 8
      src/core/hle/kernel/physical_memory.h
  3. 4
      src/core/hle/kernel/shared_memory.cpp

1
src/common/alignment.h

@ -52,7 +52,6 @@ public:
using const_reference = const T&;
public:
pointer address(reference r) {
return std::addressof(r);
}

8
src/core/hle/kernel/physical_memory.h

@ -8,6 +8,12 @@
namespace Kernel {
// This encapsulation serves 2 purposes:
// - First, to encapsulate host physical memory under a single type and set an
// standard for managing it.
// - Second to ensure all host backing memory used is aligned to 256 bytes due
// to strict alignment restrictions on GPU memory.
using PhysicalMemory = std::vector<u8, Common::AlignmentAllocator<u8, 256>>;
}
} // namespace Kernel

4
src/core/hle/kernel/shared_memory.cpp

@ -59,8 +59,8 @@ SharedPtr<SharedMemory> SharedMemory::Create(KernelCore& kernel, Process* owner_
}
SharedPtr<SharedMemory> SharedMemory::CreateForApplet(
KernelCore& kernel, std::shared_ptr<Kernel::PhysicalMemory> heap_block, std::size_t offset, u64 size,
MemoryPermission permissions, MemoryPermission other_permissions, std::string name) {
KernelCore& kernel, std::shared_ptr<Kernel::PhysicalMemory> heap_block, std::size_t offset,
u64 size, MemoryPermission permissions, MemoryPermission other_permissions, std::string name) {
SharedPtr<SharedMemory> shared_memory(new SharedMemory(kernel));
shared_memory->owner_process = nullptr;

Loading…
Cancel
Save