Browse Source

[qt] remove VTable bouncing from unsafe options in CPU settings (#3320)

it's a workaround, not a speed optimisation

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3320
Reviewed-by: DraVee <dravee@eden-emu.dev>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Co-authored-by: lizzie <lizzie@eden-emu.dev>
Co-committed-by: lizzie <lizzie@eden-emu.dev>
pull/3326/head
lizzie 3 weeks ago
committed by crueter
parent
commit
170f113453
No known key found for this signature in database GPG Key ID: 425ACD2D4830EBC6
  1. 4
      src/common/settings.h
  2. 6
      src/yuzu/configuration/configure_cpu.cpp

4
src/common/settings.h

@ -240,7 +240,6 @@ struct Values {
Category::Cpu}; Category::Cpu};
SwitchableSetting<CpuAccuracy, true> cpu_accuracy{linkage, CpuAccuracy::Auto, SwitchableSetting<CpuAccuracy, true> cpu_accuracy{linkage, CpuAccuracy::Auto,
"cpu_accuracy", Category::Cpu}; "cpu_accuracy", Category::Cpu};
SwitchableSetting<bool> vtable_bouncing{linkage, true, "vtable_bouncing", Category::Cpu};
SwitchableSetting<CpuClock> fast_cpu_time{linkage, SwitchableSetting<CpuClock> fast_cpu_time{linkage,
CpuClock::Off, CpuClock::Off,
"fast_cpu_time", "fast_cpu_time",
@ -267,6 +266,9 @@ struct Values {
true, true,
true, true,
&use_custom_cpu_ticks}; &use_custom_cpu_ticks};
SwitchableSetting<bool> vtable_bouncing{linkage, true, "vtable_bouncing", Category::Cpu};
Setting<bool> cpuopt_page_tables{linkage, true, "cpuopt_page_tables", Category::CpuDebug}; Setting<bool> cpuopt_page_tables{linkage, true, "cpuopt_page_tables", Category::CpuDebug};
Setting<bool> cpuopt_block_linking{linkage, true, "cpuopt_block_linking", Category::CpuDebug}; Setting<bool> cpuopt_block_linking{linkage, true, "cpuopt_block_linking", Category::CpuDebug};
Setting<bool> cpuopt_return_stack_buffer{linkage, true, "cpuopt_return_stack_buffer", Setting<bool> cpuopt_return_stack_buffer{linkage, true, "cpuopt_return_stack_buffer",

6
src/yuzu/configuration/configure_cpu.cpp

@ -76,9 +76,9 @@ void ConfigureCpu::Setup(const ConfigurationShared::Builder& builder) {
} else if (setting->Id() == Settings::values.cpu_backend.Id()) { } else if (setting->Id() == Settings::values.cpu_backend.Id()) {
backend_layout->addWidget(widget); backend_layout->addWidget(widget);
backend_combobox = widget->combobox; backend_combobox = widget->combobox;
} else if (setting->Id() == Settings::values.fast_cpu_time.Id()) {
ui->general_layout->addWidget(widget);
} else if (setting->Id() == Settings::values.cpu_ticks.Id()) {
} else if (setting->Id() == Settings::values.fast_cpu_time.Id()
|| setting->Id() == Settings::values.vtable_bouncing.Id()
|| setting->Id() == Settings::values.cpu_ticks.Id()) {
ui->general_layout->addWidget(widget); ui->general_layout->addWidget(widget);
} else { } else {
// Presently, all other settings here are unsafe checkboxes // Presently, all other settings here are unsafe checkboxes

Loading…
Cancel
Save