From 170f113453c7d643701485cbeb66d04ee9c34258 Mon Sep 17 00:00:00 2001 From: lizzie Date: Sat, 17 Jan 2026 03:40:09 +0100 Subject: [PATCH] [qt] remove VTable bouncing from unsafe options in CPU settings (#3320) it's a workaround, not a speed optimisation Signed-off-by: lizzie Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3320 Reviewed-by: DraVee Reviewed-by: MaranBr Co-authored-by: lizzie Co-committed-by: lizzie --- src/common/settings.h | 4 +++- src/yuzu/configuration/configure_cpu.cpp | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/common/settings.h b/src/common/settings.h index 0053f37ea9..03a371cd1d 100644 --- a/src/common/settings.h +++ b/src/common/settings.h @@ -240,7 +240,6 @@ struct Values { Category::Cpu}; SwitchableSetting cpu_accuracy{linkage, CpuAccuracy::Auto, "cpu_accuracy", Category::Cpu}; - SwitchableSetting vtable_bouncing{linkage, true, "vtable_bouncing", Category::Cpu}; SwitchableSetting fast_cpu_time{linkage, CpuClock::Off, "fast_cpu_time", @@ -267,6 +266,9 @@ struct Values { true, true, &use_custom_cpu_ticks}; + + SwitchableSetting vtable_bouncing{linkage, true, "vtable_bouncing", Category::Cpu}; + Setting cpuopt_page_tables{linkage, true, "cpuopt_page_tables", Category::CpuDebug}; Setting cpuopt_block_linking{linkage, true, "cpuopt_block_linking", Category::CpuDebug}; Setting cpuopt_return_stack_buffer{linkage, true, "cpuopt_return_stack_buffer", diff --git a/src/yuzu/configuration/configure_cpu.cpp b/src/yuzu/configuration/configure_cpu.cpp index 6407efbb26..bc1140d835 100644 --- a/src/yuzu/configuration/configure_cpu.cpp +++ b/src/yuzu/configuration/configure_cpu.cpp @@ -76,9 +76,9 @@ void ConfigureCpu::Setup(const ConfigurationShared::Builder& builder) { } else if (setting->Id() == Settings::values.cpu_backend.Id()) { backend_layout->addWidget(widget); backend_combobox = widget->combobox; - } else if (setting->Id() == Settings::values.fast_cpu_time.Id()) { - ui->general_layout->addWidget(widget); - } else if (setting->Id() == Settings::values.cpu_ticks.Id()) { + } else if (setting->Id() == Settings::values.fast_cpu_time.Id() + || setting->Id() == Settings::values.vtable_bouncing.Id() + || setting->Id() == Settings::values.cpu_ticks.Id()) { ui->general_layout->addWidget(widget); } else { // Presently, all other settings here are unsafe checkboxes