Browse Source
Use UNREACHABLE macro for impossible cases in previous commit
Use the UNREACHABLE macro instead of `ASSERT(false, ...);`.
pull/15/merge
Benjamin Barenblat
11 years ago
No known key found for this signature in database
GPG Key ID: 9E730149EB91C53B
2 changed files with
3 additions and
4 deletions
-
src/common/logging/backend.cpp
-
src/common/logging/text_formatter.cpp
|
|
|
@ -80,8 +80,7 @@ const char* GetLevelName(Level log_level) { |
|
|
|
LVL(Error); |
|
|
|
LVL(Critical); |
|
|
|
case Level::Count: |
|
|
|
ASSERT_MSG(false, "invalid log level"); |
|
|
|
return "Unknown"; |
|
|
|
UNREACHABLE(); |
|
|
|
} |
|
|
|
#undef LVL
|
|
|
|
} |
|
|
|
|
|
|
|
@ -84,7 +84,7 @@ void PrintColoredMessage(const Entry& entry) { |
|
|
|
case Level::Critical: // Bright magenta
|
|
|
|
color = FOREGROUND_RED | FOREGROUND_BLUE | FOREGROUND_INTENSITY; break; |
|
|
|
case Level::Count: |
|
|
|
ASSERT_MSG(false, "invalid log level"); break; |
|
|
|
UNREACHABLE(); |
|
|
|
} |
|
|
|
|
|
|
|
SetConsoleTextAttribute(console_handle, color); |
|
|
|
@ -105,7 +105,7 @@ void PrintColoredMessage(const Entry& entry) { |
|
|
|
case Level::Critical: // Bright magenta
|
|
|
|
color = ESC "[1;35m"; break; |
|
|
|
case Level::Count: |
|
|
|
ASSERT_MSG(false, "invalid log level"); break; |
|
|
|
UNREACHABLE(); |
|
|
|
} |
|
|
|
|
|
|
|
fputs(color, stderr); |
|
|
|
|