eden-emu/eden - eden - InfoTonic

Maufeat 89d40c6302 [vk, texture_cache] MSAA ensure no more crash (#245 ) > The shared_ptr<Image> capture ensures the temporary image outlives all queued GPU work (both the upload/download step and the MSAA compute copy). Without this, drivers read freed memory > The temp image always has STORAGE & TRANSFER usage, matching what the compute MSAA path actually binds. > Since this only a temp fix ontop of the previous commit, we only use the MSAA path for color; depth/stencil still use the original safe route. > Should still be reworked though, as seen in the other MSAA commis that are open. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/245 Reviewed-by: crueter <crueter@eden-emu.dev> Reviewed-by: Shinmegumi <shinmegumi@eden-emu.dev> Co-authored-by: Maufeat <sahyno1996@gmail.com> Co-committed-by: Maufeat <sahyno1996@gmail.com>	12 months ago
..
workflows	[vk, texture_cache] MSAA ensure no more crash (#245)	12 months ago

[vk, texture_cache] MSAA ensure no more crash (#245 )

> The shared_ptr<Image> capture ensures the temporary image outlives all queued GPU work (both the upload/download step and the MSAA compute copy). Without this, drivers read freed memory
> The temp image always has STORAGE & TRANSFER usage, matching what the compute MSAA path actually binds.
> Since this only a temp fix ontop of the previous commit, we only use the MSAA path for color; depth/stencil still use the original safe route.
> Should still be reworked though, as seen in the other MSAA commis that are open.

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/245
Reviewed-by: crueter <crueter@eden-emu.dev>
Reviewed-by: Shinmegumi <shinmegumi@eden-emu.dev>
Co-authored-by: Maufeat <sahyno1996@gmail.com>
Co-committed-by: Maufeat <sahyno1996@gmail.com>

12 months ago

workflows

[vk, texture_cache] MSAA ensure no more crash (#245)

12 months ago