eden-emu/eden - eden - InfoTonic

BoiledElectricity 470d43df6d [hid_core] fix bounds-check aruid index in GetControllerFromNpadIdType (#4064 ) GetIndexFromAruid returns AruidIndexMax as the “not found” value, but both GetControllerFromNpadIdType overloads were using that value to index controller_data without checking it first. when a game routes through DisconnectNpad before its applet resource is registered, we can end up indexing past the end of controller_data. That seems to be what was crashing some games on launch, especially on macOS and Android, where the out-of-bounds read is less likely to just slide by unnoticed. So yeah, AruidIndexMax is a sentinel, not a real controller_data index, so we should not treat it like one. Fixes: https://github.com/eden-emulator/Issue-Reports/issues/438 Fixes: https://github.com/eden-emulator/Issue-Reports/issues/439 Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4064 Reviewed-by: Lizzie <lizzie@eden-emu.dev> Reviewed-by: MaranBr <maranbr@eden-emu.dev>	2 months ago
..
Demangle	[hid_core] fix bounds-check aruid index in GetControllerFromNpadIdType (#4064)	2 months ago

BoiledElectricity 470d43df6d

[hid_core] fix bounds-check aruid index in GetControllerFromNpadIdType (#4064 )

GetIndexFromAruid returns AruidIndexMax as the “not found” value, but both
GetControllerFromNpadIdType overloads were using that value to index
controller_data without checking it first.

when a game routes through DisconnectNpad before its applet resource is
registered, we can end up indexing past the end of controller_data. That seems
to be what was crashing some games on launch, especially on macOS and Android,
where the out-of-bounds read is less likely to just slide by unnoticed.

So yeah, AruidIndexMax is a sentinel, not a real controller_data index, so we
should not treat it like one.

  Fixes: https://github.com/eden-emulator/Issue-Reports/issues/438
  Fixes: https://github.com/eden-emulator/Issue-Reports/issues/439

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4064
Reviewed-by: Lizzie <lizzie@eden-emu.dev>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>

2 months ago

Demangle

[hid_core] fix bounds-check aruid index in GetControllerFromNpadIdType (#4064)

2 months ago