9a07ed53eb
core: Make variable shadowing a compile-time error
Now that we have most of core free of shadowing, we can enable the
warning as an error to catch anything that may be remaining and also
eliminate this class of logic bug entirely.
5 years ago
2a7eff57a8
hle: kernel: Rename Process to KProcess.
5 years ago
1da72c7792
file_sys: Resolve cases of variable shadowing
Brings us closer to enabling -Wshadow as an error in the core code.
5 years ago
72b22fd433
service: filesystem: Return proper error codes for CreateFile
This improves the accuracy of CreateFile by returning the correct error codes on certain conditions (parent directory does not exist, path already exists).
This fixes saving and the loading of existing saves in New Pokemon Snap
5 years ago
1c65b3ee53
program_metadata: Set a default resource size when a NPDM is not present
Sets a default size of 0x1FE00000 bytes (510 MiB) for the system_resource_size when a NPDM is not present.
5 years ago
ae93402312
program_metadata: Explicitly specify copy/move functions
The generation of the copy assignment operators are deprecated on being
generated when a user-provided destructor is present.
We can explicitly specify that we desire this behavior to keep the class
forward compatible with future standards.
5 years ago
a4c6712a4b
common: Move settings to common from core.
- Removes a dependency on core and input_common from common.
5 years ago
e9a1f29e93
pctl: Rework how pctl works to be more accurate
Introduces the usage of compatibilities to allow it the module to be closer to how it works on hardware.
5 years ago
824e53149d
system_version: Update to 11.0.1
5 years ago
9761618a8d
system_archive: Update NgWord archive version
5 years ago
e9bb95ae16
vfs_real: When moving files or directories, don't assume file opening will succeed
Found this via a warning, but it's a substantive fix.
Since this is only for a cache, it should be safe to silently drop the
entry if opening fails. I think.
6 years ago
f8650a9580
core: Silence Wclass-memaccess warnings
This requires making several types trivial and properly initialize
them whenever they are called.
5 years ago
3ff978aa4f
common/common_funcs: Rename INSERT_UNION_PADDING_{BYTES,WORDS} to _NOINIT
INSERT_PADDING_BYTES_NOINIT is more descriptive of the underlying behavior.
5 years ago
c68d0dc851
file_sys/registered_cache: Silence virtual functions without override warnings
5 years ago
4f13e270c8
core: Silence warnings when compiling without asserts
5 years ago
79316be18c
system_archive: Add + and - buttons to the Nintendo Extended OSS font
5 years ago
5d29d2111c
system_archive: Update Nintendo Extended OSS font
Co-authored-by: Its-Rei <kupfel@gmail.com>
5 years ago
dfee6321cd
Revert "Merge pull request #5176 from Morph1984/fix-createfile"
This reverts commit 6d6115475b5fe55b16a1
5 years ago
b1657b8c6b
vfs: Use existing type aliases consistently
Makes use of the VirtualDir and VirtualFile aliases across the board
instead of having a few isolated places that don't use it.
5 years ago
b06d6e3646
vfs_real: Fix CreateFile for files without a file extension
5 years ago
e15039372e
fsp_srv: Implement OpenDataStorageWithProgramIndex
- Used by RollerCoaster Tycoon 3: Complete Edition
5 years ago
0eb6c6cd83
file_sys: Consolidate common Title ID operations
5 years ago
6b7320add4
core: Remove unnecessary enum casts in log calls
Follows the video core PR. fmt doesn't require casts for enum classes
anymore, so we can remove quite a few casts.
5 years ago
f95602f152
video_core: Resolve more variable shadowing scenarios pt.3
Cleans out the rest of the occurrences of variable shadowing and makes
any further occurrences of shadowing compiler errors.
5 years ago
7fbeb489d3
system_version: Update to 11.0.0
5 years ago
073e07ae2d
savedata_factory: Eliminate usage of the global system instance
Now there's only two meaningful instances left in core.
5 years ago
5f75d97125
core: loader: Implement support for loading indexed programs.
5 years ago
6f8a06bac5
patch_manager: Remove usages of the global system instance
With this, only 19 usages of the global system instance remain within
the core library.
We're almost there.
5 years ago
3d592972dc
Revert "core: Fix clang build"
6 years ago
be1954e04c
core: Fix clang build
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.
Fixes #4795
6 years ago
39c8d18feb
core/CMakeLists: Make some warnings errors
Makes our error coverage a little more consistent across the board by
applying it to Linux side of things as well. This also makes it more
consistent with the warning settings in other libraries in the project.
This also updates httplib to 0.7.9, as there are several warning
cleanups made that allow us to enable several warnings as errors.
6 years ago
3602df7f1f
submission_package: Fix updates integrated into cartridge images.
6 years ago
ff45c39578
General: Make use of std::nullopt where applicable
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.
This also makes it consistent how we return empty optionals.
6 years ago
a881efbf26
ips_layer: Eliminate a redundant copy in Parse()
Prevents unnecessary copying of the line being parsed.
6 years ago
41c2f5200c
submission_package: Account for multi-content NSPs
Previously we assumed a submission package can only contain one Program NCA with a single TitleID.
However, Super Mario 3D All-Stars contains four Program NCAs, each with their unique TitleIDs.
This accounts for the existence of multi-content games such as this one.
- Fixes booting Super Mario 3D All-Stars from the games list.
6 years ago
02b8b6677a
control_metadata: Resolve typo in Portuguese language name
This isn't used anywhere, so this is a trivial fix.
6 years ago
a62c1999c5
file_sys/romfs_factory: Eliminate usage of the global system accessor
6 years ago
0e80567bef
file_sys/bis_factory: Eliminate usage of the global system accessor
6 years ago
66fc037ef2
nca_patch: Significantly reduce the stack usage size within SearchBucketEntry()
Previously this function was using ~16KB of stack (16528 bytes), which
was caused by the function arguments being taken by value rather than by
reference.
We can make this significantly lighter on the stack by taking them by
reference.
6 years ago
99b372a6c5
nca_patch: Make SearchBucketEntry() internally linked
This is only used internally and doesn't depend on any class state, so
we can make it fully internal.
6 years ago
ba7eb5abf4
cheat_engine: Remove unnecessary system argument to CheatParser's Parse function
This isn't used within the function at all in any implementations, so we
can remove it entirely.
6 years ago
33e4a0b6c1
patch_manager: Resolve implicit truncations in FormatTitleVersion()
We make it explicit that we're truncating arithmetic here to resolve
compiler warnings (even if the sizes weren't u32/u64 arithmetic
generally promotes to int :<)
6 years ago
a4392c24cf
patch_manager: Make use of type aliases
We can use these to avoid typing the same type redundantly. This way, if
these ever change, only a single location needs to be modified.
6 years ago
637ab14ae6
patch_manager: Make a few functions internally linked
These functions are only used within this translation unit, so we can
make them internally linked.
6 years ago
827ff077e7
file_sys/patch_manager: Add missing include
Fixes build issues
6 years ago
01d1b5cdaf
file_sys: Replace inclusions with forward declarations where applicable
Same behavior, minus unnecessary inclusions where not necessary.
6 years ago
67a8e73101
registered_cache: Make use of ends_with for string suffix checking
Simplifies code.
6 years ago
f83c6e1e0c
registered_cache: Make use of designated initializers
Removes the need for comments to indicate the fields being assigned.
6 years ago
551882e512
vfs_real: Resolve sign conversion warnings
6 years ago
ed9ae5a977
vfs_real: Avoid redundant map lookups
Avoids some trivially avoidable map lookups by keeping the result of
find operations around and querying them.
6 years ago
Lioncash