Lioncash
982ebbb022
yuzu/bootmanager: unsigned -> u32
Same thing (for platforms we support), less reading.
7 years ago
Lioncash
0cbdedd429
yuzu/bootmanager: Change false literal to 0 for setSwapInterval()
This function is defined as taking an int, not a bool.
7 years ago
Lioncash
8d120b9121
yuzu/bootmanager: Remove pointer downcast in GRenderWindow's constructor
We can just pass a pointer to GMainWindow directly and make it a
requirement of the interface. This makes the interface a little safer,
since this would technically otherwise allow any random QWidget to be
the parent of a render window, downcasting it to GMainWindow (which is
undefined behavior).
7 years ago
Lioncash
531072e387
yuzu/bootmanager: Remove unnecessary pointer casts
We can just invoke these functions by qualifying the object name before
the function.
7 years ago
Lioncash
a1874b586a
game_list_worker: Use QFile over our own IOFile instance or std streams
Stays consistent in our code with using Qt's provided mechanisms, and
also properly handles Unicode paths (which file streams on Windows don't
do very well).
7 years ago
Lioncash
7e7505d5a0
game_list_worker: Remove template specializations
This is equivalent to specifying two separate functions, so we can just
do that.
7 years ago
ReinUsesLisp
b70a0ec46d
rasterizer_opengl: Remove OpenGL core profile
7 years ago
Zach Hilman
99e5ba2e98
main: Remove extraneous comment
7 years ago
ReinUsesLisp
0d80feda2d
qt: Silence name collision warnings
7 years ago
fearlessTobi
5dc330f1ef
yuzu: Remove unused birthday setting
Fixes #2522 .
7 years ago
Lioncash
a4d4b67322
yuzu/software_keyboard: Remove unnecessary GetStatus() member function
Like with the profile selection dialog, we can just use the result of
QDialog's exec() function to determine whether or not a dialog was
accepted.
7 years ago
Lioncash
5cf1aab5a8
profile_select: Remove unnecessary GetStatus() member function
This behavior is already provided by the built-in exec() function. We
just need to check the return value of it.
7 years ago
Lioncash
5f2adf1a9e
profile_select: Return int instead of u32 for GetIndex()
Qt uses a signed value to represent indices. We should follow this
convention where applicable to avoid unnecessary sign-conversion
warnings, as well as making it easier to interoperate with other aspects
of Qt.
While we're at it, we can also make a sign-conversion explicit.
7 years ago
Lioncash
7dd4fbf551
core/loader: Remove LoadKernelSystemMode
This is a hold-over from Citra and doesn't apply to yuzu.
7 years ago
Zach Hilman
2cc382429e
game_list_worker: Add better error handling to caching
7 years ago
Zach Hilman
246a57be6f
yuzu: Clear partial/full game list cache when data is updated
7 years ago
Zach Hilman
6aba84eee1
game_list: Implement caching for game list
Preserves list of add ons and the icon, which are the two costliest parts of game list population.
7 years ago
Zach Hilman
14a039fa95
ui_settings: Add option to cache game list
7 years ago
Zach Hilman
227430a157
loader: Move NSO module tracking to AppLoader
Also cleanup of general stuff
7 years ago
ReinUsesLisp
2410482b11
emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy
There's no performance improvement in passing an unsigned pair by
reference.
7 years ago
Zach Hilman
28886a2927
qt: Make UI option for 'Reporting Services' temporary
Reports are unnecessary for normal users and this is to prevent 'power' users from enabling the feature by accident.
7 years ago
Zach Hilman
a3c66e920b
settings: Add 'Reporting Services' config option
Full enable/disable for all reports.
7 years ago
Lioncash
c0c69367c7
configure_hotkeys: Remove unnecessary Settings::Apply() call
Nothing from the hotkeys dialog relies on this call occurring, and is
already called from the dialog that calls applyConfiguration().
7 years ago
Lioncash
1e12e2f906
configure_hotkeys: Tidy up key sequence conflict error string
Avoids mentioning the user and formalizes the error itself.
7 years ago
Lioncash
02687c55b4
configure_hotkeys: Change critical error dialog into a warning dialog
critical() is intended for critical/fatal errors that threaten the
overall stability of an application. A user entering a conflicting key
sequence is neither of those.
7 years ago
Lioncash
0989921fb9
configure_hotkeys: Move conflict detection logic to IsUsedKey()
We don't need to extract the entire set of hotkeys into a list and then
iterate through it. We can traverse the list and early-exit if we're
able to.
7 years ago
Lioncash
c227927751
configure_hotkeys: Remove unused EmitHotkeysChanged()
1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal.
7 years ago
Lioncash
82b996abf7
sequence_dialog: Reorganize the constructor
The previous code was all "smushed" together wasn't really grouped
together that well.
This spaces things out and separates them by relation to one another,
making it easier to visually parse the individual sections of code that
make up the constructor.
7 years ago
Lioncash
6b913ce590
sequence_dialog: Remove unnecessary horizontal specifier
QDialogButtonBoxes are horizontal by default.
7 years ago
Lioncash
2cb44f4a07
yuzu/configuration/configure_graphics: Eliminate type narrowing in a connect call
A checkbox is able to be tri-state, giving it three possible activity
types, so in the connect call here, it would actually be truncating an
int into a bool.
Instead, we can just listen on the toggled() signal, which passes along
a bool, not an int.
7 years ago
Lioncash
6924e2ee68
yuzu/CMakeLists: Disable implicit QString conversions
Now that all of our code is compilable with implicit QString
conversions, we can enforce it at compile-time by disabling them.
7 years ago
Lioncash
f4a1312c3c
yuzu/applets/software_keyboard: Remove unused assert header
This isn't actually used anywhere, so it can be removed.
7 years ago
Lioncash
c991a5d2b0
yuzu/applets/software_keyboard: std::move argument in MainWindowFinishedText()
Given the std::optional can contain an object type that heap allocates,
we can use std::move to avoid an unnecessary copy/allocation from
occurring.
7 years ago
Lioncash
63eed87b61
yuzu/applets/software_keyboard: Resolve sign mismatch comparison
Qt uses a signed value to represent container sizes, so this was causing
a sign mismatch warning.
7 years ago
Lioncash
cd72443889
yuzu/applets/software_keyboard: Specify string conversions explicitly
Allows the software keyboard applet code to compile with implicit string
conversions disabled.
7 years ago
Lioncash
0cfd78073f
yuzu/applets/error: Specify string conversions explicitly
Allows the error applet to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
8dc757f1e2
yuzu/main: Specify string conversions where applicable
7 years ago
ReinUsesLisp
88115ea055
gl_shader_cache: Use shared contexts to build shaders in parallel
7 years ago
Lioncash
3aaf69d786
yuzu/configuration/config: Make default hotkeys an internally-linked array in the cpp file
Given the array is a private static array, we can just make it
internally linked to hide it from external code. This also allows us to
remove an inclusion within the header.
7 years ago
Lioncash
66852a73e2
yuzu/configuration/config: Specify string conversions explicitly
Allows the configuration code to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
b254ac5a1e
yuzu/game_list: Specify string conversions explicitly
Allows the game list code to compile successfully with implicit string
conversions disabled.
7 years ago
Lioncash
16afc41307
yuzu/game_list_worker: Specify string conversions explicitly
Allows the game list worker code to compile successfully with implicit
string conversions disabled.
7 years ago
Lioncash
4b1c7f1522
yuzu/game_list_p: Amend mentions of SMDH in comments
SMDH is a metadata format used in some executable formats for the
Nintendo 3DS. Switch executables don't utilize this metadata format, so
this just a holdover from Citra and can be corrected.
7 years ago
Lioncash
bb365da623
yuzu/game_list_p: Specify string conversions explicitly
Allows the game list item code to build with implicit string conversions
disabled.
7 years ago
Lioncash
4a0cedd6e7
yuzu/loading_screen: Specify string conversions explicitly
Allows the loading screen code to compile with implicit string
conversions disabled.
While we're at it remove unnecessary const usages, and add it to nearby
variables where appropriate.
7 years ago
Lioncash
b0fd32487c
yuzu/bootmanager: Specify string conversions explicitly
Allows the bootmanager code to compile with implicit string conversions
disabled.
7 years ago
Lioncash
409e0499d5
yuzu/util: Specify string conversions explicitly
Allows the util code to build with implicit string conversions disabled.
7 years ago
Lioncash
a6309ae255
yuzu/configuration/configure_web: Specify string conversions explicitly
Allows the web config code to compile with implicit string conversions
disabled. We can also deduplicate the calls to create the pixmap.
7 years ago
Lioncash
e587f53654
yuzu/configuration/configure_system: Specify string conversions explicitly
Allows the system config code to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
24f3048353
yuzu/configuration/configure_profile_manager: Mark UI string as translatable
This is a user-facing string, so it should be marked as translatable.
7 years ago