d71e19fd75
video_core/memory_manager: Avoid repeated unnecessary page slot lookups
We don't need to keep calling the same function over and over again in a
loop, especially when the behavior is slightly non-trivial. We can just
keep a reference to the looked up location and do all the checking and
assignments based off it instead.
8 years ago
69c45ce71c
gl_rasterizer: Implement texture border color.
8 years ago
6b3e54621f
maxwell_to_gl: Implement Texture::WrapMode::Border.
8 years ago
ccc42702b5
GPU: Implement texture format R32F.
8 years ago
7d124ec82b
arm_dynarmic: Make MakeJit() a const member function
This functions doesn't modify instance state, so it can be a made a
const member function.
8 years ago
1d755abce4
core: Make converting constructors explicit where applicable
Avoids unwanted implicit conversions. Thankfully, given the large amount
of cleanup in past PRs, only this tiny amount is left over to cover.
8 years ago
2ff86f5765
maxwell_to_gl: Implement VertexAttribute::Type::UnsignedInt.
8 years ago
8b83adfed6
apm/interface: Remove redundant declaration of InstallInterfaces()
This is already declared in apm/apm.h
8 years ago
42b5158c96
mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by reference
The pointed to thread's members are simply observed in this case, so we
don't need to copy it here.
8 years ago
59cb258409
VFS Regression and Accuracy Fixes ( #776 )
* Regression and Mode Fixes
* Review Fixes
* string_view correction
* Add operator& for FileSys::Mode
* Return std::string from SanitizePath
* Farming Simulator Fix
* Use != With mode operator&
8 years ago
22fd3f0026
hle_ipc: Make constructors explicit where applicable
8 years ago
33e2033af5
gl_shader_decompiler: Correct return value of WriteTexsInstruction()
This should be returning void, not a std::string
8 years ago
2a1daf8f83
ipc_helpers: Make member variables of ResponseBuilder private
These aren't used externally at all, so they can be made private.
8 years ago
9505283989
gl_shader_decompiler: Implement shader instruction TLDS.
8 years ago
a27c0099ed
gl_rasterizer_cache: Implement RenderTargetFormat RG32_FLOAT.
8 years ago
3a19c1098d
gl_rasterizer_cache: Implement RenderTargetFormat RGBA32_FLOAT.
8 years ago
bcc184acfa
gl_rasterizer_cache: Implement RenderTargetFormat BGRA8_UNORM.
8 years ago
89db8c2171
gl_rasterizer_cache: Add missing log statements.
8 years ago
c4322ce87e
gl_shader_decompiler: Print instruction value in shader comments.
8 years ago
81aa02424b
gl_shader_decompiler: Check if SetRegister result is ZeroIndex.
8 years ago
e12c84d5c5
exclusive_monitor: Use consistent type alias for u64
Uses the same type aliases we use for virtual addresses, and converts
one lingering usage of std::array<uint64_t, 2> to u128 for consistency.
8 years ago
db48ebb9c9
partition_filesystem: Use std::move where applicable
Avoids copying a std::string instance and avoids unnecessary atomic
reference count incrementing and decrementing.
8 years ago
a147fa5825
loader: Remove unnecessary constructor call in IdentifyFile()
RealVfsFile inherits from VfsFile, the instance from std::make_shared is
already compatible with the function argument type, making the copy
constructor call unnecessary.
8 years ago
184c516182
linker: Remove unused parameter from WriteRelocations()
is_jump_relocation is never used within the function, so we can just
remove it.
8 years ago
1b4d0ac20e
nro: Replace inclusion with a forward declaration
It's sufficient to use a forward declaration instead of a direct
inclusion here.
8 years ago
2b497e5830
nro: Make bracing consistent
Makes the code more uniform, and also braces cases where the body of an
unbraced conditional travels more than one line.
8 years ago
ac8133b9ee
nro: Make constructor explicit
Makes it consistent with the other Apploader constructors, and prevents
implicit conversions.
8 years ago
1c16700372
nro: Remove unused forward declaration
This isn't used anywhere in the header.
8 years ago
3b88ce3dcb
gl_shader_decompiler: Simplify GetCommonDeclarations()
8 years ago
1432912ae8
vi: Add std::is_trivially_copyable checks to Read and Write functions
It's undefined behavior to memcpy an object that isn't considered
trivially copyable, so put a compile-time check in to make sure this
doesn't occur.
8 years ago
344a0c91f2
vi: std::move std::vector in constructors where applicable
Allows avoiding unnecessary copies of the vector depending on the
calling code.
While we're at it, remove a redundant no-parameter base constructor call
8 years ago
cbe841c9c9
hle: Remove config_mem.h/.cpp
This is just an unused hold-over from citra, so we can get rid of this
to trim off an exposed global, among other things.
8 years ago
1f3889a290
hle: Remove shared_page.h/.cpp
This is a holdover from citra that's essentially unused.
8 years ago
e85308cd90
set: Add missing log call in GetAvailableLanguageCodeCount()
Forgot to include this in 22f448b632
8 years ago
e8f641a52d
NRO Assets and NACP file format
Cleanup
Review fixes
8 years ago
22f448b632
set: Implement GetAvailableLanguageCodeCount()
This just returns the size of the language code buffer.
8 years ago
37aeecd29f
set: Correct return code size of value in GetAvailableLanguageCodes()
The return code should be 32-bit in size.
8 years ago
9d33122197
string_util: Get rid of separate resize() in CPToUTF16(), UTF16ToUTF8(), CodeToUTF8() and UTF8ToUTF16()
There's no need to perform the resize separately here, since the
constructor allows presizing the buffer.
Also move the empty string check before the construction of the string
to make the early out more straightforward.
8 years ago
26a157cd31
string_util: Use emplace_back() in SplitString() instead of push_back()
This is equivalent to doing:
push_back(std::string(""));
which is likely not to cause issues, assuming a decent std::string
implementation with small-string optimizations implemented in its
design, however it's still a little unnecessary to copy that buffer
regardless. Instead, we can use emplace_back() to directly construct the
empty string within the std::vector instance, eliminating any possible
overhead from the copy.
8 years ago
cd46b267f5
string_util: Remove unnecessary std::string instance in TabsToSpaces()
We can just use the variant of std::string's replace() function that can
replace an occurrence with N copies of the same character, eliminating
the need to allocate a std::string containing a buffer of spaces.
8 years ago
7841447cf0
Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel.
8 years ago
ba2fb83d60
Frontend: Check for more required OpenGL extensions during startup.
8 years ago
0b1c2e5505
Implement exclusive monitor
8 years ago
0797657bc0
gl_shader_decompiler: Remove redundant Subroutine construction in AddSubroutine()
We don't need to toss away the Subroutine instance after the find() call
and reconstruct another instance with the same data right after it.
Particularly give Subroutine contains a std::set.
8 years ago
148a5bef7e
shader_bytecode: Implement other TEXS masks.
8 years ago
0081252d31
vfs: Correct file_p variable usage within InterpretAsDirectory()
ReplaceFileWithSubdirectory() takes a VirtualFile and a VirtualDir, but
it was being passed a string as one of its arguments. The only reason
this never caused issues is because this template isn't instantiated
anywhere yet.
This corrects an issue before it occurs.
8 years ago
398444e676
file_util, vfs: Use std::string_view where applicable
Avoids unnecessary construction of std::string instances where
applicable.
8 years ago
f5a2944ab6
gl_shader_decompiler: Remove unused state tracking and minor cleanup.
8 years ago
c43eaa94f3
gl_shader_decompiler: Implement SEL instruction.
8 years ago
c5de0a67a8
file_util: Remove goto usages from Copy()
We can just leverage std::unique_ptr to automatically close these for us
in error cases instead of jumping to the end of the function to call
fclose on them.
8 years ago
Lioncash