af2698dcea
hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads
Previously, the buffer_index parameter was unused, causing all writes to
use the buffer index of zero, which is not necessarily what is wanted
all the time.
Thankfully, all current usages don't use a buffer index other than zero,
so this just prevents a bug before it has a chance to spring.
8 years ago
6c1ba02e0c
fsp_srv: Remove unnecessary vector construction in IFile's Write() function
We can avoid constructing a std::vector here by simply passing a pointer
to the original data and the size of the copy we wish to perform to the
backend's Write() function instead, avoiding copying the data where it's
otherwise not needed.
8 years ago
3e9b79e088
fsp_srv: Remove unnecessary std::vector construction in IDirectory's Read() function
We were using a second std::vector as a buffer to convert another
std::vector's data into a byte sequence, however we can just use
pointers to the original data and use them directly with WriteBuffer,
which avoids copying the data at all into a separate std::vector.
We simply cast the pointers to u8* (which is allowed by the standard,
given std::uint8_t is an alias for unsigned char on platforms that we
support).
8 years ago
758c357868
Merge pull request #699 from lioncash/vfs
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
8 years ago
87053fb3b8
Merge pull request #697 from bunnei/disable-depth-cull
gl_state: Temporarily disable culling and depth test.
8 years ago
5da4c78c6a
filesystem: std::move VirtualDir instance in VfsDirectoryServiceWrapper's constructor
Avoids unnecessary atomic reference count incrementing and decrementing
8 years ago
abbf038191
filesystem: Use std::string's empty() function instead of comparing against a literal
This is simply a basic value check as opposed to potentially doing
string based operations (unlikely, but still, avoiding it is free).
8 years ago
2cc0ef83cf
filesystem: Remove pragma disabling global optimizations
This was just an artifact missed during PR review.
8 years ago
f317080f40
fsp_srv: Make IStorage constructor explicit
Prevents implicit conversions.
8 years ago
910ad2e110
fsp_srv: Add missing includes
Gets rid of relying on indirect inclusions.
8 years ago
6be342118a
fsp_srv: Resolve sign-mismatch warnings in assertion comparisons
8 years ago
d6e9b96e2f
fsp_srv: Respect write length in Write()
Previously we were just copying the data whole-sale, even if the length
was less than the total data size. This effectively makes the
actual_data vector useless, which is likely not intended.
Instead, amend this to only copy the given length amount of data.
At the same time, we can avoid zeroing out the data before using it by
passing iterators to the constructor instead of a size.
8 years ago
5c47ea1a4e
common/swap: Remove unnecessary const on return value of swap()
8 years ago
0a868641fa
common/swap: Use static_cast where applicable
8 years ago
1edf4dd7ef
common/swap: Use using aliases where applicable
8 years ago
9128271292
common/common_funcs: Remove unused rotation functions
These are unused and essentially don't provide much benefit either. If
we ever need rotation functions, these can be introduced in a way that
they don't sit in a common_* header and require a bunch of ifdefing to
simply be available
8 years ago
e0b8a35937
common/misc: Deduplicate code in GetLastErrorMsg()
Android and macOS have supported thread_local for quite a while, but
most importantly is that we don't even really need it. Instead of using
a thread-local buffer, we can just return a non-static buffer as a
std::string, avoiding the need for that quality entirely.
8 years ago
ef03d0178a
externals: Update Xbyak to 5.65
Keeps the JIT assembler library up to date and ensures we don't run into
any issues that may have been resolved.
8 years ago
25f997097d
externals: Update catch to v2.2.3
Keeps the unit-testing library up to date.
8 years ago
63e64f0131
file_util: return string by const reference for GetExeDirectory()
This disallows modifying the internal string buffer (which shouldn't be
modified anyhow).
8 years ago
cd4fca8447
Merge pull request #700 from bunnei/update-dynarmic
externals: Update dynarmic to 5a91c94.
8 years ago
33fbcb45a7
string_util: Remove AsciiToHex()
Easy TODO
8 years ago
368e1d25be
Merge pull request #692 from lioncash/assign
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
8 years ago
85421f3406
Merge pull request #690 from lioncash/move
core/memory, core/hle/kernel: Use std::move where applicable
8 years ago
88ba94e8a2
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
This function doesn't alter class state.
8 years ago
9abc5763b6
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
8 years ago
cf30c4be22
gl_state: Temporarily disable culling and depth test.
8 years ago
4790bb907d
content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
8 years ago
87a9bb392b
content_archive: Add missing standard includes
8 years ago
522bd5b736
externals: Update dynarmic to 5a91c94.
8 years ago
0b566f43a1
content_archive: std::move VirtualFile in NCA's constructor
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
8 years ago
5e626c774f
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
We can just use a generic lambda to avoid writing the same thing twice.
8 years ago
1371e2fb6a
Merge pull request #691 from lioncash/guard
service/prepo: Add missing header guard
8 years ago
b10905c8ae
Merge pull request #686 from lioncash/fmt
externals: update fmt to version 5.1.0
8 years ago
55ab369043
loader/nro: Resolve sign mismatch warnings
8 years ago
1831b5ef62
loader/nso: Remove unnecessary vector resizes
We can just initialize these vectors directly via their constructor.
8 years ago
e3a30ccc7c
loader/nso: Resolve sign mismatch warnings
8 years ago
90ce935f3d
Merge pull request #688 from lioncash/comma
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
8 years ago
3f93279047
Merge pull request #693 from lioncash/unused
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
8 years ago
49b0966003
Merge pull request #687 from lioncash/instance
core: Don't construct instance of Core::System, just to access its live instance
8 years ago
89f0acfd36
Merge pull request #680 from bunnei/fix-swizz
decoders: Fix calc of swizzle image_width_in_gobs.
8 years ago
d883d3b64f
Merge pull request #685 from lioncash/build
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
8 years ago
2975f7820e
Merge pull request #684 from lioncash/nonmember
game_list: Make ContainsAllWords an internally linked non-member function
8 years ago
b496a9eefe
decoders: Fix calc of swizzle image_width_in_gobs.
8 years ago
29aff8d5ab
Virtual Filesystem 2: Electric Boogaloo ( #676 )
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
8 years ago
72207577b2
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
8 years ago
2cd3141c30
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
This was introduced within 4f81bc4e1b
8 years ago
296e68fd43
service/prepo: Add missing header guard
8 years ago
93cba6f699
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
Without these, this would perform concatenation, which is definitely not
what we want here.
8 years ago
46458e7284
core/memory, core/hle/kernel: Use std::move where applicable
Avoids pointless copies
8 years ago
Lioncash