0081252d31
vfs: Correct file_p variable usage within InterpretAsDirectory()
ReplaceFileWithSubdirectory() takes a VirtualFile and a VirtualDir, but
it was being passed a string as one of its arguments. The only reason
this never caused issues is because this template isn't instantiated
anywhere yet.
This corrects an issue before it occurs.
8 years ago
398444e676
file_util, vfs: Use std::string_view where applicable
Avoids unnecessary construction of std::string instances where
applicable.
8 years ago
0ba7fe4ab1
file_util: Use a u64 to represent number of entries
This avoids a truncating cast on size. I doubt we'd ever traverse a
directory this large, however we also shouldn't truncate sizes away.
8 years ago
459e158340
file_sys/errors: Remove redundant object constructor calls
Given we're already constructing the error code, we don't need to call
the constructor inside of it.
8 years ago
b46c0ed1fa
vfs_real: Remove redundant copying of std::vector instances in GetFiles() and GetSubdirectories()
We already return by value, so we don't explicitly need to make the
copy.
8 years ago
ec71915ede
partition_filesystem, vfs_real: Add missing standard includes
8 years ago
d36e327ba6
partition_filesystem, vfs_real: Use std::move in ReplaceFileWithSubdirectory() where applicable
Avoids unnecessary atomic increment and decrement operations.
8 years ago
2b91386e15
partition_filesystem, vfs_real: Use std::distance() instead of subtraction
This is a little bit more self-documenting on what is being done here.
8 years ago
3e0727df1b
vfs_offset: Simplify TrimToFit()
We can simply use std::clamp() here, instead of using an equivalent
with std::max() and std::min().
8 years ago
894b0de0f2
vfs: Make WriteBytes() overload taking a std::vector pass the std::vector by const reference
Given the data is intended to be directly written, there's no need to
take the std::vector by value and copy the data.
8 years ago
dd09439fee
vfs: Use variable template variants of std::is_trivially_copyable
Provides the same behavior, but with less writing
8 years ago
05231d8b08
vfs: Amend constness on pointers in WriteBytes() and WriteArrays() member functions to be const qualified
These functions don't modify the data being pointed to, so these can be
pointers to const data
8 years ago
0e9d58e82a
vfs_offset: std::move file and name parameters of OffsetVfsFile
Avoids potentially unnecessary atomic reference count incrementing and
decrementing, as well as string copying.
8 years ago
bbd6429ecb
partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()
This should be returned here, otherwise pfs_dirs is effectively only
ever added to, but never read.
8 years ago
88ba94e8a2
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
This function doesn't alter class state.
8 years ago
9abc5763b6
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
8 years ago
4790bb907d
content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
8 years ago
87a9bb392b
content_archive: Add missing standard includes
8 years ago
0b566f43a1
content_archive: std::move VirtualFile in NCA's constructor
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
8 years ago
5e626c774f
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
We can just use a generic lambda to avoid writing the same thing twice.
8 years ago
29aff8d5ab
Virtual Filesystem 2: Electric Boogaloo ( #676 )
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
8 years ago
69bfe075b5
General Filesystem and Save Data Fixes ( #670 )
8 years ago
7e5e4f8d7a
FileSys: Append the requested path to the filesystem base path in DeleteFile.
We were trying to delete things in the current directory instead of the actual filesystem directory. This may fix some savedata issues in some games.
8 years ago
eb6cbfdbd8
savedata_factory: Always create a save directory for games.
8 years ago
913896cbd9
Revert "Virtual Filesystem ( #597 )"
This reverts commit 77c684c114
8 years ago
77c684c114
Virtual Filesystem ( #597 )
* Add VfsFile and VfsDirectory classes
* Finish abstract Vfs classes
* Implement RealVfsFile (computer fs backend)
* Finish RealVfsFile and RealVfsDirectory
* Finished OffsetVfsFile
* More changes
* Fix import paths
* Major refactor
* Remove double const
* Use experimental/filesystem or filesystem depending on compiler
* Port partition_filesystem
* More changes
* More Overhaul
* FSP_SRV fixes
* Fixes and testing
* Try to get filesystem to compile
* Filesystem on linux
* Remove std::filesystem and document/test
* Compile fixes
* Missing include
* Bug fixes
* Fixes
* Rename v_file and v_dir
* clang-format fix
* Rename NGLOG_* to LOG_*
* Most review changes
* Fix TODO
* Guess 'main' to be Directory by filename
8 years ago
0d46f0df12
Update clang format
8 years ago
638956aa81
Rename logging macro back to LOG_*
8 years ago
63f26d5c40
Add support for decrypted NCA files ( #567 )
* Start to add NCA support in loader
* More nca stuff
* More changes to nca.cpp
* Now identifies decrypted NCA cont.
* Game list fixes and more structs and stuff
* More updates to Nca class
* Now reads ExeFs (i think)
* ACTUALLY LOADS EXEFS!
* RomFS loads and games execute
* Cleanup and Finalize
* plumbing, cleanup and testing
* fix some things that i didnt think of before
* Preliminary Review Changes
* Review changes for bunnei and subv
8 years ago
a3d82ef5d9
Build: Fixed some MSVC warnings in various parts of the code.
8 years ago
5f57a70a7d
Services/FS: Return the correct error code when trying to mount a nonexistent savedata.
8 years ago
7c9644646f
general: Make formatting of logged hex values more straightforward
This makes the formatting expectations more obvious (e.g. any zero padding specified
is padding that's entirely dedicated to the value being printed, not any pretty-printing
that also gets tacked on).
8 years ago
3f78a61f09
file-sys: convert a StringFromFormat call into fmt::format in GetFullPath()
Lessens the amount to read and gets rid of the PRIX64 macro, allowing us to use a single string
for the whole path, making it easier to read.
8 years ago
5aafc83cc9
file-sys: Move logging macros over to the new fmt-capable ones
8 years ago
a0179e5ca5
Service/FS: implement IFileSystem::RenameFile
8 years ago
80982748c8
disk_filesystem: Remove unused total_entries_in_directory member from Disk_Directory
8 years ago
e61a4dd485
disk_filesystem: Remove redundant initializer in Disk_Directory's constructor
8 years ago
b05f8ea5b5
disk_filesystem: Make constructors explicit where applicable
8 years ago
de580ccdd5
file_sys: Use NGLOG
8 years ago
83aa38b239
file_sys: tweaks
8 years ago
c03795300a
file_sys: Add HFS/PFS helper component
8 years ago
bddad50dd4
fsp_srv: Implement DeleteFile.
- Used by Binding of Isaac.
8 years ago
88582b84a5
fsp_srv: Implement GetSize and SetSize.
8 years ago
4c06d55a81
FS: Move the file open mode calculation to a separate function.
8 years ago
eff3f60b73
FS: Implemented IFileSystem::CreateDirectory.
8 years ago
6d90d99d12
FS: Implement DiskFileSystem's OpenDirectory interface.
8 years ago
e1d7b9fc2c
FS: Implement DiskFileSystem::GetEntryType for existing files/directories.
8 years ago
a9ba2c2000
FS: Updated the Directory Entry structure to match the Switch.
8 years ago
fc44261dd1
FS: Support the file Append open mode.
8 years ago
c4ca802b9d
FS: Added an SDMC archive factory and registered it to the SDMC archive on startup.
8 years ago
Lioncash