Lioncash
54ff822f66
XCI: Add function for checking the existence of the program NCA
The only reason the getter existed was to check whether or not the
program NCA was null. Instead, we can just provide a function to query
for the existence of it, instead of exposing it entirely.
7 years ago
Lioncash
d91cd1d638
card_image: Ensure program_nca_status is always initialized
If any of the error paths before the NCA retrieval are taken, it'll
result in program_nca_status being left in an inconsistent state. So we
initialize it by default with a value indicating an error.
7 years ago
fearlessTobi
1190ea6ddb
Port #4182 from Citra: "Prefix all size_t with std::"
7 years ago
Zach Hilman
4148e4fbba
nsp: Fix error masking issue with XCI files
Now display correct error instead of catch-all MissingProgramNCA
7 years ago
Zach Hilman
a67309aa0e
card_image: Add program title ID getter
7 years ago
Zach Hilman
887ffb2512
nsp: Comply with style and performance guidelines
7 years ago
Zach Hilman
57769f8d0d
card_image: Parse XCI secure partition with NSP
Eliminated duplicate code and adds support for Rev1+ carts
7 years ago
Lioncash
a9f4e31cc0
file_sys: Replace includes with forward declarations where applicable
Cuts down on include dependencies, resulting in less files that need to
be rebuilt when certain things are changed.
7 years ago
Zach Hilman
7e04e10f4d
xci: Ignore NCA files with updates in secure
7 years ago
Zach Hilman
1c1491a1cf
xci: Fix error masking issue
Prevents NCA-related errors from being masked into MissingProgramNCA or MissingKeyFile
7 years ago
Lioncash
aaed702790
loader: Make ResultStatus directly compatible with fmt
We can make the enum class type compatible with fmt by providing an
overload of operator<<.
While we're at it, perform proper bounds checking. If something exceeds
the array, it should be a hard fail, because it's, without a doubt, a
programmer error in this case.
7 years ago
Lioncash
91c673cac7
card_image: Use type aliases to shorten definitions
We have the aliases, so we may as well use 'em.
7 years ago
Lioncash
d323d72fd5
card_image: Simplify return statement of GetSubdirectories()
We don't need to write out the construction long-form, we can just let
the language itself work it out off the return type.
7 years ago
Zach Hilman
f903b556d8
card_image: Add accessor for all NCAs in XCI
7 years ago
Zach Hilman
da921ac3f3
loader: Add more descriptive errors
Full list of new errors and descriptions in core/loader/loader.h
7 years ago
Zach Hilman
d53b3a13b3
loader: Add icon and title support to XCI
7 years ago
Zach Hilman
f93e75f496
Use ErrorEncrypted where applicable and fix no keys crash
8 years ago
Zach Hilman
568ce6304c
Add missing includes and use const where applicable
8 years ago
Zach Hilman
272ca87298
Make XCI comply to review and style guidelines
8 years ago
Zach Hilman
b10c0d291f
Remove files that are not used
8 years ago