bunnei
2ad085e283
Merge pull request #2340 from lioncash/view
file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash
7 years ago
bunnei
21b4a904f4
Merge pull request #2334 from lioncash/override
core: Add missing override specifiers where applicable
7 years ago
bunnei
5df7110b7d
Merge pull request #2347 from lioncash/trunc
video_core/gpu_thread: Silence truncation warning in ThreadManager's constructor
7 years ago
bunnei
980c16b58f
Merge pull request #2341 from lioncash/compare
file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType
7 years ago
bunnei
41cc5be7b8
Merge pull request #2339 from lioncash/rank
service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs
7 years ago
bunnei
a7baa128a4
Merge pull request #2327 from ReinUsesLisp/crash-safe-visit
gl_shader_decompiler: Return early when an operation is invalid
7 years ago
bunnei
f8e61f4754
Merge pull request #2343 from lioncash/todo
file_sys/program_metadata: Remove obsolete TODOs
7 years ago
bunnei
930492964e
Merge pull request #2337 from lioncash/temporary
gl_shader_decompiler: Rename GenerateTemporal() to GenerateTemporary()
7 years ago
bunnei
7d633809d6
Merge pull request #2329 from lioncash/sanitize
kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic
7 years ago
bunnei
4d0f125786
Merge pull request #2344 from lioncash/result
hle/result: Remove unnecessary bitfield entry for ResultCode
7 years ago
bunnei
51617f4a65
Merge pull request #2349 from lioncash/surface
yuzu/debugger/graphics/graphics_surface: General cleanup
7 years ago
bunnei
8dfe3bee44
Merge pull request #2351 from lioncash/macro
video_core/macro_interpreter: Simplify GetRegister()
7 years ago
Lioncash
a812485b94
video_core/macro_interpreter: Remove assertion within FetchParameter()
We can just use .at(), which essentially does the same thing, but with
less code.
7 years ago
Lioncash
d2143cb59c
video_core/macro_interpreter: Simplify GetRegister()
Given we already ensure nothing can set the zeroth register in
SetRegister(), we don't need to check if the index is zero and special
case it. We can just access the register normally, since it's already
going to be zero.
We can also replace the assertion with .at() to perform the equivalent
behavior inline as part of the API.
7 years ago
Lioncash
69846b1557
video_core/memory_manager: Make Read() a const qualified member function
Given this doesn't actually alter internal state, this can be made a
const member function.
7 years ago
Lioncash
e36500c07f
video_core/memory_manager: Make ReadBlock() a const qualifier member function
Now, since we have a const qualified variant of GetPointer(), we can put
it to use in ReadBlock() to retrieve the source pointer that is passed
into memcpy.
Now block reading may be done from a const context.
7 years ago
Lioncash
514351af96
video_core/memory_manager: Add a const qualified variant of GetPointer()
Allows retrieving read-only pointers from a const context externally.
7 years ago
Lioncash
72e8ac8e4e
video_core/memory_manager: Make FindFreeRegion() a const member function
This doesn't modify internal state, so it can be made a const member
function.
7 years ago
Lioncash
ad244b004b
video_core/memory_manager: Make GpuToCpuAddress() a const member function
This doesn't modify any internal state, so it can be made a const member
function to allow its use in const contexts.
7 years ago
Lioncash
c289629f97
yuzu/debugger/graphics_surface: Display error messages for file I/O errors
7 years ago
Lioncash
64e191b2b8
yuzu/debugger/graphics_surface: Tidy up SaveSurface
- Use QStringLiteral where applicable.
- Use const where applicable
- Remove unnecessary precondition check (we already assert the pixbuf
being non null)
7 years ago
Lioncash
5e69f8fc32
yuzu/debugger/graphics_surface: Clean up connection overload deduction
We can utilize qOverload with the signal connections to make the
function deducing a little less ugly.
7 years ago
Fernando Sahmkow
e3d9c983aa
Implement SyncPoint Register in the GPU.
7 years ago
Lioncash
af6c9a2993
yuzu/debugger/graphics_surface: Fill in missing surface format listings
Fills in the missing surface types that were marked as unknown. The
order corresponds with the TextureFormat enum within
video_core/texture.h.
We also don't need to all of these strings as translatable (only the
first string, as it's an English word).
7 years ago
Lioncash
2afbfc88f2
video_core/gpu_thread: Silence truncation warning in ThreadManager's constructor
Since 7739479e15 callback parameters were
changed to use an s64 to represent late cycles instead of an int, so
this was causing a truncation warning to occur here. Changing it to s64
is sufficient to silence the warning.
7 years ago
Lioncash
1211a5623e
video_core/engines: Make memory manager members private
These aren't used externally by anything, so they can be made private
data members.
7 years ago
Lioncash
33742deaf6
video_core/engines: Remove unnecessary inclusions where applicable
Replaces header inclusions with forward declarations where applicable
and also removes unused headers within the cpp file. This reduces a few
more dependencies on core/memory.h
7 years ago
ReinUsesLisp
bce7a75a50
renderer_opengl/utils: Skip empty binds
7 years ago
ReinUsesLisp
5cea44b8c6
gl_rasterizer: Use ARB_multi_bind to update SSBOs
7 years ago
ReinUsesLisp
2cab690377
gl_rasterizer: Use ARB_multi_bind to update UBOs across stages
7 years ago
Lioncash
3910871dd8
hle/result: Remove unnecessary bitfield entry for ResultCode
This is a hold over from the 3DS error codes in Citra.
7 years ago
Lioncash
633d55d503
file_sys/program_metadata: Remove obsolete TODOs
BitField has been trivially copyable since
b20657a36f , so we can eliminate these
TODO comments and use ReadObject() directly instead of memcpying the
data.
7 years ago
Lioncash
f9eb4be37b
common/multi_level_queue: Silence truncation warning in iterator operator++
7 years ago
Lioncash
3b97777861
common/bit_util: Make CountLeading/CountTrailing functions have the same return types
Makes the return type consistently uniform (like the intrinsics we're
wrapping). This also conveniently silences a truncation warning within
the kernel multi_level_queue.
7 years ago
Lioncash
0359cba0f3
file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType
enum class elements from the same enum can already be compared against
one another without the need for explicitly defined comparison
operators.
7 years ago
Lioncash
d7f670204b
file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash()
The given string instance doesn't need to be copied entirely, we can
just use a view instead.
7 years ago
Lioncash
7d93ed3f70
service/fsp_srv: Don't pass SaveDataDescriptor instances by value.
Passing around a 64 byte data struct by value is kind of wasteful,
instead pass a reference to the struct.
7 years ago
Lioncash
7192c8703b
service/fsp_srv: Remove unnecessary unknown member in OpenSaveDataFileSystem
The unknown member here is actually padding due to being passed as a
struct. We can do the same, and remove the need to pop a padding word.
7 years ago
Lioncash
90abd76bd9
service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs
I realized that I updated the documentation on SwitchBrew a while ago,
but never actually updated the structs within yuzu.
7 years ago
bunnei
5c0f43b29b
Merge pull request #2338 from lioncash/fs
filesystem: Use a std::string_view in OpenFile()
7 years ago
bunnei
6e99d5146f
Merge pull request #2282 from bunnei/gpu-asynch-v2
gpu_thread: Improve synchronization by using CoreTiming.
7 years ago
bunnei
d85b454fdd
Merge pull request #2292 from lioncash/nacp
file_sys/control_metadata: Amend naming of members
7 years ago
bunnei
e905ecc331
Merge pull request #2335 from lioncash/service-unused
hle/service: Resolve unused variable warnings
7 years ago
bunnei
4891529e37
Merge pull request #2336 from ReinUsesLisp/txq
gl_shader_decompiler: Fix TXQ types
7 years ago
bunnei
1f66a2d439
Merge pull request #2331 from lioncash/cache
yuzu/main: Minor adjustments to OnTransferableShaderCacheOpenFile()
7 years ago
bunnei
805c888688
Merge pull request #2333 from lioncash/video-include
video_core/renderer_opengl: Remove unnecessary includes
7 years ago
bunnei
182c9793fc
Merge pull request #2332 from lioncash/include
yuzu/main: Remove unnecessary includes
7 years ago
Lioncash
f1694034e8
filesystem: Use a std::string_view in OpenFile()
Rather than make a full copy of the path, we can just use a string view
and truncate the viewed portion of the string instead of creating a totally
new truncated string.
7 years ago
Lioncash
eb491efd9f
gl_shader_decompiler: Rename GenerateTemporal() to GenerateTemporary()
Temporal generally indicates a relation to time, but this is just
creating a temporary, so this isn't really an accurate name for what the
function is actually doing.
7 years ago
ReinUsesLisp
3585fd3d64
gl_shader_decompiler: Fix TXQ types
TXQ returns integer types. Shaders usually do:
R0 = TXQ(); // => int
R0 = static_cast<float>(R0);
If we don't treat it as an integer, it will cast a binary float value as
float - resulting in a corrupted number.
7 years ago