f92bb43138
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
This function doesn't alter class state.
8 years ago
a9b596c444
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
8 years ago
9a4fa973c8
gl_state: Temporarily disable culling and depth test.
8 years ago
9eb43dc910
content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
8 years ago
701bdfd753
content_archive: Add missing standard includes
8 years ago
bff53f234d
content_archive: std::move VirtualFile in NCA's constructor
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
8 years ago
47858aed98
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
We can just use a generic lambda to avoid writing the same thing twice.
8 years ago
d0f53d27e0
loader/nro: Resolve sign mismatch warnings
8 years ago
b20bac710d
loader/nso: Remove unnecessary vector resizes
We can just initialize these vectors directly via their constructor.
8 years ago
0a48b45954
loader/nso: Resolve sign mismatch warnings
8 years ago
47a305ed54
decoders: Fix calc of swizzle image_width_in_gobs.
8 years ago
82150bd5c1
Virtual Filesystem 2: Electric Boogaloo ( #676 )
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
8 years ago
b7e7ddbdfc
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
8 years ago
76a9fc2f85
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
This was introduced within d12af72c8f
8 years ago
26e188d074
service/prepo: Add missing header guard
8 years ago
81bf614695
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
Without these, this would perform concatenation, which is definitely not
what we want here.
8 years ago
b1b1c60009
core/memory, core/hle/kernel: Use std::move where applicable
Avoids pointless copies
8 years ago
74185c108e
core: Make System's default constructor private
This makes it a compilation error to construct additional instances of
the System class directly, preventing accidental wasteful constructions
over and over.
8 years ago
e72928762f
core: Don't construct instance of Core::System, just to access its live instance
This would result in a lot of allocations and related object
construction, just to toss it all away immediately after the call.
These are definitely not intentional, and it was intended that all of
these should have been accessing the static function GetInstance()
through the name itself, not constructed instances.
8 years ago
d284e38814
externals: update fmt to version 5.1.0
Previously, we were on 4.1.0, which was a major version behind.
8 years ago
40096de1fc
hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode
Previously this wouldn't compile, since no such function named
SaveStructDebugInfo() exists.
8 years ago
2b547cda84
game_list: Make ContainsAllWords an internally linked non-member function
This function actually depends on no internal class state, so it doesn't
even need to be a part of the class interface.
8 years ago
03480ff436
Fill in more fields in TouchScreenEntryTouch
8 years ago
25becb080e
Single touch support
8 years ago
4fee2216fc
telemetry: Remove unnecessary Field constructor
We can just take the value parameter by value which allows both moving
into it, and copies at the same time, depending on the calling code.
8 years ago
2df4be6f25
telemetry: Make operator== and operator!= const member functions of Field
These operators don't modify internal class state, so they can be made
const member functions. While we're at it, drop the unnecessary inline
keywords. Member functions that are defined in the class declaration are
already inline by default.
8 years ago
c66555a28f
telemetry: Default copy/move constructors and assignment operators
This provides the equivalent behavior, but without as much boilerplate.
While we're at it, explicitly default the move constructor, since we
have a move-assignment operator defined.
8 years ago
80b03cb214
game_list: Upper-case containsAllWords to ContainsAllWords()
This makes it consistent with most of the other private utility
functions.
8 years ago
75eba5fdb9
game_list: Make containsAllWords a const member function
This doesn't actually modify the internal class state, so it can be a
const member function. While we're at it, amend the function to take
its arguments by const reference.
8 years ago
308205980e
game_list: Remove unnecessary QString initialization in KeyReleaseEater
QString initializes to an empty string by default, so this does nothing
meaningful. While we're at it, use a constructor initializer list for
initializing the gamelist member variable.
8 years ago
e0c31daa57
astc: Initialize vector size directly in Decompress
There's no need to perform a separate resize.
8 years ago
fa13cedc7a
astc: Mark functions as internally linked where applicable
8 years ago
03f1f17552
astc: const-correctness changes where applicable
A few member functions didn't actually modify class state, so these can
be amended as necessary.
8 years ago
62eb3b3ede
astc: Delete Bits' copy contstructor and assignment operator
This also potentially avoids warnings, considering the copy assignment
operator is supposed to have a return value.
8 years ago
6b32ef1d9e
astc: In-class initialize member variables where appropriate
8 years ago
6143bfd58a
settings: Turn docked mode off by default.
8 years ago
ad40c27409
vi: Change TransactionId::CancelBuffer to LOG_CRITICAL.
8 years ago
3ff59a95d5
vi: Fix size for ListDisplays default display.
8 years ago
42b866afc5
vi: Partially implement buffer crop parameters.
8 years ago
8335e656bb
GPU: Added register definitions for the stencil parameters.
8 years ago
753d85fb0c
General Filesystem and Save Data Fixes ( #670 )
8 years ago
df66fadc12
nvflinger: Fix for BufferQueue event handling.
8 years ago
045893374f
Kernel/Arbiter: Fix bug in WaitIfLessThan
8 years ago
bd97579188
scheduler: Clear exclusive state when switching contexts
8 years ago
12e7a3065a
HID: Update controllers less often
8 years ago
9e5bc967de
Logging: Dump all logs in the queue on close in debug mode
8 years ago
efc5bbb9ab
gl_rasterizer_cache: Implement texture format G8R8.
8 years ago
50037e0c4f
gl_rasterizer_cache: Fix incorrect offset in ConvertS8Z24ToZ24S8.
8 years ago
f5feb89c86
gl_rasterizer_cache: Implement depth format Z16_UNORM.
8 years ago
ada0d38ca9
Logging: Don't lock the queue for the duration of the write
8 years ago
Lioncash