4854f3291e
core: Silence Wclass-memaccess warnings
This requires making several types trivial and properly initialize
them whenever they are called.
5 years ago
92ca4929f5
common/common_funcs: Rename INSERT_UNION_PADDING_{BYTES,WORDS} to _NOINIT
INSERT_PADDING_BYTES_NOINIT is more descriptive of the underlying behavior.
5 years ago
d27f026a50
file_sys/registered_cache: Silence virtual functions without override warnings
5 years ago
64d9ef5e7a
core: Silence warnings when compiling without asserts
5 years ago
f36865a3f4
system_archive: Add + and - buttons to the Nintendo Extended OSS font
5 years ago
8cd0b60587
system_archive: Update Nintendo Extended OSS font
Co-authored-by: Its-Rei <kupfel@gmail.com>
5 years ago
9e47a3f7cd
Revert "Merge pull request #5176 from Morph1984/fix-createfile"
This reverts commit 586d5a72e11f5f5d8d3c
5 years ago
fd6a753646
vfs: Use existing type aliases consistently
Makes use of the VirtualDir and VirtualFile aliases across the board
instead of having a few isolated places that don't use it.
5 years ago
b8c2935580
vfs_real: Fix CreateFile for files without a file extension
5 years ago
419996f5db
fsp_srv: Implement OpenDataStorageWithProgramIndex
- Used by RollerCoaster Tycoon 3: Complete Edition
5 years ago
f30f97994b
file_sys: Consolidate common Title ID operations
5 years ago
8f135703dc
core: Remove unnecessary enum casts in log calls
Follows the video core PR. fmt doesn't require casts for enum classes
anymore, so we can remove quite a few casts.
5 years ago
5db4785535
video_core: Resolve more variable shadowing scenarios pt.3
Cleans out the rest of the occurrences of variable shadowing and makes
any further occurrences of shadowing compiler errors.
5 years ago
6d887d0d92
system_version: Update to 11.0.0
5 years ago
acf893542a
savedata_factory: Eliminate usage of the global system instance
Now there's only two meaningful instances left in core.
5 years ago
9f8d7748d9
core: loader: Implement support for loading indexed programs.
5 years ago
b4b63c878f
patch_manager: Remove usages of the global system instance
With this, only 19 usages of the global system instance remain within
the core library.
We're almost there.
5 years ago
deb3536936
Revert "core: Fix clang build"
5 years ago
18636013c9
core: Fix clang build
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.
Fixes #4795
6 years ago
16de0a6a96
core/CMakeLists: Make some warnings errors
Makes our error coverage a little more consistent across the board by
applying it to Linux side of things as well. This also makes it more
consistent with the warning settings in other libraries in the project.
This also updates httplib to 0.7.9, as there are several warning
cleanups made that allow us to enable several warnings as errors.
6 years ago
58f0798f1f
submission_package: Fix updates integrated into cartridge images.
6 years ago
e457001dce
General: Make use of std::nullopt where applicable
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.
This also makes it consistent how we return empty optionals.
6 years ago
485eec243d
ips_layer: Eliminate a redundant copy in Parse()
Prevents unnecessary copying of the line being parsed.
6 years ago
0b72422a10
submission_package: Account for multi-content NSPs
Previously we assumed a submission package can only contain one Program NCA with a single TitleID.
However, Super Mario 3D All-Stars contains four Program NCAs, each with their unique TitleIDs.
This accounts for the existence of multi-content games such as this one.
- Fixes booting Super Mario 3D All-Stars from the games list.
6 years ago
43a09c9bfc
control_metadata: Resolve typo in Portuguese language name
This isn't used anywhere, so this is a trivial fix.
6 years ago
7824da5961
file_sys/romfs_factory: Eliminate usage of the global system accessor
6 years ago
e45b727db5
file_sys/bis_factory: Eliminate usage of the global system accessor
6 years ago
80e57658ac
nca_patch: Significantly reduce the stack usage size within SearchBucketEntry()
Previously this function was using ~16KB of stack (16528 bytes), which
was caused by the function arguments being taken by value rather than by
reference.
We can make this significantly lighter on the stack by taking them by
reference.
6 years ago
a92c6ddd22
nca_patch: Make SearchBucketEntry() internally linked
This is only used internally and doesn't depend on any class state, so
we can make it fully internal.
6 years ago
6711031e7d
cheat_engine: Remove unnecessary system argument to CheatParser's Parse function
This isn't used within the function at all in any implementations, so we
can remove it entirely.
6 years ago
5c77fffc80
patch_manager: Resolve implicit truncations in FormatTitleVersion()
We make it explicit that we're truncating arithmetic here to resolve
compiler warnings (even if the sizes weren't u32/u64 arithmetic
generally promotes to int :<)
6 years ago
7abb47303e
patch_manager: Make use of type aliases
We can use these to avoid typing the same type redundantly. This way, if
these ever change, only a single location needs to be modified.
6 years ago
e8092e4099
patch_manager: Make a few functions internally linked
These functions are only used within this translation unit, so we can
make them internally linked.
6 years ago
5bccefe24c
file_sys/patch_manager: Add missing include
Fixes build issues
6 years ago
da15e9f8a7
file_sys: Replace inclusions with forward declarations where applicable
Same behavior, minus unnecessary inclusions where not necessary.
6 years ago
942badd1e7
registered_cache: Make use of ends_with for string suffix checking
Simplifies code.
6 years ago
a185b6cf21
registered_cache: Make use of designated initializers
Removes the need for comments to indicate the fields being assigned.
6 years ago
d9fc3abc1f
vfs_real: Resolve sign conversion warnings
6 years ago
182739ce1b
vfs_real: Avoid redundant map lookups
Avoids some trivially avoidable map lookups by keeping the result of
find operations around and querying them.
6 years ago
a87209e09d
common/fileutil: Convert namespace to Common::FS
Migrates a remaining common file over to the Common namespace, making it
consistent with the rest of common files.
This also allows for high-traffic FS related code to alias the
filesystem function namespace as
namespace FS = Common::FS;
for more concise typing.
6 years ago
78ddcbe3ba
General: Tidy up clang-format warnings part 2
6 years ago
42c79b8507
vfs_vector: Make creation of array vfs files less verbose
We can add a helper function to make creation of these files nicer.
While we're at it, we can eliminate an unnecessary std::array copy in
the constructor. This makes the overhead on some of these functions way
less intensive, given some arrays were quite large.
e.g. The timezone location names are 9633 bytes in size.
6 years ago
c28e7f51f3
aes_util: Allow SetIV to be non-allocating
In a few places, the data to be set as the IV is already within an array.
We shouldn't require this data to be heap-allocated if it doesn't need
to be. This allows certain callers to reduce heap churn.
6 years ago
607a02edda
time_zone_binary: Make use of designated initializers
6 years ago
2fa750dd6b
file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode
Same behavior, minus a hand-rolled operator.
6 years ago
39ac833461
patch_manager: Resolve -Wignored-qualifier warnings
Top level const will always be ignored in this case, so it can be
removed.
6 years ago
872200c7a9
registered_cache: Resolve -Wmaybe_uninitialized warnings
While we're at it, we can avoid a redundant map lookup.
6 years ago
06adef078c
fs: Rename SaveDataDescriptor to SaveDataAttribute
6 years ago
4a6d4ab839
xts_archive: Check if the file is nullptr prior to parsing
Fixes an access violation where the file no longer exists at the specified path while being parsed.
6 years ago
0724e89467
registered_cache: Add support for removing folder ncas
6 years ago
ReinUsesLisp