Zach Hilman
b77fde7c5c
loader: Move NSO module tracking to AppLoader
Also cleanup of general stuff
7 years ago
ReinUsesLisp
37eaf39b44
emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy
There's no performance improvement in passing an unsigned pair by
reference.
7 years ago
Zach Hilman
6f0ee45b5c
qt: Make UI option for 'Reporting Services' temporary
Reports are unnecessary for normal users and this is to prevent 'power' users from enabling the feature by accident.
7 years ago
Zach Hilman
658d2ee97d
settings: Add 'Reporting Services' config option
Full enable/disable for all reports.
7 years ago
Lioncash
88cd5e888e
configure_hotkeys: Remove unnecessary Settings::Apply() call
Nothing from the hotkeys dialog relies on this call occurring, and is
already called from the dialog that calls applyConfiguration().
7 years ago
Lioncash
6640f631e2
configure_hotkeys: Tidy up key sequence conflict error string
Avoids mentioning the user and formalizes the error itself.
7 years ago
Lioncash
d61199721d
configure_hotkeys: Change critical error dialog into a warning dialog
critical() is intended for critical/fatal errors that threaten the
overall stability of an application. A user entering a conflicting key
sequence is neither of those.
7 years ago
Lioncash
ef3c0f54d0
configure_hotkeys: Move conflict detection logic to IsUsedKey()
We don't need to extract the entire set of hotkeys into a list and then
iterate through it. We can traverse the list and early-exit if we're
able to.
7 years ago
Lioncash
c03fb00ac1
configure_hotkeys: Remove unused EmitHotkeysChanged()
1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal.
7 years ago
Lioncash
5d645c6dd9
sequence_dialog: Reorganize the constructor
The previous code was all "smushed" together wasn't really grouped
together that well.
This spaces things out and separates them by relation to one another,
making it easier to visually parse the individual sections of code that
make up the constructor.
7 years ago
Lioncash
9218e347cd
sequence_dialog: Remove unnecessary horizontal specifier
QDialogButtonBoxes are horizontal by default.
7 years ago
Lioncash
d623e38d18
yuzu/configuration/configure_graphics: Eliminate type narrowing in a connect call
A checkbox is able to be tri-state, giving it three possible activity
types, so in the connect call here, it would actually be truncating an
int into a bool.
Instead, we can just listen on the toggled() signal, which passes along
a bool, not an int.
7 years ago
Lioncash
3c0280cf66
yuzu/CMakeLists: Disable implicit QString conversions
Now that all of our code is compilable with implicit QString
conversions, we can enforce it at compile-time by disabling them.
7 years ago
Lioncash
bb06b98d81
yuzu/applets/software_keyboard: Remove unused assert header
This isn't actually used anywhere, so it can be removed.
7 years ago
Lioncash
16bf791939
yuzu/applets/software_keyboard: std::move argument in MainWindowFinishedText()
Given the std::optional can contain an object type that heap allocates,
we can use std::move to avoid an unnecessary copy/allocation from
occurring.
7 years ago
Lioncash
b3d7180164
yuzu/applets/software_keyboard: Resolve sign mismatch comparison
Qt uses a signed value to represent container sizes, so this was causing
a sign mismatch warning.
7 years ago
Lioncash
cf9cc41478
yuzu/applets/software_keyboard: Specify string conversions explicitly
Allows the software keyboard applet code to compile with implicit string
conversions disabled.
7 years ago
Lioncash
f5d416e071
yuzu/applets/error: Specify string conversions explicitly
Allows the error applet to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
6f2a8fbb13
yuzu/main: Specify string conversions where applicable
7 years ago
ReinUsesLisp
c03b8c4c19
gl_shader_cache: Use shared contexts to build shaders in parallel
7 years ago
Lioncash
f49a04ba39
yuzu/configuration/config: Make default hotkeys an internally-linked array in the cpp file
Given the array is a private static array, we can just make it
internally linked to hide it from external code. This also allows us to
remove an inclusion within the header.
7 years ago
Lioncash
938d6dca30
yuzu/configuration/config: Specify string conversions explicitly
Allows the configuration code to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
bc32474901
yuzu/game_list: Specify string conversions explicitly
Allows the game list code to compile successfully with implicit string
conversions disabled.
7 years ago
Lioncash
ed2fedac13
yuzu/game_list_worker: Specify string conversions explicitly
Allows the game list worker code to compile successfully with implicit
string conversions disabled.
7 years ago
Lioncash
7a82d6f394
yuzu/game_list_p: Amend mentions of SMDH in comments
SMDH is a metadata format used in some executable formats for the
Nintendo 3DS. Switch executables don't utilize this metadata format, so
this just a holdover from Citra and can be corrected.
7 years ago
Lioncash
486c3e6085
yuzu/game_list_p: Specify string conversions explicitly
Allows the game list item code to build with implicit string conversions
disabled.
7 years ago
Lioncash
922d8c6cb4
yuzu/loading_screen: Specify string conversions explicitly
Allows the loading screen code to compile with implicit string
conversions disabled.
While we're at it remove unnecessary const usages, and add it to nearby
variables where appropriate.
7 years ago
Lioncash
fd34732e26
yuzu/bootmanager: Specify string conversions explicitly
Allows the bootmanager code to compile with implicit string conversions
disabled.
7 years ago
Lioncash
317f1263fb
yuzu/util: Specify string conversions explicitly
Allows the util code to build with implicit string conversions disabled.
7 years ago
Lioncash
2318c394a8
yuzu/configuration/configure_web: Specify string conversions explicitly
Allows the web config code to compile with implicit string conversions
disabled. We can also deduplicate the calls to create the pixmap.
7 years ago
Lioncash
d9c4d64ed5
yuzu/configuration/configure_system: Specify string conversions explicitly
Allows the system config code to build successfully with implicit string
conversions disabled.
7 years ago
Lioncash
428d8098a7
yuzu/configuration/configure_profile_manager: Mark UI string as translatable
This is a user-facing string, so it should be marked as translatable.
7 years ago
Lioncash
17255cd835
yuzu/configuration/configure_per_general: Specify string conversions explicitly
Allows the per-game configuration to be successfully built with implicit
string conversions disabled.
7 years ago
Lioncash
3039211c20
yuzu/configuration/configure_mouse_advanced: Clean up array accesses
Deduplicates array accesses and uses a named variable where appropriate.
7 years ago
Lioncash
c9c4208c4a
yuzu/configuration/configure_mouse_advanced: Specify string conversions explicitly
Allows the advanced mouse configuration code to build with implicit
string conversions disabled.
7 years ago
Lioncash
aa83639b78
yuzu/configuration/configure_input_player: Clean up array accesses
Rather than repeatedly index arrays that have quite a large array index,
we can just use a named variable instead.
7 years ago
Lioncash
4d2da5a40a
yuzu/configuration/configure_input_player: Specify string conversions explicitly
Allows the player input configuration code to compile with implicit
string conversions disabled.
7 years ago
Lioncash
d81d4a0f68
yuzu/configuration/configure_input: Mark controller type names as translateable
These are user-facing strings, so they should be localizable.
7 years ago
Lioncash
7e650088dd
yuzu/configuration/configure_general: Specify string conversions explicitly
Allows the general configuration code to successfully compile with
implicit string conversions disabled.
7 years ago
Lioncash
05235ccaa9
yuzu/configuration/configure_gamelist: Specify string conversions explicitly
Allows the gamelist configuration code to compile with implicit string
conversions disabled.
7 years ago
Lioncash
5f01ec338e
yuzu/configuration/configure_audio: Store power on query into a variable
Avoids using the system accessor more than necessary, and ensures that
both dialog boxes see the same power on state.
7 years ago
Lioncash
d00ca5c6c8
yuzu/configuration/configure_audio: Tidy up function cast
We can just use qOverload here to tidy up the function cast.
7 years ago
Lioncash
d184224e8f
yuzu/configuration/configure_audio: Specify string conversions explicitly
Allows the audio configuration code to build with implicit string
conversions disabled.
7 years ago
Lioncash
bc6972caf9
yuzu/util: Remove unused spinbox.cpp/.h
This has been left unused since the removal of the vestigial surface
viewer. Given it has no uses left, this can be removed as well.
7 years ago
Lioncash
22324e3ef1
yuzu/applets/profile_select: Mark header string as translatable
This is a user-facing string, so it should be marked as translatable.
7 years ago
Lioncash
d77d1a0207
yuzu/debugger/graphics/graphics_breakpoints: Specify string conversions explicitly
Allows the graphics breakpoints to compile with implicit string
conversions disabled.
7 years ago
Lioncash
cad4f2ed29
yuzu/debugger/profiler: Specify string conversions explicitly
This allows the microprofile widget to compile with implicit string
conversions disabled.
7 years ago
Lioncash
a059b9eed4
yuzu/debugger/wait_tree: Specify string conversions explicitly
Allows compiling the wait tree widget with implicit string conversions
disabled.
7 years ago
Lioncash
a47aaa7f1b
core/kernel/object: Rename ResetType enum members
Renames the members to more accurately indicate what they signify.
"OneShot" and "Sticky" are kind of ambiguous identifiers for the reset
types, and can be kind of misleading. Automatic and Manual communicate
the kind of reset type in a clearer manner. Either the event is
automatically reset, or it isn't and must be manually cleared.
The "OneShot" and "Sticky" terminology is just a hold-over from Citra
where the kernel had a third type of event reset type known as "Pulse".
Given the Switch kernel only has two forms of event reset types, we
don't need to keep the old terminology around anymore.
7 years ago
ReinUsesLisp
4cf64f8e09
qt/configure_graphics: Shadow options at runtime
Compatibility profile and the disk shader cache settings shouldn't
be changed at runtime. This aims to address that shadowing those
options.
7 years ago