[common] remove nvidia driver hack using environment variables (#2575)

Ugly hack that helped boost FPS on OpenGL backend... or does it? https://download.nvidia.com/XFree86/Linux-x86_64/435.17/README/openglenvvariables.html
This shouldn't work on Windows properly, as it is meant to be a Linux only thing anyways... so?

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2575
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Reviewed-by: Shinmegumi <shinmegumi@eden-emu.dev>
Reviewed-by: crueter <crueter@eden-emu.dev>
Co-authored-by: lizzie <lizzie@eden-emu.dev>
Co-committed-by: lizzie <lizzie@eden-emu.dev>

src/common/CMakeLists.txt

@@ -97,8 +97,6 @@ add_library(
   memory_detect.h
   multi_level_page_table.cpp
   multi_level_page_table.h
-  nvidia_flags.cpp
-  nvidia_flags.h
   overflow.h
   page_table.cpp
   page_table.h

src/common/nvidia_flags.cpp

@@ -1,32 +0,0 @@
-// SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
-// SPDX-License-Identifier: GPL-2.0-or-later
-
-#include <cstdlib>
-
-#include <fmt/ranges.h>
-
-#include "common/fs/fs.h"
-#include "common/fs/path_util.h"
-#include "common/nvidia_flags.h"
-
-namespace Common {
-
-void ConfigureNvidiaEnvironmentFlags() {
-#ifdef _WIN32
-    const auto nvidia_shader_dir =
-        Common::FS::GetEdenPath(Common::FS::EdenPath::ShaderDir) / "nvidia";
-
-    if (!Common::FS::CreateDirs(nvidia_shader_dir)) {
-        return;
-    }
-
-    const auto windows_path_string =
-        Common::FS::PathToUTF8String(nvidia_shader_dir.lexically_normal());
-
-    void(_putenv(fmt::format("__GL_SHADER_DISK_CACHE_PATH={}", windows_path_string).c_str()));
-    void(_putenv("__GL_SHADER_DISK_CACHE_SKIP_CLEANUP=1"));
-    void(_putenv("__GL_THREADED_OPTIMIZATIONS=1"));
-#endif
-}
-
-} // namespace Common

src/common/nvidia_flags.h

@@ -1,11 +0,0 @@
-// SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
-// SPDX-License-Identifier: GPL-2.0-or-later
-
-#pragma once
-
-namespace Common {
-
-/// Configure platform specific flags for Nvidia's driver
-void ConfigureNvidiaEnvironmentFlags();
-
-} // namespace Common

src/yuzu/main.cpp

@@ -35,7 +35,6 @@
 #include "applets/qt_profile_select.h"
 #include "applets/qt_software_keyboard.h"
 #include "applets/qt_web_browser.h"
-#include "common/nvidia_flags.h"
 #include "common/settings_enums.h"
 #include "configuration/configure_input.h"
 #include "configuration/configure_per_game.h"
@@ -4917,7 +4916,6 @@ int main(int argc, char* argv[]) {
 #endif
 
     Common::DetachedTasks detached_tasks;
-    Common::ConfigureNvidiaEnvironmentFlags();
 
     // Init settings params
     QCoreApplication::setOrganizationName(QStringLiteral("eden"));

src/yuzu_cmd/yuzu.cpp

@@ -16,7 +16,6 @@
 #include "common/detached_tasks.h"
 #include "common/logging/backend.h"
 #include "common/logging/log.h"
-#include "common/nvidia_flags.h"
 #include "common/scm_rev.h"
 #include "common/scope_exit.h"
 #include "common/settings.h"
@@ -334,8 +333,6 @@ int main(int argc, char** argv) {
     LocalFree(argv_w);
 #endif
 
-    Common::ConfigureNvidiaEnvironmentFlags();
-
     if (filepath.empty()) {
         LOG_CRITICAL(Frontend, "Failed to load ROM: No ROM specified");
         return -1;