Browse Source

memory_hook: Default virtual destructor in the cpp file

Prevents creating multiple copies of the vtable in every translation unit that uses the class.
Also silences a -Wweak-vtables warning
nce_cpp
Lioncash 8 years ago
parent
commit
f9b42fa139
  1. 1
      src/core/CMakeLists.txt
  2. 11
      src/core/memory_hook.cpp
  3. 2
      src/core/memory_hook.h

1
src/core/CMakeLists.txt

@ -253,6 +253,7 @@ add_library(core STATIC
loader/nso.h
memory.cpp
memory.h
memory_hook.cpp
memory_hook.h
memory_setup.h
perf_stats.cpp

11
src/core/memory_hook.cpp

@ -0,0 +1,11 @@
// Copyright 2018 Citra Emulator Project
// Licensed under GPLv2 or any later version
// Refer to the license.txt file included.
#include "core/memory_hook.h"
namespace Memory {
MemoryHook::~MemoryHook() = default;
} // namespace Memory

2
src/core/memory_hook.h

@ -23,7 +23,7 @@ namespace Memory {
*/
class MemoryHook {
public:
virtual ~MemoryHook() = default;
virtual ~MemoryHook();
virtual boost::optional<bool> IsValidAddress(VAddr addr) = 0;

Loading…
Cancel
Save