From f6b37afd18e7465f59eee19cdb25c64d2725f7bc Mon Sep 17 00:00:00 2001 From: xbzk Date: Sat, 21 Feb 2026 14:27:11 +0100 Subject: [PATCH] Update src/dynarmic/src/dynarmic/common/assert.h NOISY warning on NINJA MSVC build log. Complement for PR 3567. Now in another place. D:\dev\eden\src\dynarmic\src\dynarmic\backend\x64\emit_x64_vector_floating_point.cpp(207): warning C4127: conditional expression is constant D:\dev\eden\src\dynarmic\src\dynarmic\backend\x64\emit_x64_vector_floating_point.cpp(207): note: consider using 'if constexpr' statement instead Signed-off-by: xbzk --- src/dynarmic/src/dynarmic/common/assert.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/dynarmic/src/dynarmic/common/assert.h b/src/dynarmic/src/dynarmic/common/assert.h index adface269a..27fa80e7f5 100644 --- a/src/dynarmic/src/dynarmic/common/assert.h +++ b/src/dynarmic/src/dynarmic/common/assert.h @@ -9,7 +9,12 @@ // TODO: Use source_info? [[noreturn]] void assert_terminate_impl(const char* s); #ifndef ASSERT -# define ASSERT(expr) do if(!(expr)) [[unlikely]] assert_terminate_impl(__FILE__ ": " #expr); while(0) +# define ASSERT(expr) \ + do { \ + const bool cond = static_cast(expr); \ + if(!cond) \ + [[unlikely]] assert_terminate_impl(__FILE__ ": " #expr); \ + } while(0) #endif #ifndef UNREACHABLE # ifdef _MSC_VER