Merge pull request #580 from lioncash/emplace

core/video_core: Use in-place construction where possible

src/core/core_timing.cpp

@@ -129,7 +129,7 @@ static void FreeTsEvent(Event* event) {
 }
 
 int RegisterEvent(const char* name, TimedCallback callback) {
-    event_types.push_back(EventType(callback, name));
+    event_types.emplace_back(callback, name);
     return (int)event_types.size() - 1;
 }
 

src/video_core/debug_utils/debug_utils.cpp

@@ -189,7 +189,7 @@ void DumpShader(const u32* binary_data, u32 binary_size, const u32* swizzle_data
                                         );
 
                     if (it == output_info_table.end()) {
-                        output_info_table.push_back({});
+                        output_info_table.emplace_back();
                         output_info_table.back().type = type;
                         output_info_table.back().component_mask = component_mask;
                         output_info_table.back().id = i;
@@ -285,7 +285,7 @@ void OnPicaRegWrite(u32 id, u32 value)
     if (!is_pica_tracing)
         return;
 
-    pica_trace->writes.push_back({id, value});
+    pica_trace->writes.emplace_back(id, value);
 }
 
 std::unique_ptr<PicaTrace> FinishPicaTracing()

src/video_core/gpu_debugger.h

@@ -58,8 +58,8 @@ public:
         if (observers.empty())
             return;
 
-        gx_command_history.push_back(GSP_GPU::Command());
-        GSP_GPU::Command& cmd = gx_command_history[gx_command_history.size()-1];
+        gx_command_history.emplace_back();
+        GSP_GPU::Command& cmd = gx_command_history.back();
 
         memcpy(&cmd, command_data, sizeof(GSP_GPU::Command));