Browse Source
Merge pull request #2298 from lioncash/variable
video_core/{gl_rasterizer, gpu_thread}: Remove unused class variables where applicable
pull/15/merge
bunnei
7 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with
7 additions and
14 deletions
-
src/video_core/gpu_thread.cpp
-
src/video_core/gpu_thread.h
-
src/video_core/renderer_opengl/gl_rasterizer.cpp
-
src/video_core/renderer_opengl/gl_rasterizer.h
-
src/video_core/renderer_opengl/renderer_opengl.cpp
|
|
|
@ -52,8 +52,8 @@ static void RunThread(VideoCore::RendererBase& renderer, Tegra::DmaPusher& dma_p |
|
|
|
} |
|
|
|
|
|
|
|
ThreadManager::ThreadManager(VideoCore::RendererBase& renderer, Tegra::DmaPusher& dma_pusher) |
|
|
|
: renderer{renderer}, dma_pusher{dma_pusher}, thread{RunThread, std::ref(renderer), |
|
|
|
std::ref(dma_pusher), std::ref(state)} {} |
|
|
|
: renderer{renderer}, thread{RunThread, std::ref(renderer), std::ref(dma_pusher), |
|
|
|
std::ref(state)} {} |
|
|
|
|
|
|
|
ThreadManager::~ThreadManager() { |
|
|
|
// Notify GPU thread that a shutdown is pending
|
|
|
|
|
|
|
|
@ -4,10 +4,8 @@ |
|
|
|
|
|
|
|
#pragma once |
|
|
|
|
|
|
|
#include <array> |
|
|
|
#include <atomic> |
|
|
|
#include <condition_variable> |
|
|
|
#include <memory> |
|
|
|
#include <mutex> |
|
|
|
#include <optional> |
|
|
|
#include <thread> |
|
|
|
@ -177,7 +175,6 @@ private: |
|
|
|
private: |
|
|
|
SynchState state; |
|
|
|
VideoCore::RendererBase& renderer; |
|
|
|
Tegra::DmaPusher& dma_pusher; |
|
|
|
std::thread thread; |
|
|
|
std::thread::id thread_id; |
|
|
|
}; |
|
|
|
|
|
|
|
@ -100,11 +100,9 @@ struct FramebufferCacheKey { |
|
|
|
} |
|
|
|
}; |
|
|
|
|
|
|
|
RasterizerOpenGL::RasterizerOpenGL(Core::Frontend::EmuWindow& window, Core::System& system, |
|
|
|
ScreenInfo& info) |
|
|
|
: res_cache{*this}, shader_cache{*this, system}, global_cache{*this}, |
|
|
|
emu_window{window}, system{system}, screen_info{info}, |
|
|
|
buffer_cache(*this, STREAM_BUFFER_SIZE) { |
|
|
|
RasterizerOpenGL::RasterizerOpenGL(Core::System& system, ScreenInfo& info) |
|
|
|
: res_cache{*this}, shader_cache{*this, system}, global_cache{*this}, system{system}, |
|
|
|
screen_info{info}, buffer_cache(*this, STREAM_BUFFER_SIZE) { |
|
|
|
// Create sampler objects
|
|
|
|
for (std::size_t i = 0; i < texture_samplers.size(); ++i) { |
|
|
|
texture_samplers[i].Create(); |
|
|
|
|
|
|
|
@ -50,8 +50,7 @@ struct FramebufferCacheKey; |
|
|
|
|
|
|
|
class RasterizerOpenGL : public VideoCore::RasterizerInterface { |
|
|
|
public: |
|
|
|
explicit RasterizerOpenGL(Core::Frontend::EmuWindow& window, Core::System& system, |
|
|
|
ScreenInfo& info); |
|
|
|
explicit RasterizerOpenGL(Core::System& system, ScreenInfo& info); |
|
|
|
~RasterizerOpenGL() override; |
|
|
|
|
|
|
|
void DrawArrays() override; |
|
|
|
@ -214,7 +213,6 @@ private: |
|
|
|
ShaderCacheOpenGL shader_cache; |
|
|
|
GlobalRegionCacheOpenGL global_cache; |
|
|
|
|
|
|
|
Core::Frontend::EmuWindow& emu_window; |
|
|
|
Core::System& system; |
|
|
|
|
|
|
|
ScreenInfo& screen_info; |
|
|
|
|
|
|
|
@ -266,7 +266,7 @@ void RendererOpenGL::CreateRasterizer() { |
|
|
|
} |
|
|
|
// Initialize sRGB Usage
|
|
|
|
OpenGLState::ClearsRGBUsed(); |
|
|
|
rasterizer = std::make_unique<RasterizerOpenGL>(render_window, system, screen_info); |
|
|
|
rasterizer = std::make_unique<RasterizerOpenGL>(system, screen_info); |
|
|
|
} |
|
|
|
|
|
|
|
void RendererOpenGL::ConfigureFramebufferTexture(TextureInfo& texture, |
|
|
|
|