Browse Source

core/reporter: Allow moves into SaveToFile()

Taking the json instance as a constant reference, makes all moves into
the parameter non-functional, resulting in copies. Taking it by value
allows moves to function.
nce_cpp
Lioncash 7 years ago
parent
commit
d360b7465f
  1. 2
      src/core/reporter.cpp

2
src/core/reporter.cpp

@ -34,7 +34,7 @@ std::string GetTimestamp() {
using namespace nlohmann; using namespace nlohmann;
void SaveToFile(const json& json, const std::string& filename) {
void SaveToFile(json json, const std::string& filename) {
if (!FileUtil::CreateFullPath(filename)) { if (!FileUtil::CreateFullPath(filename)) {
LOG_ERROR(Core, "Failed to create path for '{}' to save report!", filename); LOG_ERROR(Core, "Failed to create path for '{}' to save report!", filename);
return; return;

Loading…
Cancel
Save