From cde6b6fe73aee41afa02e8b64cb1f9702b713c76 Mon Sep 17 00:00:00 2001 From: lizzie Date: Sat, 13 Sep 2025 20:48:40 +0000 Subject: [PATCH] [gamemode] default disable on msvc, move to UI category Signed-off-by: lizzie --- src/common/settings.h | 10 ++++++++-- src/common/settings_common.h | 1 - src/qt_common/config/shared_translation.cpp | 2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/common/settings.h b/src/common/settings.h index 674813452e..8ecb8a79e4 100644 --- a/src/common/settings.h +++ b/src/common/settings.h @@ -621,8 +621,14 @@ struct Values { true, true}; - // Linux - SwitchableSetting enable_gamemode{linkage, true, "enable_gamemode", Category::Linux}; + // Linux/MinGW may support (requires libdl support) + SwitchableSetting enable_gamemode{linkage, +#ifndef _MSC_VER + true, +#else + false, +#endif + "enable_gamemode", Category::UiGeneral}; #ifdef __unix__ SwitchableSetting gui_force_x11{linkage, false, "gui_force_x11", Category::Linux}; Setting gui_hide_backend_warning{linkage, false, "gui_hide_backend_warning", Category::Linux}; diff --git a/src/common/settings_common.h b/src/common/settings_common.h index af16ec692b..7902cbf945 100644 --- a/src/common/settings_common.h +++ b/src/common/settings_common.h @@ -44,7 +44,6 @@ enum class Category : u32 { Multiplayer, Services, Paths, - Linux, LibraryApplet, MaxEnum, }; diff --git a/src/qt_common/config/shared_translation.cpp b/src/qt_common/config/shared_translation.cpp index c601d25d80..36009d8590 100644 --- a/src/qt_common/config/shared_translation.cpp +++ b/src/qt_common/config/shared_translation.cpp @@ -433,7 +433,7 @@ std::unique_ptr InitializeTranslations(QObject* parent) tr("Whether or not to check for updates upon startup.")); // Linux - INSERT(Settings, enable_gamemode, tr("Enable Gamemode"), QString()); + INSERT(UISettings, enable_gamemode, tr("Enable Gamemode"), QString()); #ifdef __unix__ INSERT(Settings, gui_force_x11, tr("Force X11 as Graphics Backend"), QString()); INSERT(Settings, gui_hide_backend_warning, QString(), QString());