From c59d12b0cd3c0643910267276d5ed23ea55c77a8 Mon Sep 17 00:00:00 2001 From: Maufeat Date: Mon, 26 Jan 2026 16:04:09 +0100 Subject: [PATCH] [olsc] Rename Unknown27 to GetDataInfoV2 and fix crash on FW19 (#3387) Thanks to FW19, I know that 27 is GetDataInfoV2. Fixes crash on FW19. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3387 Reviewed-by: MaranBr Reviewed-by: crueter Co-authored-by: Maufeat Co-committed-by: Maufeat --- src/core/hle/service/olsc/remote_storage_controller.cpp | 6 +++--- src/core/hle/service/olsc/remote_storage_controller.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/hle/service/olsc/remote_storage_controller.cpp b/src/core/hle/service/olsc/remote_storage_controller.cpp index 46536f9ff1..817097b426 100644 --- a/src/core/hle/service/olsc/remote_storage_controller.cpp +++ b/src/core/hle/service/olsc/remote_storage_controller.cpp @@ -28,7 +28,7 @@ IRemoteStorageController::IRemoteStorageController(Core::System& system_) {15, nullptr, "RegisterUploadSaveDataTransferTaskForAutonomyRegistration"}, {16, nullptr, "CreateCleanupToDeleteSaveDataArchiveInfoTask"}, {17, nullptr, "ListDataInfo"}, - {18, nullptr, "GetDataInfo"}, + {18, D<&IRemoteStorageController::GetDataInfo>, "GetDataInfoV1"}, {19, nullptr, "GetDataInfoCacheUpdateNativeHandleHolder"}, {20, nullptr, "CreateSaveDataArchiveInfoCacheForSaveDataBackupUpdationTask"}, {21, nullptr, "ListSecondarySaves"}, @@ -37,7 +37,7 @@ IRemoteStorageController::IRemoteStorageController(Core::System& system_) {24, nullptr, "GetSecondarySaveDataInfo"}, {25, nullptr, "RegisterDownloadSaveDataTransferTaskForAutonomyRegistration"}, {26, nullptr, "Unknown26"}, //20.0.0+ - {27, D<&IRemoteStorageController::Unknown27>, "Unknown27"}, //20.0.0+ + {27, D<&IRemoteStorageController::GetDataInfo>, "GetDataInfoV2"}, //20.0.0+ {28, nullptr, "Unknown28"}, //20.0.0+ {29, nullptr, "Unknown29"}, //21.0.0+ {800, nullptr, "Unknown800"}, //20.0.0+ @@ -67,7 +67,7 @@ Result IRemoteStorageController::GetDataNewnessByApplicationId(Out out_newne R_SUCCEED(); } -Result IRemoteStorageController::Unknown27(Out> out_data, u64 application_id) { +Result IRemoteStorageController::GetDataInfo(Out> out_data, u64 application_id) { LOG_WARNING(Service_OLSC, "(STUBBED) called, application_id={:016X}", application_id); out_data->fill(0); R_SUCCEED(); diff --git a/src/core/hle/service/olsc/remote_storage_controller.h b/src/core/hle/service/olsc/remote_storage_controller.h index 85f681dfae..bae1e8efb5 100644 --- a/src/core/hle/service/olsc/remote_storage_controller.h +++ b/src/core/hle/service/olsc/remote_storage_controller.h @@ -18,7 +18,7 @@ private: Result GetSecondarySave(Out out_has_secondary_save, Out> out_unknown, u64 application_id); Result GetDataNewnessByApplicationId(Out out_newness, u64 application_id); - Result Unknown27(Out> out_data, u64 application_id); + Result GetDataInfo(Out> out_data, u64 application_id); }; } // namespace Service::OLSC