Browse Source

[loader] log error messages when failing to load

remotes/1785372757367212240/tmp_refs/heads/variable-page-size
Exverge 1 month ago
parent
commit
b13653d698
No known key found for this signature in database GPG Key ID: DAD399BCC5FB77E4
  1. 3
      src/core/loader/deconstructed_rom_directory.cpp
  2. 3
      src/core/loader/kip.cpp
  3. 5
      src/core/loader/nro.cpp

3
src/core/loader/deconstructed_rom_directory.cpp

@ -235,7 +235,8 @@ AppLoader_DeconstructedRomDirectory::LoadResult AppLoader_DeconstructedRomDirect
? ::Settings::values.rng_seed.GetValue() : Common::Random::Random64(0)) << 12) & 0xffffff & ~(Common::HostPageSize - 1);
// Setup the process code layout
if (process.LoadFromMetadata(system.Kernel(), metadata, code_size, fastmem_base, aslr_offset).IsError()) {
if (auto res = process.LoadFromMetadata(system.Kernel(), metadata, code_size, fastmem_base, aslr_offset); res.IsError()) {
LOG_CRITICAL(Loader, "Failed to load ROM directory! (Error {})", res.GetDescription());
return {ResultStatus::ErrorUnableToParseKernelMetadata, {}};
}

3
src/core/loader/kip.cpp

@ -93,7 +93,8 @@ AppLoader::LoadResult AppLoader_KIP::Load(Kernel::KProcess& process,
? ::Settings::values.rng_seed.GetValue() : Common::Random::Random64(0)) << 12) & 0xffffff & ~(Common::HostPageSize - 1);
// Setup the process code layout
if (process.LoadFromMetadata(system.Kernel(), FileSys::ProgramMetadata::GetDefault(), codeset.memory.size(), 0, aslr_offset).IsError()) {
if (auto res = process.LoadFromMetadata(system.Kernel(), FileSys::ProgramMetadata::GetDefault(), codeset.memory.size(), 0, aslr_offset); res.IsError()) {
LOG_CRITICAL(Loader, "Failed to load KIP! (Error {})", res.GetDescription());
return {ResultStatus::ErrorNotInitialized, {}};
}
const VAddr base_address = GetInteger(process.GetEntryPoint());

5
src/core/loader/nro.cpp

@ -279,9 +279,8 @@ static bool LoadNroImpl(Core::System& system, Kernel::KProcess& process,
? ::Settings::values.rng_seed.GetValue() : Common::Random::Random64(0)) << 12) & 0xffffff & ~(Common::HostPageSize - 1);
// Setup the process code layout
if (process
.LoadFromMetadata(system.Kernel(), FileSys::ProgramMetadata::GetDefault(), image_size, fastmem_base, aslr_offset)
.IsError()) {
if (auto res = process.LoadFromMetadata(system.Kernel(), FileSys::ProgramMetadata::GetDefault(), image_size, fastmem_base, aslr_offset); res.IsError()) {
LOG_CRITICAL(Loader, "Failed to load NRO! (Error {})", res.GetDescription());
return false;
}

Loading…
Cancel
Save