From ab1d99d2187b05fc43f86b0d0f24838da714f86e Mon Sep 17 00:00:00 2001 From: CamilleLaVey Date: Fri, 31 Jul 2026 17:31:43 -0400 Subject: [PATCH] some debugs tools --- .../renderer_vulkan/vk_rasterizer.cpp | 13 +++++++++++++ src/video_core/texture_cache/texture_cache.h | 17 +++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index ac1e7a9677..3c9526dde6 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp @@ -6,6 +6,7 @@ #include #include +#include #include #include #include @@ -103,8 +104,20 @@ VkViewport GetViewportState(const Device& device, const Maxwell& regs, size_t in .maxDepth = src.translate_z + src.scale_z, }; if (!device.IsExtDepthRangeUnrestrictedSupported()) { + const float unclamped_min = viewport.minDepth; + const float unclamped_max = viewport.maxDepth; viewport.minDepth = std::clamp(viewport.minDepth, 0.0f, 1.0f); viewport.maxDepth = std::clamp(viewport.maxDepth, 0.0f, 1.0f); + if (viewport.minDepth != unclamped_min || viewport.maxDepth != unclamped_max) { + static std::atomic reported{0}; + if (reported.fetch_add(1, std::memory_order_relaxed) < 32) { + LOG_WARNING(Render_Vulkan, + "Depth range clamped: viewport={} mode={} translate_z={} scale_z={} " + "range=[{}, {}] -> [{}, {}]", + index, static_cast(regs.depth_mode), src.translate_z, src.scale_z, + unclamped_min, unclamped_max, viewport.minDepth, viewport.maxDepth); + } + } } return viewport; } diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h index f00d645055..d02abc8944 100644 --- a/src/video_core/texture_cache/texture_cache.h +++ b/src/video_core/texture_cache/texture_cache.h @@ -1791,6 +1791,8 @@ ImageId TextureCache

::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, DA ImageBase& aliased = slot_images[aliased_id]; aliased.overlapping_images.push_back(new_image_id); new_image.overlapping_images.push_back(aliased_id); + const bool aliased_was_bad = True(aliased.flags & ImageFlagBits::BadOverlap); + const bool new_was_bad = True(new_image.flags & ImageFlagBits::BadOverlap); if (aliased.info.resources.levels == 1 && aliased.info.block.depth == 0 && aliased.overlapping_images.size() > 1) { aliased.flags |= ImageFlagBits::BadOverlap; @@ -1799,6 +1801,21 @@ ImageId TextureCache

::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, DA new_image.overlapping_images.size() > 1) { new_image.flags |= ImageFlagBits::BadOverlap; } + const bool aliased_is_bad = True(aliased.flags & ImageFlagBits::BadOverlap); + const bool new_is_bad = True(new_image.flags & ImageFlagBits::BadOverlap); + if ((!aliased_was_bad && aliased_is_bad) || (!new_was_bad && new_is_bad)) { + LOG_WARNING(HW_GPU, + "Bad overlap: existing gpu_addr={:#x} {}x{}x{} fmt={} type={} rt={} | " + "incoming gpu_addr={:#x} {}x{}x{} fmt={} type={} rt={}", + aliased.gpu_addr, aliased.info.size.width, aliased.info.size.height, + aliased.info.size.depth, static_cast(aliased.info.format), + static_cast(aliased.info.type), + True(aliased.flags & ImageFlagBits::GpuModified), + new_image.gpu_addr, new_image.info.size.width, new_image.info.size.height, + new_image.info.size.depth, static_cast(new_image.info.format), + static_cast(new_image.info.type), + True(new_image.flags & ImageFlagBits::GpuModified)); + } } for (const auto& copy_object : join_copies_to_do) {