Browse Source
Merge pull request #8404 from Morph1984/virtual
core/debugger: Define defaulted virtual destructors
pull/15/merge
liamwhite
4 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with
6 additions and
2 deletions
-
src/core/debugger/debugger.cpp
-
src/core/debugger/debugger_interface.h
-
src/core/debugger/gdbstub.h
|
|
|
@ -50,7 +50,7 @@ public: |
|
|
|
InitializeServer(port); |
|
|
|
} |
|
|
|
|
|
|
|
~DebuggerImpl() { |
|
|
|
~DebuggerImpl() override { |
|
|
|
ShutdownServer(); |
|
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
@ -24,6 +24,8 @@ enum class DebuggerAction { |
|
|
|
|
|
|
|
class DebuggerBackend { |
|
|
|
public: |
|
|
|
virtual ~DebuggerBackend() = default; |
|
|
|
|
|
|
|
/** |
|
|
|
* Can be invoked from a callback to synchronously wait for more data. |
|
|
|
* Will return as soon as least one byte is received. Reads up to 4096 bytes. |
|
|
|
@ -51,6 +53,8 @@ class DebuggerFrontend { |
|
|
|
public: |
|
|
|
explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {} |
|
|
|
|
|
|
|
virtual ~DebuggerFrontend() = default; |
|
|
|
|
|
|
|
/** |
|
|
|
* Called after the client has successfully connected to the port. |
|
|
|
*/ |
|
|
|
|
|
|
|
@ -19,7 +19,7 @@ class System; |
|
|
|
class GDBStub : public DebuggerFrontend { |
|
|
|
public: |
|
|
|
explicit GDBStub(DebuggerBackend& backend, Core::System& system); |
|
|
|
~GDBStub(); |
|
|
|
~GDBStub() override; |
|
|
|
|
|
|
|
void Connected() override; |
|
|
|
void Stopped(Kernel::KThread* thread) override; |
|
|
|
|