[vk,fence_manager] improvement for antiflicker showed bad for some games, so it was removed from balanced/accurate and kept for antiflicker toggle only (#4010)

in short:

unrelated to the toggle, we found a missing piece that improved antiflicker and shader issues in some games, and we integrated it to balanced/accurate.
now testers confirmed side effects in some other games, so we reverted the integration.

the toggle itself is innocent. and the missing piece was kept for the toggle.
now, when the toggle is off, things are as they were before it.

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4010
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Reviewed-by: Lizzie <lizzie@eden-emu.dev>

src/video_core/fence_manager.h

@@ -76,9 +76,12 @@ public:
             TryReleasePendingFences<false>();
         }
         const bool should_flush = ShouldFlush();
-        const bool delay_fence = Settings::values.antiflicker.GetValue() || !Settings::IsGPULevelLow();
+        const bool antiflicker_toggled = Settings::values.antiflicker.GetValue();
+        const bool delay_fence = Settings::IsGPULevelHigh() ||
+                                 (Settings::IsGPULevelMedium() && should_flush) ||
+                                 antiflicker_toggled;
         CommitAsyncFlushes();
-        TFence new_fence = CreateFence(!should_flush && !delay_fence);
+        TFence new_fence = CreateFence(!should_flush && !antiflicker_toggled);
         if constexpr (can_async_check) {
             guard.lock();
         }