Browse Source
[*] basic in-house cpp linting (#4039)
[*] basic in-house cpp linting (#4039)
- add `#pragma once` to remainder files - "correcter" defines (ANDROID), see https://groups.google.com/g/android-ndk/c/cf9_f1SLXls - extra miscelly fixups Signed-off-by: lizzie <lizzie@eden-emu.dev> Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4039 Reviewed-by: MaranBr <maranbr@eden-emu.dev> Reviewed-by: crueter <crueter@eden-emu.dev>pull/4055/head
lizzie
3 weeks ago
committed by
crueter
crueter
No known key found for this signature in database
GPG Key ID: 425ACD2D4830EBC6
53 changed files with 176 additions and 153 deletions
-
4CMakeLists.txt
-
2src/common/cpu_features.cpp
-
5src/common/error.cpp
-
6src/common/fs/file.cpp
-
10src/common/fs/fs.cpp
-
10src/common/fs/path_util.cpp
-
6src/common/logging.cpp
-
20src/common/settings.h
-
6src/common/string_util.cpp
-
6src/common/swap.h
-
2src/core/debugger/debugger.cpp
-
4src/core/file_sys/vfs/vfs_real.cpp
-
2src/core/tools/renderdoc.cpp
-
2src/dynarmic/src/dynarmic/backend/x64/devirtualize.h
-
2src/frontend_common/config.cpp
-
7src/frontend_common/data_manager.h
-
4src/frontend_common/firmware_manager.cpp
-
7src/frontend_common/firmware_manager.h
-
1src/frontend_common/mod_manager.h
-
2src/hid_core/frontend/emulated_controller.cpp
-
22src/input_common/main.cpp
-
4src/qt_common/abstract/frontend.h
-
4src/qt_common/qt_common.h
-
4src/qt_common/util/applet.h
-
4src/qt_common/util/content.h
-
4src/qt_common/util/fs.h
-
5src/qt_common/util/game.h
-
4src/qt_common/util/meta.h
-
5src/qt_common/util/path.h
-
9src/qt_common/util/rom.h
-
2src/shader_recompiler/backend/spirv/emit_spirv_convert.cpp
-
2src/shader_recompiler/backend/spirv/emit_spirv_image.cpp
-
2src/video_core/buffer_cache/buffer_cache.h
-
4src/video_core/gpu_logging/freedreno_debug.cpp
-
4src/video_core/gpu_logging/freedreno_debug.h
-
4src/video_core/host1x/ffmpeg.cpp
-
4src/video_core/renderer_vulkan/vk_pipeline_cache.cpp
-
2src/video_core/renderer_vulkan/vk_present_manager.cpp
-
4src/video_core/renderer_vulkan/vk_rasterizer.cpp
-
6src/video_core/renderer_vulkan/vk_swapchain.cpp
-
12src/video_core/renderer_vulkan/vk_turbo_mode.cpp
-
5src/video_core/renderer_vulkan/vk_turbo_mode.h
-
8src/video_core/smaa_area_tex.h
-
8src/video_core/smaa_search_tex.h
-
2src/video_core/vulkan_common/vulkan_debug_callback.cpp
-
6src/video_core/vulkan_common/vulkan_device.cpp
-
2src/video_core/vulkan_common/vulkan_library.cpp
-
4src/video_core/vulkan_common/vulkan_wrapper.h
-
5src/yuzu/data_dialog.h
-
5src/yuzu/migration_dialog.h
-
5src/yuzu/migration_worker.h
-
5src/yuzu/ryujinx_dialog.h
-
55tools/cpp-lint.sh
@ -1,9 +1,7 @@ |
|||
// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project |
|||
// SPDX-License-Identifier: GPL-3.0-or-later |
|||
|
|||
#ifndef QT_APPLET_UTIL_H |
|||
#define QT_APPLET_UTIL_H |
|||
#pragma once |
|||
|
|||
// TODO |
|||
namespace QtCommon::Applets {} |
|||
#endif // QT_APPLET_UTIL_H |
|||
@ -1,16 +1,11 @@ |
|||
// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project |
|||
// SPDX-License-Identifier: GPL-3.0-or-later |
|||
|
|||
#ifndef QT_ROM_UTIL_H |
|||
#define QT_ROM_UTIL_H |
|||
#pragma once |
|||
|
|||
#include <cstddef> |
|||
#include "qt_common/qt_common.h" |
|||
|
|||
namespace QtCommon::ROM { |
|||
|
|||
bool RomFSRawCopy(size_t total_size, size_t& read_size, QtProgressCallback callback, |
|||
const FileSys::VirtualDir& src, const FileSys::VirtualDir& dest, bool full); |
|||
|
|||
bool RomFSRawCopy(size_t total_size, size_t& read_size, QtProgressCallback callback, const FileSys::VirtualDir& src, const FileSys::VirtualDir& dest, bool full); |
|||
} |
|||
#endif // QT_ROM_UTIL_H |
|||
@ -0,0 +1,55 @@ |
|||
#!/bin/sh -ex |
|||
|
|||
# SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project |
|||
# SPDX-License-Identifier: GPL-3.0-or-later |
|||
|
|||
# tools/../ |
|||
ROOTDIR=$(CDPATH='' cd -- "$(dirname -- "$0")/../" && pwd) |
|||
BUILD_DIR="$ROOTDIR"/build |
|||
SRC_DIR="$ROOTDIR"/src |
|||
|
|||
die() { |
|||
echo "-- $*" >&2 |
|||
exit 1 |
|||
} |
|||
|
|||
usage() { |
|||
cat <<EOF |
|||
Usage: $0 [command] |
|||
|
|||
Dumb script that serves as a ad-hoc cpp-linter |
|||
|
|||
Commands: |
|||
once Check for #pragma once prescence in header files |
|||
osdef Finds OS defines that are not recommended to use. |
|||
inchk Check includes being valid/toolchain not being stupid |
|||
EOF |
|||
} |
|||
|
|||
while :; do |
|||
case "$1" in |
|||
once) |
|||
find "$SRC_DIR" -type f -name "*.h" -exec grep -L "#pragma once" {} + |
|||
break |
|||
;; |
|||
osdef) |
|||
# not recommended macros |
|||
PATTERN="ANDROID\|_WIN64\|__linux\|__unix\|APPLE\|__APPLE" |
|||
strings=("ANDROID" "_WIN64" "__linux" "__unix" "APPLE" "__APPLE" "linux" "unix") |
|||
for item in "${strings[@]}"; do |
|||
PATTERN="$PATTERN\|ifdef $item\|($item)" |
|||
done |
|||
# if statements for macros that shouldn't be if |
|||
strings=("_WIN32" "_AIX" "__managarm__" "__unix__" "__linux__" "__FreeBSD__" "__NetBSD__" \ |
|||
"__OpenBSD__" "__DragonFly__" "__redox__" "__HAIKU__" "__OHOS__" "__FIREOS__") |
|||
for item in "${strings[@]}"; do |
|||
PATTERN="$PATTERN\|if $item" |
|||
done |
|||
find "$SRC_DIR" -type f -name "*.h" -exec grep -nw "$PATTERN" {} + || echo |
|||
break |
|||
;; |
|||
*) usage ;; |
|||
esac |
|||
|
|||
shift |
|||
done |
|||
Write
Preview
Loading…
Cancel
Save
Reference in new issue