Browse Source

fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem()

Initialize id to a deterministic value and also mark the unreachable
cases in the switch with UNREACHABLE().
pull/15/merge
Lioncash 5 years ago
parent
commit
85db5f4091
  1. 7
      src/core/hle/service/filesystem/fsp_srv.cpp

7
src/core/hle/service/filesystem/fsp_srv.cpp

@ -844,8 +844,7 @@ void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) {
return; return;
} }
FileSys::StorageId id;
FileSys::StorageId id{};
switch (parameters.space_id) { switch (parameters.space_id) {
case FileSys::SaveDataSpaceId::NandUser: case FileSys::SaveDataSpaceId::NandUser:
id = FileSys::StorageId::NandUser; id = FileSys::StorageId::NandUser;
@ -857,6 +856,10 @@ void FSP_SRV::OpenSaveDataFileSystem(Kernel::HLERequestContext& ctx) {
case FileSys::SaveDataSpaceId::NandSystem: case FileSys::SaveDataSpaceId::NandSystem:
id = FileSys::StorageId::NandSystem; id = FileSys::StorageId::NandSystem;
break; break;
case FileSys::SaveDataSpaceId::TemporaryStorage:
case FileSys::SaveDataSpaceId::ProperSystem:
case FileSys::SaveDataSpaceId::SafeMode:
UNREACHABLE();
} }
auto filesystem = auto filesystem =

Loading…
Cancel
Save