Browse Source
Merge pull request #7825 from lioncash/nodisc2
common/file: Remove [[nodiscard]] from Open()
pull/15/merge
Morph
4 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with
2 additions and
3 deletions
-
src/common/fs/file.h
|
|
@ -188,9 +188,8 @@ public: |
|
|
|
|
|
|
|
|
#ifdef _WIN32 |
|
|
#ifdef _WIN32 |
|
|
template <typename Path> |
|
|
template <typename Path> |
|
|
[[nodiscard]] void Open(const Path& path, FileAccessMode mode, |
|
|
|
|
|
FileType type = FileType::BinaryFile, |
|
|
|
|
|
FileShareFlag flag = FileShareFlag::ShareReadOnly) { |
|
|
|
|
|
|
|
|
void Open(const Path& path, FileAccessMode mode, FileType type = FileType::BinaryFile, |
|
|
|
|
|
FileShareFlag flag = FileShareFlag::ShareReadOnly) { |
|
|
using ValueType = typename Path::value_type; |
|
|
using ValueType = typename Path::value_type; |
|
|
if constexpr (IsChar<ValueType>) { |
|
|
if constexpr (IsChar<ValueType>) { |
|
|
Open(ToU8String(path), mode, type, flag); |
|
|
Open(ToU8String(path), mode, type, flag); |
|
|
|
