From 6dc9bed6aae1f90844ce582e0580217c296629cd Mon Sep 17 00:00:00 2001 From: crueter Date: Mon, 29 Dec 2025 19:41:51 -0500 Subject: [PATCH] Revert "patch: mock return for textures not found by Track method (#150)" This reverts commit 1240cd43d70a502508115c9abb12f7ef27e1ca4e. --- src/shader_recompiler/ir_opt/texture_pass.cpp | 21 ++----------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/src/shader_recompiler/ir_opt/texture_pass.cpp b/src/shader_recompiler/ir_opt/texture_pass.cpp index 9f04c0afaf..e1d99f0f03 100644 --- a/src/shader_recompiler/ir_opt/texture_pass.cpp +++ b/src/shader_recompiler/ir_opt/texture_pass.cpp @@ -330,31 +330,14 @@ std::optional TryGetConstBuffer(const IR::Inst* inst, Environme }; } -// TODO:xbzk: shall be dropped when Track method cover all bindless stuff -static ConstBufferAddr last_valid_addr = ConstBufferAddr{ - .index = 0, - .offset = 0, - .shift_left = 0, - .secondary_index = 0, - .secondary_offset = 0, - .secondary_shift_left = 0, - .dynamic_offset = {}, - .count = 1, - .has_secondary = false, -}; - TextureInst MakeInst(Environment& env, IR::Block* block, IR::Inst& inst) { ConstBufferAddr addr; if (IsBindless(inst)) { const std::optional track_addr{Track(inst.Arg(0), env)}; - if (!track_addr) { - //throw NotImplementedException("Failed to track bindless texture constant buffer"); - addr = last_valid_addr; // TODO:xbzk: shall be dropped when Track method cover all bindless stuff - } else { - addr = *track_addr; - last_valid_addr = addr; // TODO:xbzk: shall be dropped when Track method cover all bindless stuff + throw NotImplementedException("Failed to track bindless texture constant buffer"); } + addr = *track_addr; } else { addr = ConstBufferAddr{ .index = env.TextureBoundBuffer(),